Skip to contentSkip to conversation

arm64: dts: rockchip: give some life to the rk3328-roc-cc leds

PATCH Superseded Leonidas P. Papadakos 2 participants 4 messages Mar 2, 2019 2 messages not in the archive

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm64: dts: rockchip: give some life to the rk3328-roc-cc leds

Assign the LEDs to heartbeat and sdcard io, as in other RK boards.

https://github.com/armbian/build/commit/f1affad5c7be62d6e93832af3556c7609edd0858

---
v2: Don't specify disabled IR led for now

---
 .../arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts +19 -0
index 33c44e857..171c377f8 100644
@@ -81,6 +81,25 @@
 		regulator-always-on;
 		regulator-boot-on;
 	};
+
+	leds {
+		compatible = "gpio-leds";
+		power {
+			label = "firefly:blue:power";
+			linux,default-trigger = "heartbeat";
+			gpios = <&rk805 1 GPIO_ACTIVE_LOW>;
+			default-state = "on";
+			mode = <0x23>;
+		};
+
+		user {
+			label = "firefly:yellow:user";
+			linux,default-trigger = "mmc1";
+			gpios = <&rk805 0 GPIO_ACTIVE_LOW>;
+			default-state = "off";
+			mode = <0x05>;
+		};
+	};
 };
 
 &cpu0 {
Signature · 1 line
2.21.0

A message that is not in the archive (sent off-list or not yet received): 20190302141335.4443-1-papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw
Quoted 6 lines · Leonidas P. Papadakos

Assign the LEDs to heartbeat and sdcard io, as in other RK boards.

https://github.com/armbian/build/commit/f1affad5c7be62d6e93832af3556c7609edd0858

I will reach out to JMCC at Armbian and see if he wants tagged as co-developer/etc. It's not a big thing, but would be good to ask.

Quoted 45 lines

---
v2: Don't specify disabled IR led for now

---
 .../arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts +19 -1
index 33c44e857..171c377f8 100644
@@ -81,6 +81,25 @@
                regulator-always-on;
                regulator-boot-on;
        };
+
+       leds {
+               compatible = "gpio-leds";
+               power {
+                       label = "firefly:blue:power";
+                       linux,default-trigger = "heartbeat";
+                       gpios = <&rk805 1 GPIO_ACTIVE_LOW>;
+                       default-state = "on";
+                       mode = <0x23>;
+               };
+
+               user {
+                       label = "firefly:yellow:user";
+                       linux,default-trigger = "mmc1";
+                       gpios = <&rk805 0 GPIO_ACTIVE_LOW>;
+                       default-state = "off";
+                       mode = <0x05>;
+               };
+       };
 };
 
 &cpu0 {
--

2.21.0

_______________________________________________
Linux-rockchip mailing list [email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

A message that is not in the archive (sent off-list or not yet received): CAERgokmRH2ebNQ8PcttyKKJ-yPQKwvWgvXcSAM_z=aa=yMSQFg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#4 lore raw
Quoted 11 lines · Tony McKahan
Quoted 6 lines · Leonidas P. Papadakos

Assign the LEDs to heartbeat and sdcard io, as in other RK boards.

https://github.com/armbian/build/commit/f1affad5c7be62d6e93832af3556c7609edd0858

I will reach out to JMCC at Armbian and see if he wants tagged as co-developer/etc. It's not a big thing, but would be good to ask.

Good idea! I didn't know what the "infastructure" for this inclusion was.

#5 lore raw
Quoted 7 lines · Leonidas P. Papadakos
Quoted 5 lines · Tony McKahan
Quoted 3 lines · Leonidas P. Papadakos

Assign the LEDs to heartbeat and sdcard io, as in other RK boards.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

https://github.com/armbian/build/commit/f1affad5c7be62d6e93832af3556c7609edd0858

I will reach out to JMCC at Armbian and see if he wants tagged as co-developer/etc. It's not a big thing, but would be good to ask.

Good idea! I didn't know what the "infastructure" for this inclusion was.

https://www.kernel.org/doc/html/v5.0-rc8/process/submitting-patches.html

Sections 12 and 13 specifically. I've been reading to try to get to where I'm willing to bother these guys with patches.