Skip to contentSkip to conversation

platform/x86: touchscreen_dmi: Add info for the CHUWI Hi10 Air tablet

PATCH Superseded [email protected] 3 participants 5 messages Mar 1, 2019 – Mar 5, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: touchscreen_dmi: Add info for the CHUWI Hi10 Air tablet

From: Christian Oder <[email protected]>

Add touchscreen info for the CHUWUI Hi10 Air tablet.

---
 drivers/platform/x86/touchscreen_dmi.c | 27 ++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
drivers/platform/x86/touchscreen_dmi.c +27 -0
index 167a156e3cc7..2d56ff7c8230 100644
@@ -72,6 +72,25 @@ static const struct ts_dmi_data chuwi_hi8_pro_data = {
 	.properties	= chuwi_hi8_pro_props,
 };
 
+static const struct property_entry chuwi_hi10_air_props[] = {
+	PROPERTY_ENTRY_U32("touchscreen-size-x", 1981),
+	PROPERTY_ENTRY_U32("touchscreen-size-y", 1271),
+	PROPERTY_ENTRY_U32("touchscreen-min-x", 99),
+	PROPERTY_ENTRY_U32("touchscreen-min-y", 9),
+	PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+	PROPERTY_ENTRY_U32("touchscreen-fuzz-x", 5),
+	PROPERTY_ENTRY_U32("touchscreen-fuzz-y", 4),
+	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-chuwi-hi10-air.fw"),
+	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+	PROPERTY_ENTRY_BOOL("silead,home-button"),
+	{ }
+};
+
+static const struct ts_dmi_data chuwi_hi10_air_data = {
+	.acpi_name	= "MSSL1680:00",
+	.properties	= chuwi_hi10_air_props,
+};
+
 static const struct property_entry chuwi_vi8_props[] = {
 	PROPERTY_ENTRY_U32("touchscreen-min-x", 4),
 	PROPERTY_ENTRY_U32("touchscreen-min-y", 6),
@@ -546,6 +565,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "X1D3_C806N"),
 		},
 	},
+	{
+		/* Chuwi Hi10 Air */
+		.driver_data = (void *)&chuwi_hi10_air_data,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
+			DMI_MATCH(DMI_PRODUCT_SKU, "P1W6_C109D_B"),
+		},
+	},
 	{
 		/* Chuwi Vi8 (CWI506) */
 		.driver_data = (void *)&chuwi_vi8_data,
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 5 lines · On 01-03-19 17:40, [email protected] wrote:

From: Christian Oder <[email protected]>

Add touchscreen info for the CHUWUI Hi10 Air tablet.

Thank you for the patch, patch looks good to me:

Regards,

Hans

Quoted 50 lines
---
  drivers/platform/x86/touchscreen_dmi.c | 27 ++++++++++++++++++++++++++
  1 file changed, 27 insertions(+)
drivers/platform/x86/touchscreen_dmi.c +27 -0
index 167a156e3cc7..2d56ff7c8230 100644
@@ -72,6 +72,25 @@ static const struct ts_dmi_data chuwi_hi8_pro_data = {
  	.properties	= chuwi_hi8_pro_props,
  };
 
+static const struct property_entry chuwi_hi10_air_props[] = {
+	PROPERTY_ENTRY_U32("touchscreen-size-x", 1981),
+	PROPERTY_ENTRY_U32("touchscreen-size-y", 1271),
+	PROPERTY_ENTRY_U32("touchscreen-min-x", 99),
+	PROPERTY_ENTRY_U32("touchscreen-min-y", 9),
+	PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+	PROPERTY_ENTRY_U32("touchscreen-fuzz-x", 5),
+	PROPERTY_ENTRY_U32("touchscreen-fuzz-y", 4),
+	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-chuwi-hi10-air.fw"),
+	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+	PROPERTY_ENTRY_BOOL("silead,home-button"),
+	{ }
+};
+
+static const struct ts_dmi_data chuwi_hi10_air_data = {
+	.acpi_name	= "MSSL1680:00",
+	.properties	= chuwi_hi10_air_props,
+};
+
  static const struct property_entry chuwi_vi8_props[] = {
  	PROPERTY_ENTRY_U32("touchscreen-min-x", 4),
  	PROPERTY_ENTRY_U32("touchscreen-min-y", 6),
@@ -546,6 +565,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
  			DMI_MATCH(DMI_PRODUCT_NAME, "X1D3_C806N"),
  		},
  	},
+	{
+		/* Chuwi Hi10 Air */
+		.driver_data = (void *)&chuwi_hi10_air_data,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
+			DMI_MATCH(DMI_PRODUCT_SKU, "P1W6_C109D_B"),
+		},
+	},
  	{
  		/* Chuwi Vi8 (CWI506) */
  		.driver_data = (void *)&chuwi_vi8_data,
#2 lore raw

PATCH v2 1/1 platform/x86: touchscreen_dmi: Add info for the CHUWI Hi10 Air tablet

Add touchscreen info for the CHUWUI Hi10 Air tablet.

---
Changes in v2:
- added review tag

 drivers/platform/x86/touchscreen_dmi.c | 27 ++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
drivers/platform/x86/touchscreen_dmi.c +27 -0
index 167a156e3cc7..2d56ff7c8230 100644
@@ -72,6 +72,25 @@ static const struct ts_dmi_data chuwi_hi8_pro_data = {
 	.properties	= chuwi_hi8_pro_props,
 };
 
+static const struct property_entry chuwi_hi10_air_props[] = {
+	PROPERTY_ENTRY_U32("touchscreen-size-x", 1981),
+	PROPERTY_ENTRY_U32("touchscreen-size-y", 1271),
+	PROPERTY_ENTRY_U32("touchscreen-min-x", 99),
+	PROPERTY_ENTRY_U32("touchscreen-min-y", 9),
+	PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+	PROPERTY_ENTRY_U32("touchscreen-fuzz-x", 5),
+	PROPERTY_ENTRY_U32("touchscreen-fuzz-y", 4),
+	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-chuwi-hi10-air.fw"),
+	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+	PROPERTY_ENTRY_BOOL("silead,home-button"),
+	{ }
+};
+
+static const struct ts_dmi_data chuwi_hi10_air_data = {
+	.acpi_name	= "MSSL1680:00",
+	.properties	= chuwi_hi10_air_props,
+};
+
 static const struct property_entry chuwi_vi8_props[] = {
 	PROPERTY_ENTRY_U32("touchscreen-min-x", 4),
 	PROPERTY_ENTRY_U32("touchscreen-min-y", 6),
@@ -546,6 +565,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "X1D3_C806N"),
 		},
 	},
+	{
+		/* Chuwi Hi10 Air */
+		.driver_data = (void *)&chuwi_hi10_air_data,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
+			DMI_MATCH(DMI_PRODUCT_SKU, "P1W6_C109D_B"),
+		},
+	},
 	{
 		/* Chuwi Vi8 (CWI506) */
 		.driver_data = (void *)&chuwi_vi8_data,
Signature · 1 line
2.20.1
#3 lore raw

Hi Christian,

Quoted 7 lines · Christian Oder

Add touchscreen info for the CHUWUI Hi10 Air tablet.

---
Changes in v2:
- added review tag

A quick note for any patches you may submit in the future, there is no need to send a v2 just to add someones Reviewed-by or Acked-by, these will be picked up automatically by the subsys-maintainer when they add the patch to their tree.

Regards,

Hans

Quoted 50 lines
  drivers/platform/x86/touchscreen_dmi.c | 27 ++++++++++++++++++++++++++
  1 file changed, 27 insertions(+)
drivers/platform/x86/touchscreen_dmi.c +27 -0
index 167a156e3cc7..2d56ff7c8230 100644
@@ -72,6 +72,25 @@ static const struct ts_dmi_data chuwi_hi8_pro_data = {
  	.properties	= chuwi_hi8_pro_props,
  };
 
+static const struct property_entry chuwi_hi10_air_props[] = {
+	PROPERTY_ENTRY_U32("touchscreen-size-x", 1981),
+	PROPERTY_ENTRY_U32("touchscreen-size-y", 1271),
+	PROPERTY_ENTRY_U32("touchscreen-min-x", 99),
+	PROPERTY_ENTRY_U32("touchscreen-min-y", 9),
+	PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+	PROPERTY_ENTRY_U32("touchscreen-fuzz-x", 5),
+	PROPERTY_ENTRY_U32("touchscreen-fuzz-y", 4),
+	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-chuwi-hi10-air.fw"),
+	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+	PROPERTY_ENTRY_BOOL("silead,home-button"),
+	{ }
+};
+
+static const struct ts_dmi_data chuwi_hi10_air_data = {
+	.acpi_name	= "MSSL1680:00",
+	.properties	= chuwi_hi10_air_props,
+};
+
  static const struct property_entry chuwi_vi8_props[] = {
  	PROPERTY_ENTRY_U32("touchscreen-min-x", 4),
  	PROPERTY_ENTRY_U32("touchscreen-min-y", 6),
@@ -546,6 +565,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
  			DMI_MATCH(DMI_PRODUCT_NAME, "X1D3_C806N"),
  		},
  	},
+	{
+		/* Chuwi Hi10 Air */
+		.driver_data = (void *)&chuwi_hi10_air_data,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
+			DMI_MATCH(DMI_PRODUCT_SKU, "P1W6_C109D_B"),
+		},
+	},
  	{
  		/* Chuwi Vi8 (CWI506) */
  		.driver_data = (void *)&chuwi_vi8_data,
#4 lore raw
Quoted 8 lines · Hans de Goede

Hi Christian,

Quoted 4 lines · Christian Oder

Add touchscreen info for the CHUWUI Hi10 Air tablet.

Pushed to my review and testing queue, thanks!

Quoted 63 lines
Quoted 3 lines

---
Changes in v2:
- added review tag

A quick note for any patches you may submit in the future, there is no need to send a v2 just to add someones Reviewed-by or Acked-by, these will be picked up automatically by the subsys-maintainer when they add the patch to their tree.

Regards,

Hans

Quoted 50 lines
  drivers/platform/x86/touchscreen_dmi.c | 27 ++++++++++++++++++++++++++
  1 file changed, 27 insertions(+)
drivers/platform/x86/touchscreen_dmi.c +27 -0
index 167a156e3cc7..2d56ff7c8230 100644
@@ -72,6 +72,25 @@ static const struct ts_dmi_data chuwi_hi8_pro_data = {
      .properties     = chuwi_hi8_pro_props,
  };
 
+static const struct property_entry chuwi_hi10_air_props[] = {
+     PROPERTY_ENTRY_U32("touchscreen-size-x", 1981),
+     PROPERTY_ENTRY_U32("touchscreen-size-y", 1271),
+     PROPERTY_ENTRY_U32("touchscreen-min-x", 99),
+     PROPERTY_ENTRY_U32("touchscreen-min-y", 9),
+     PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+     PROPERTY_ENTRY_U32("touchscreen-fuzz-x", 5),
+     PROPERTY_ENTRY_U32("touchscreen-fuzz-y", 4),
+     PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-chuwi-hi10-air.fw"),
+     PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+     PROPERTY_ENTRY_BOOL("silead,home-button"),
+     { }
+};
+
+static const struct ts_dmi_data chuwi_hi10_air_data = {
+     .acpi_name      = "MSSL1680:00",
+     .properties     = chuwi_hi10_air_props,
+};
+
  static const struct property_entry chuwi_vi8_props[] = {
      PROPERTY_ENTRY_U32("touchscreen-min-x", 4),
      PROPERTY_ENTRY_U32("touchscreen-min-y", 6),
@@ -546,6 +565,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
                      DMI_MATCH(DMI_PRODUCT_NAME, "X1D3_C806N"),
              },
      },
+     {
+             /* Chuwi Hi10 Air */
+             .driver_data = (void *)&chuwi_hi10_air_data,
+             .matches = {
+                     DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
+                     DMI_MATCH(DMI_PRODUCT_SKU, "P1W6_C109D_B"),
+             },
+     },
      {
              /* Chuwi Vi8 (CWI506) */
              .driver_data = (void *)&chuwi_vi8_data,
Signature · 2 lines
With Best Regards,
Andy Shevchenko