Skip to contentSkip to conversation

ARM: dts: alt: Add DA9063 PMIC node

PATCH In review [email protected] 4 participants 9 messages Mar 3, 2019 – Mar 8, 2019 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: alt: Add DA9063 PMIC node

From: Marek Vasut <[email protected]>

Add DA9063 PMIC node to the I2C bus.

Cc Geert Uytterhoeven <[email protected]>
Cc Simon Horman <[email protected]>

To: [email protected]
---
NOTE: R8A7794 Alt does not share the PMIC IRQ line with other PMICs,
hence the regulator-quirk-rcar-gen2.c does not need a new entry.

---
 arch/arm/boot/dts/r8a7794-alt.dts | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
arch/arm/boot/dts/r8a7794-alt.dts +21 -0
index ef7e2a837df6..e0500ec81569 100644
@@ -377,6 +377,27 @@
 	pinctrl-names = "i2c-exio4";
 };
 
+&i2c7 {
+	status = "okay";
+	clock-frequency = <100000>;
+
+	pmic@58 {
+		compatible = "dlg,da9063";
+		reg = <0x58>;
+		interrupt-parent = <&gpio3>;
+		interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-controller;
+
+		rtc {
+			compatible = "dlg,da9063-rtc";
+		};
+
+		wdt {
+			compatible = "dlg,da9063-watchdog";
+		};
+	};
+};
+
 &vin0 {
 	status = "okay";
 	pinctrl-0 = <&vin0_pins>;
Signature · 1 line
2.19.2
Reviewed-by on v1 1/1
#1 lore raw

Hi Marek,

Quoted 5 lines · On Sun, Mar 3, 2019 at 8:01 PM <[email protected]> wrote:

From: Marek Vasut <[email protected]>

Add DA9063 PMIC node to the I2C bus.

Thanks for your patch!

arch/arm/boot/dts/r8a7794-alt.dts line 382

Quoted 9 lines
arch/arm/boot/dts/r8a7794-alt.dts +3 -0
@@ -377,6 +377,27 @@
        pinctrl-names = "i2c-exio4";
 };
 
+&i2c7 {
+       status = "okay";
+       clock-frequency = <100000>;

According to the DA9063 datasheet, the PMIC supports up to 400 kHz. It looks like there are no other devices on the bus.

Wolfram, what's your stance on this?

Quoted 8 lines
arch/arm/boot/dts/r8a7794-alt.dts +8 -0
+
+       pmic@58 {
+               compatible = "dlg,da9063";
+               reg = <0x58>;
+               interrupt-parent = <&gpio3>;
+               interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
+               interrupt-controller;
+

arch/arm/boot/dts/r8a7794-alt.dts line 400

Quoted 10 lines
arch/arm/boot/dts/r8a7794-alt.dts +10 -0
+               rtc {
+                       compatible = "dlg,da9063-rtc";
+               };
+
+               wdt {
+                       compatible = "dlg,da9063-watchdog";
+               };
+       };
+};
+

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#2 lore raw
Quoted 8 lines
Quoted 4 lines

Add DA9063 PMIC node to the I2C bus.

Thanks for your patch!

Thanks for CCing me, I didn't get and missed the original patch.

Quoted 5 lines
Quoted 5 lines

+++ b/arch/arm/boot/dts/r8a7794-alt.dts

arch/arm/boot/dts/r8a7794-alt.dts +0 -0
@@ -377,6 +377,27 @@
        pinctrl-names = "i2c-exio4";
 };
 
Quoted 8 lines

arch/arm/boot/dts/r8a7794-alt.dts line 382

Quoted 3 lines
arch/arm/boot/dts/r8a7794-alt.dts +3 -0
+&i2c7 {
+       status = "okay";
+       clock-frequency = <100000>;

According to the DA9063 datasheet, the PMIC supports up to 400 kHz. It looks like there are no other devices on the bus.

Wolfram, what's your stance on this?

Yes, please. I thought this was standard on Gen2 IIC_DVFS busses, but seems not. Probably it slipped through the cracks.

#3 lore raw
Quoted 23 lines · Wolfram Sang
Quoted 8 lines
Quoted 4 lines

Add DA9063 PMIC node to the I2C bus.

Thanks for your patch!

Thanks for CCing me, I didn't get and missed the original patch.

Quoted 12 lines

arch/arm/boot/dts/r8a7794-alt.dts line 382

Quoted 8 lines

+++ b/arch/arm/boot/dts/r8a7794-alt.dts

arch/arm/boot/dts/r8a7794-alt.dts +3 -0
@@ -377,6 +377,27 @@
        pinctrl-names = "i2c-exio4";
 };
 
+&i2c7 {
+       status = "okay";
+       clock-frequency = <100000>;

According to the DA9063 datasheet, the PMIC supports up to 400 kHz. It looks like there are no other devices on the bus.

Quoted 4 lines
Quoted 1 line

Wolfram, what's your stance on this?

Yes, please. I thought this was standard on Gen2 IIC_DVFS busses, but seems not. Probably it slipped through the cracks.

Do we want to update all of the other boards too ?

I'd be cautious about the DVFS I2C, running faster while talking to the PMIC and reading/writing a few registers brings little benefit, while the signal integrity might be impacted.

Signature · 2 lines
Best regards,
Marek Vasut
#4 lore raw
Quoted 26 lines · Marek Vasut
Quoted 25 lines · Wolfram Sang
Quoted 8 lines
Quoted 4 lines

Add DA9063 PMIC node to the I2C bus.

Thanks for your patch!

Thanks for CCing me, I didn't get and missed the original patch.

Quoted 13 lines

arch/arm/boot/dts/r8a7794-alt.dts line 382

Quoted 8 lines

+++ b/arch/arm/boot/dts/r8a7794-alt.dts

arch/arm/boot/dts/r8a7794-alt.dts +3 -0
@@ -377,6 +377,27 @@
        pinctrl-names = "i2c-exio4";
 };
 
+&i2c7 {
+       status = "okay";
+       clock-frequency = <100000>;

According to the DA9063 datasheet, the PMIC supports up to 400 kHz. It looks like there are no other devices on the bus.

Wolfram, what's your stance on this?

Quoted 8 lines
Quoted 2 lines

Yes, please. I thought this was standard on Gen2 IIC_DVFS busses, but seems not. Probably it slipped through the cracks.

Do we want to update all of the other boards too ?

I'd be cautious about the DVFS I2C, running faster while talking to the PMIC and reading/writing a few registers brings little benefit, while the signal integrity might be impacted.

Can be argued. I think if we would apply some testing on top of this change, we will find that it will work. But we would in deed need this testing as verification, and this is not our top priority project. But if someone feels like running some i2c dumping over night, well, why not..

#5 lore raw
Quoted 36 lines · Wolfram Sang
Quoted 26 lines · Marek Vasut
Quoted 25 lines · Wolfram Sang
Quoted 8 lines
Quoted 4 lines

Add DA9063 PMIC node to the I2C bus.

Thanks for your patch!

Thanks for CCing me, I didn't get and missed the original patch.

Quoted 13 lines

arch/arm/boot/dts/r8a7794-alt.dts line 382

Quoted 8 lines

+++ b/arch/arm/boot/dts/r8a7794-alt.dts

arch/arm/boot/dts/r8a7794-alt.dts +3 -0
@@ -377,6 +377,27 @@
        pinctrl-names = "i2c-exio4";
 };
 
+&i2c7 {
+       status = "okay";
+       clock-frequency = <100000>;

According to the DA9063 datasheet, the PMIC supports up to 400 kHz. It looks like there are no other devices on the bus.

Wolfram, what's your stance on this?

Quoted 8 lines
Quoted 2 lines

Yes, please. I thought this was standard on Gen2 IIC_DVFS busses, but seems not. Probably it slipped through the cracks.

Do we want to update all of the other boards too ?

I'd be cautious about the DVFS I2C, running faster while talking to the PMIC and reading/writing a few registers brings little benefit, while the signal integrity might be impacted.

Quoted 5 lines

Can be argued. I think if we would apply some testing on top of this change, we will find that it will work. But we would in deed need this testing as verification, and this is not our top priority project. But if someone feels like running some i2c dumping over night, well, why not..

Thanks,

I've applied this patch for v5.2.
We can do a sweep of frequency updates as a follow-up if we decide that is the right way to go.

#6 lore raw
Quoted 43 lines · Simon Horman
Quoted 36 lines · Wolfram Sang
Quoted 26 lines · Marek Vasut
Quoted 25 lines · Wolfram Sang
Quoted 8 lines
Quoted 4 lines

Add DA9063 PMIC node to the I2C bus.

Thanks for your patch!

Thanks for CCing me, I didn't get and missed the original patch.

Quoted 13 lines

arch/arm/boot/dts/r8a7794-alt.dts line 382

Quoted 8 lines

+++ b/arch/arm/boot/dts/r8a7794-alt.dts

arch/arm/boot/dts/r8a7794-alt.dts +3 -0
@@ -377,6 +377,27 @@
        pinctrl-names = "i2c-exio4";
 };
 
+&i2c7 {
+       status = "okay";
+       clock-frequency = <100000>;

According to the DA9063 datasheet, the PMIC supports up to 400 kHz. It looks like there are no other devices on the bus.

Wolfram, what's your stance on this?

Quoted 8 lines
Quoted 2 lines

Yes, please. I thought this was standard on Gen2 IIC_DVFS busses, but seems not. Probably it slipped through the cracks.

Do we want to update all of the other boards too ?

I'd be cautious about the DVFS I2C, running faster while talking to the PMIC and reading/writing a few registers brings little benefit, while the signal integrity might be impacted.

Quoted 5 lines

Can be argued. I think if we would apply some testing on top of this change, we will find that it will work. But we would in deed need this testing as verification, and this is not our top priority project. But if someone feels like running some i2c dumping over night, well, why not..

Quoted 5 lines

Thanks,

I've applied this patch for v5.2.
We can do a sweep of frequency updates as a follow-up if we decide that is the right way to go.

Do we really want to speed up the PMIC I2C bus ? What are the pros (none?) and cons (might be unstable) ?

Signature · 2 lines
Best regards,
Marek Vasut
#7 lore raw
Quoted 3 lines

Do we really want to speed up the PMIC I2C bus ? What are the pros (none?) and cons (might be unstable) ?

Then let's go down to 10kHz instead? Even more stable.

#8 lore raw
Quoted 5 lines · Wolfram Sang
Quoted 3 lines

Do we really want to speed up the PMIC I2C bus ? What are the pros (none?) and cons (might be unstable) ?

Then let's go down to 10kHz instead? Even more stable.

100 kHz and 400 kHz seem to be the most often used I2C frequencies, maybe we should stick to those, since I presume Dialog tested the PMIC with at least those two.

Signature · 2 lines
Best regards,
Marek Vasut