ARM: actions: fix a leaked reference by addingmissing of_node_put

PATCH Applied Wen Yang 12 participants 32 messages Mar 1, 2019 – Mar 6, 2019

Subsystems (18)

Arm (32-bit) Arm sub-architectures Arm i.MX and Layerscape Arm Samsung Exynos +14 more subsystems

lore

Share & tools

lore

Wen Yang

author

2019-03-01 08:56 UTC #0 lore raw

PATCH 1/15 ARM: actions: fix a leaked reference by addingmissing of_node_put

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-actions/platsmp.c:112:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 103, but without a corresponding object release within this function. ./arch/arm/mach-actions/platsmp.c:124:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 115, but without a corresponding object release within this function. ./arch/arm/mach-actions/platsmp.c:137:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 128, but without a corresponding object release within this function.

Signed-off-by Wen Yang <[email protected]>

Cc "Andreas Färber" <[email protected]>

Cc Manivannan Sadhasivam <[email protected]>

Cc Russell King <[email protected]>

Cc [email protected]

---
 arch/arm/mach-actions/platsmp.c | 3 +++
 1 file changed, 3 insertions(+)

arch/arm/mach-actions/platsmp.c +3 -0

index 4fd479c..1a8e078 100644
@@ -107,6 +107,7 @@ static void __init s500_smp_prepare_cpus(unsigned int max_cpus)
 	}
 
 	timer_base_addr = of_iomap(node, 0);
+	of_node_put(node);
 	if (!timer_base_addr) {
 		pr_err("%s: could not map timer registers\n", __func__);
 		return;

@@ -119,6 +120,7 @@ static void __init s500_smp_prepare_cpus(unsigned int max_cpus)
 	}
 
 	sps_base_addr = of_iomap(node, 0);
+	of_node_put(node);
 	if (!sps_base_addr) {
 		pr_err("%s: could not map sps registers\n", __func__);
 		return;

@@ -132,6 +134,7 @@ static void __init s500_smp_prepare_cpus(unsigned int max_cpus)
 		}
 
 		scu_base_addr = of_iomap(node, 0);
+		of_node_put(node);
 		if (!scu_base_addr) {
 			pr_err("%s: could not map scu registers\n", __func__);
 			return;

Signature · 1 line

2.9.5

Wen Yang

author

2019-03-01 08:56 UTC #1 lore raw

PATCH 2/15 ARM: bcm: fix a leaked reference by addingmissing of_node_put

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-bcm/board_bcm281xx.c:43:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 35, but without a corresponding object release within this function.

Signed-off-by Wen Yang <[email protected]>

Cc Florian Fainelli <[email protected]>

Cc Ray Jui <[email protected]>

Cc Scott Branden <[email protected]>

Cc [email protected]

Cc Russell King <[email protected]>

Cc [email protected]

---
 arch/arm/mach-bcm/board_bcm281xx.c | 1 +
 1 file changed, 1 insertion(+)

arch/arm/mach-bcm/board_bcm281xx.c +1 -0

index b81bb38..1238ac8 100644
@@ -38,6 +38,7 @@ static void bcm281xx_restart(enum reboot_mode mode, const char *cmd)
 		return;
 	}
 	base = of_iomap(np_wdog, 0);
+	of_node_put(np_wdog);
 	if (!base) {
 		pr_emerg("Couldn't map brcm,kona-wdt\n");
 		return;

Signature · 1 line

2.9.5

Florian Fainelli

Reviewed-by on v1 2/15

2019-03-01 18:28 UTC #2 lore raw

Re: [PATCH 02/15] ARM: bcm: fix a leaked reference by addingmissing of_node_put

Quoted 6 lines · Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.
Detected by coccinelle with the following warnings:
./arch/arm/mach-bcm/board_bcm281xx.c:43:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 35, but without a corresponding object release within this function.

This looks fine, if you resubmit, can you add a missing space between "adding" and "missing"? This applies to all of your patches, so I am assuming you somehow scripted that, which should be easy to fix.

With that changed:

Reviewed-by Florian Fainelli <[email protected]>

Signature · 1 line

Florian

Wen Yang

author

2019-03-01 08:56 UTC #3 lore raw

PATCH 3/15 ARM: exynos: fix a leaked reference by addingmissing of_node_put

In reply to Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-exynos/firmware.c:201:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 193, but without a corresponding object release within this function. ./arch/arm/mach-exynos/firmware.c:204:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 193, but without a corresponding object release within this function. ./arch/arm/mach-exynos/suspend.c:642:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 634, but without a corresponding object release within this function.

Signed-off-by Wen Yang <[email protected]>

Cc Russell King <[email protected]>

Cc Kukjin Kim <[email protected]>

Cc Krzysztof Kozlowski <[email protected]>

Cc [email protected]

---
 arch/arm/mach-exynos/firmware.c | 1 +
 arch/arm/mach-exynos/suspend.c  | 2 ++
 2 files changed, 3 insertions(+)

arch/arm/mach-exynos/firmware.c +1 -0

index d602e3b..2eaf2db 100644
@@ -196,6 +196,7 @@ bool __init exynos_secure_firmware_available(void)
 		return false;
 
 	addr = of_get_address(nd, 0, NULL, NULL);
+	of_node_put(nd);
 	if (!addr) {
 		pr_err("%s: No address specified.\n", __func__);
 		return false;

arch/arm/mach-exynos/suspend.c +2 -0

index 0850505..9afb0c6 100644
@@ -639,8 +639,10 @@ void __init exynos_pm_init(void)
 
 	if (WARN_ON(!of_find_property(np, "interrupt-controller", NULL))) {
 		pr_warn("Outdated DT detected, suspend/resume will NOT work\n");
+		of_node_put(np);
 		return;
 	}
+	of_node_put(np);
 
 	pm_data = (const struct exynos_pm_data *) match->data;

Signature · 1 line

2.9.5

Krzysztof Kozlowski

maintainer

2019-03-01 09:14 UTC #4 lore raw

Re: [PATCH 03/15] ARM: exynos: fix a leaked reference by addingmissing of_node_put

Quoted 9 lines · Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.
Detected by coccinelle with the following warnings:
./arch/arm/mach-exynos/firmware.c:201:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 193, but without a corresponding object release within this function. ./arch/arm/mach-exynos/firmware.c:204:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 193, but without a corresponding object release within this function. ./arch/arm/mach-exynos/suspend.c:642:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 634, but without a corresponding object release within this function.

Thanks, looks good. I'll take it however after merge window.

There are no dependencies between patches therefore you could limit the amount of people you CC. You put specific "Cc" fields in patch but you did not use them and sent it to 40 addresses. The CC in the patch has exactly this purpose - do not send everything to everyone...

Best regards,
Krzysztof

Wen Yang

author

2019-03-01 08:56 UTC #5 lore raw

PATCH 4/15 ARM: hisi: fix a leaked reference by addingmissing of_node_put

In reply to Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-hisi/platsmp.c:74:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. ./arch/arm/mach-hisi/platsmp.c:78:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. ./arch/arm/mach-hisi/platmcpm.c:337:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 275, but without a corresponding object release within this function. ./arch/arm/mach-hisi/platmcpm.c:347:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 275, but without a corresponding object release within this function. ./arch/arm/mach-hisi/platmcpm.c:337:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 284, but without a corresponding object release within this function. ./arch/arm/mach-hisi/platmcpm.c:347:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 284, but without a corresponding object release within this function. ./arch/arm/mach-hisi/platmcpm.c:337:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 287, but without a corresponding object release within this function. ./arch/arm/mach-hisi/platmcpm.c:347:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 287, but without a corresponding object release within this function.

Signed-off-by Wen Yang <[email protected]>

Cc Wei Xu <[email protected]>

Cc Russell King <[email protected]>

Cc [email protected]

---
 arch/arm/mach-hisi/platmcpm.c | 12 ++++++++++--
 arch/arm/mach-hisi/platsmp.c  |  7 +++++--
 2 files changed, 15 insertions(+), 4 deletions(-)

arch/arm/mach-hisi/platmcpm.c +10 -2

index f66815c..695423c 100644
@@ -277,6 +277,7 @@ static int __init hip04_smp_init(void)
 		goto err;
 	ret = of_property_read_u32_array(np, "boot-method",
 					 &hip04_boot_method[0], 4);
+	of_node_put(np);
 	if (ret)
 		goto err;

@@ -285,12 +286,14 @@ static int __init hip04_smp_init(void)
 	if (!np_sctl)
 		goto err;
 	np_fab = of_find_compatible_node(NULL, NULL, "hisilicon,hip04-fabric");
-	if (!np_fab)
+	if (!np_fab) {
+		of_node_put(np_sctl);
 		goto err;
+	}
 
 	ret = memblock_reserve(hip04_boot_method[0], hip04_boot_method[1]);
 	if (ret)
-		goto err;
+		goto err_put_node;
 
 	relocation = ioremap(hip04_boot_method[2], hip04_boot_method[3]);
 	if (!relocation) {

@@ -334,6 +337,8 @@ static int __init hip04_smp_init(void)
 	iounmap(relocation);
 
 	smp_set_ops(&hip04_smp_ops);
+	of_node_put(np_fab);
+	of_node_put(np_sctl);
 	return ret;
 err_table:
 	iounmap(fabric);

@@ -343,6 +348,9 @@ static int __init hip04_smp_init(void)
 	iounmap(relocation);
 err_reloc:
 	memblock_free(hip04_boot_method[0], hip04_boot_method[1]);
+err_put_node:
+	of_node_put(np_fab);
+	of_node_put(np_sctl);
 err:
 	return ret;
 }

arch/arm/mach-hisi/platsmp.c +5 -2

index da5689a..ecc68fa 100644
@@ -71,14 +71,17 @@ static void __init hi3xxx_smp_prepare_cpus(unsigned int max_cpus)
 		ctrl_base = of_iomap(np, 0);
 		if (!ctrl_base) {
 			pr_err("failed to map address\n");
-			return;
+			goto out_put_node;
 		}
 		if (of_property_read_u32(np, "smp-offset", &offset) < 0) {
 			pr_err("failed to find smp-offset property\n");
-			return;
+			goto out_put_node;
 		}
 		ctrl_base += offset;
 	}
+
+out_put_node:
+	of_node_put(np);
 }
 
 static int hi3xxx_boot_secondary(unsigned int cpu, struct task_struct *idle)

Signature · 1 line

2.9.5

Wen Yang

author

2019-03-01 08:56 UTC #6 lore raw

PATCH 5/15 ARM: imx51: fix a leaked reference by addingmissing of_node_put

In reply to Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-imx/mach-imx51.c:64:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 57, but without a corresponding object release within this function.

Signed-off-by Wen Yang <[email protected]>

Cc Russell King <[email protected]>

Cc Shawn Guo <[email protected]>

Cc Sascha Hauer <[email protected]>

Cc Pengutronix Kernel Team <[email protected]>

Cc Fabio Estevam <[email protected]>

Cc NXP Linux Team <[email protected]>

Cc Lucas Stach <[email protected]>

Cc [email protected]

---
 arch/arm/mach-imx/mach-imx51.c | 1 +
 1 file changed, 1 insertion(+)

arch/arm/mach-imx/mach-imx51.c +1 -0

index c7169c2..08c7892 100644
@@ -59,6 +59,7 @@ static void __init imx51_m4if_setup(void)
 		return;
 
 	m4if_base = of_iomap(np, 0);
+	of_node_put(np);
 	if (!m4if_base) {
 		pr_err("Unable to map M4IF registers\n");
 		return;

Signature · 1 line

2.9.5

Shawn Guo

Applied

2019-03-04 05:37 UTC #7 lore raw

Re: [PATCH 05/15] ARM: imx51: fix a leaked reference by addingmissing of_node_put

Quoted 8 lines · Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.
Detected by coccinelle with the following warnings:
./arch/arm/mach-imx/mach-imx51.c:64:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 57, but without a corresponding object release within this function.
Signed-off-by Wen Yang <[email protected]>

Applied, thanks.

Wen Yang

author

2019-03-01 08:56 UTC #8 lore raw

PATCH 6/15 arm: npcm: fix a leaked reference by addingmissing of_node_put

In reply to Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-npcm/platsmp.c:52:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 31, but without a corresponding object release within this function. ./arch/arm/mach-npcm/platsmp.c:68:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 60, but without a corresponding object release within this function.

Signed-off-by Wen Yang <[email protected]>

Cc Avi Fishman <[email protected]>

Cc Tomer Maimon <[email protected]>

Cc Patrick Venture <[email protected]>

Cc Nancy Yuen <[email protected]>

Cc Brendan Higgins <[email protected]>

Cc Russell King <[email protected]>

Cc [email protected]

---
 arch/arm/mach-npcm/platsmp.c | 2 ++
 1 file changed, 2 insertions(+)

arch/arm/mach-npcm/platsmp.c +2 -0

index 21633c7..fe63edc 100644
@@ -35,6 +35,7 @@ static int npcm7xx_smp_boot_secondary(unsigned int cpu,
 		goto out;
 	}
 	gcr_base = of_iomap(gcr_np, 0);
+	of_node_put(gcr_np);
 	if (!gcr_base) {
 		pr_err("could not iomap gcr");
 		ret = -ENOMEM;

@@ -63,6 +64,7 @@ static void __init npcm7xx_smp_prepare_cpus(unsigned int max_cpus)
 		return;
 	}
 	scu_base = of_iomap(scu_np, 0);
+	of_node_put(scu_np);
 	if (!scu_base) {
 		pr_err("could not iomap scu");
 		return;

Signature · 1 line

2.9.5

Avi Fishman

maintainer Reviewed-by on v1 6/15

2019-03-04 15:39 UTC #9 lore raw

Re: [PATCH 06/15] arm: npcm: fix a leaked reference by addingmissing of_node_put

Reviewed-by Avi Fishman <[email protected]>

Thanks

Quoted 46 lines · Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.
Detected by coccinelle with the following warnings:
./arch/arm/mach-npcm/platsmp.c:52:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 31, but without a corresponding object release within this function. ./arch/arm/mach-npcm/platsmp.c:68:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 60, but without a corresponding object release within this function.
Signed-off-by Wen Yang <[email protected]>
Cc Avi Fishman <[email protected]>
Cc Tomer Maimon <[email protected]>
Cc Patrick Venture <[email protected]>
Cc Nancy Yuen <[email protected]>
Cc Brendan Higgins <[email protected]>
Cc Russell King <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
---
 arch/arm/mach-npcm/platsmp.c | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-npcm/platsmp.c +2 -1
index 21633c7..fe63edc 100644
@@ -35,6 +35,7 @@ static int npcm7xx_smp_boot_secondary(unsigned int cpu,
                goto out;
        }
        gcr_base = of_iomap(gcr_np, 0);
+       of_node_put(gcr_np);
        if (!gcr_base) {
                pr_err("could not iomap gcr");
                ret = -ENOMEM;
@@ -63,6 +64,7 @@ static void __init npcm7xx_smp_prepare_cpus(unsigned int max_cpus)
                return;
        }
        scu_base = of_iomap(scu_np, 0);
+       of_node_put(scu_np);
        if (!scu_base) {
                pr_err("could not iomap scu");
                return;
--
2.9.5

Signature · 2 lines

Regards,
Avi

Wen Yang

author

2019-03-01 08:56 UTC #10 lore raw

PATCH 7/15 ARM: rockchip: fix a leaked reference by addingmissing of_node_put

In reply to Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-rockchip/pm.c:269:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 259, but without a corresponding object release within this function. ./arch/arm/mach-rockchip/pm.c:275:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 259, but without a corresponding object release within this function ./arch/arm/mach-rockchip/platsmp.c:280:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 271, but without a corresponding object release within this function. ./arch/arm/mach-rockchip/platsmp.c:284:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 271, but without a corresponding object release within this function. ./arch/arm/mach-rockchip/platsmp.c:288:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 271, but without a corresponding object release within this function. ./arch/arm/mach-rockchip/platsmp.c:302:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 293, but without a corresponding object release within this function. ./arch/arm/mach-rockchip/platsmp.c:250:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 241, but without a corresponding object release within this function. ./arch/arm/mach-rockchip/platsmp.c:260:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 241, but without a corresponding object release within this function. ./arch/arm/mach-rockchip/platsmp.c:263:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 241, but without a corresponding object release within this function.

Signed-off-by Wen Yang <[email protected]>

Cc Russell King <[email protected]>

Cc Heiko Stuebner <[email protected]>

Cc [email protected]

---
 arch/arm/mach-rockchip/platsmp.c | 12 ++++++++----
 arch/arm/mach-rockchip/pm.c      | 11 ++++++-----
 2 files changed, 14 insertions(+), 9 deletions(-)

arch/arm/mach-rockchip/platsmp.c +8 -4

index 51984a4..f93d64e 100644
@@ -277,19 +277,20 @@ static void __init rockchip_smp_prepare_cpus(unsigned int max_cpus)
 	sram_base_addr = of_iomap(node, 0);
 	if (!sram_base_addr) {
 		pr_err("%s: could not map sram registers\n", __func__);
-		return;
+		goto out_put_node;
 	}
 
 	if (has_pmu && rockchip_smp_prepare_pmu())
-		return;
+		goto out_put_node;
 
 	if (read_cpuid_part() == ARM_CPU_PART_CORTEX_A9) {
 		if (rockchip_smp_prepare_sram(node))
-			return;
+			goto out_put_node;
 
 		/* enable the SCU power domain */
 		pmu_set_power_domain(PMU_PWRDN_SCU, true);
 
+		of_node_put(node);
 		node = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-scu");
 		if (!node) {
 			pr_err("%s: missing scu\n", __func__);

@@ -299,7 +300,7 @@ static void __init rockchip_smp_prepare_cpus(unsigned int max_cpus)
 		scu_base_addr = of_iomap(node, 0);
 		if (!scu_base_addr) {
 			pr_err("%s: could not map scu registers\n", __func__);
-			return;
+			goto out_put_node;
 		}
 
 		/*

@@ -321,6 +322,9 @@ static void __init rockchip_smp_prepare_cpus(unsigned int max_cpus)
 	/* Make sure that all cores except the first are really off */
 	for (i = 1; i < ncores; i++)
 		pmu_set_power_domain(0 + i, false);
+
+out_put_node:
+	of_node_put(node);
 }
 
 static void __init rk3036_smp_prepare_cpus(unsigned int max_cpus)

arch/arm/mach-rockchip/pm.c +6 -5

index 0592534..43a16c9 100644
@@ -266,25 +266,26 @@ static int rk3288_suspend_init(struct device_node *np)
 	rk3288_bootram_base = of_iomap(sram_np, 0);
 	if (!rk3288_bootram_base) {
 		pr_err("%s: could not map bootram base\n", __func__);
-		return -ENOMEM;
+		ret = -ENOMEM;
+		goto out_put_node;
 	}
 
 	ret = of_address_to_resource(sram_np, 0, &res);
 	if (ret) {
 		pr_err("%s: could not get bootram phy addr\n", __func__);
-		return ret;
+		goto out_put_node;
 	}
 	rk3288_bootram_phy = res.start;
 
-	of_node_put(sram_np);
-
 	rk3288_config_bootdata();
 
 	/* copy resume code and data to bootsram */
 	memcpy(rk3288_bootram_base, rockchip_slp_cpu_resume,
 	       rk3288_bootram_sz);
 
-	return 0;
+out_put_node:
+	of_node_put(sram_np);
+	return ret;
 }
 
 static const struct platform_suspend_ops rk3288_suspend_ops = {

Signature · 1 line

2.9.5

Wen Yang

author

2019-03-01 08:56 UTC #11 lore raw

PATCH 8/15 ARM: shmobile: fix a leaked reference by addingmissing of_node_put

In reply to Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-shmobile/pm-rcar-gen2.c:77:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. ./arch/arm/mach-shmobile/pm-rcar-gen2.c:85:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. ./arch/arm/mach-shmobile/pm-rcar-gen2.c:90:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function.

Signed-off-by Wen Yang <[email protected]>

Cc Simon Horman <[email protected]>

Cc Magnus Damm <[email protected]>

Cc Russell King <[email protected]>

Cc [email protected]

---
 arch/arm/mach-shmobile/pm-rcar-gen2.c | 1 +
 1 file changed, 1 insertion(+)

arch/arm/mach-shmobile/pm-rcar-gen2.c +1 -0

index 8c2a205..e84599d 100644
@@ -72,6 +72,7 @@ void __init rcar_gen2_pm_init(void)
 	}
 
 	error = of_address_to_resource(np, 0, &res);
+	of_node_put(np);
 	if (error) {
 		pr_err("Failed to get smp-sram address: %d\n", error);
 		return;

Signature · 1 line

2.9.5

Geert Uytterhoeven

Reviewed-by on v1 8/15

2019-03-01 09:51 UTC #12 lore raw

Re: [PATCH 08/15] ARM: shmobile: fix a leaked reference by addingmissing of_node_put

Quoted 10 lines · Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.
Detected by coccinelle with the following warnings:
./arch/arm/mach-shmobile/pm-rcar-gen2.c:77:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. ./arch/arm/mach-shmobile/pm-rcar-gen2.c:85:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. ./arch/arm/mach-shmobile/pm-rcar-gen2.c:90:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function.
Signed-off-by Wen Yang <[email protected]>

Reviewed-by Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

Signature · 5 lines

Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Simon Horman

Applied

2019-03-04 10:24 UTC #13 lore raw

Re: [PATCH 08/15] ARM: shmobile: fix a leaked reference by addingmissing of_node_put

Quoted 5 lines · Geert Uytterhoeven

Quoted 4 lines · Wen Yang
The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.

Quoted 8 lines

Quoted 6 lines
Detected by coccinelle with the following warnings:
./arch/arm/mach-shmobile/pm-rcar-gen2.c:77:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. ./arch/arm/mach-shmobile/pm-rcar-gen2.c:85:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. ./arch/arm/mach-shmobile/pm-rcar-gen2.c:90:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function.
Signed-off-by Wen Yang <[email protected]>
Reviewed-by Geert Uytterhoeven <[email protected]>

Thanks, applied for v5.2.

Fabrizio Castro

2019-03-04 10:55 UTC #14 lore raw

RE: [PATCH 08/15] ARM: shmobile: fix a leaked reference by addingmissing of_node_put

Hello Simon,

Quoted 15 lines

From: [email protected] <[email protected]> On Behalf Of Simon Horman
Sent: 04 March 2019 10:24
Subject: Re: [PATCH 08/15] ARM: shmobile: fix a leaked reference by addingmissing of_node_put
Quoted 7 lines · Geert Uytterhoeven
Quoted 6 lines · Wen Yang
The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.
Detected by coccinelle with the following warnings:
./arch/arm/mach-shmobile/pm-rcar-gen2.c:77:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount
incremented on line 66, but without a corresponding object release within this function.
Quoted 1 line
Quoted 1 line
./arch/arm/mach-shmobile/pm-rcar-gen2.c:85:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount
incremented on line 66, but without a corresponding object release within this function.

Quoted 8 lines

Quoted 1 line
Quoted 1 line
./arch/arm/mach-shmobile/pm-rcar-gen2.c:90:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount
incremented on line 66, but without a corresponding object release within this function.
Quoted 4 lines
Quoted 2 lines
Signed-off-by Wen Yang <[email protected]>
Reviewed-by Geert Uytterhoeven <[email protected]>
Thanks, applied for v5.2.

I am sorry for commenting on this just a moment after you took the patch, I guess there is a space missing in the title s/addingmissing/adding missing/ ? Is that still fixable?

Thanks,
Fab

Simon Horman

2019-03-06 13:00 UTC #15 lore raw

Re: [PATCH 08/15] ARM: shmobile: fix a leaked reference by addingmissing of_node_put

Quoted 20 lines · Fabrizio Castro

Hello Simon,
Quoted 18 lines
From: [email protected] <[email protected]> On Behalf Of Simon Horman
Sent: 04 March 2019 10:24
Subject: Re: [PATCH 08/15] ARM: shmobile: fix a leaked reference by addingmissing of_node_put
Quoted 7 lines · Geert Uytterhoeven
Quoted 6 lines · Wen Yang
The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.
Detected by coccinelle with the following warnings:
./arch/arm/mach-shmobile/pm-rcar-gen2.c:77:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount
incremented on line 66, but without a corresponding object release within this function.
Quoted 1 line
Quoted 1 line
./arch/arm/mach-shmobile/pm-rcar-gen2.c:85:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount
incremented on line 66, but without a corresponding object release within this function.
Quoted 1 line
Quoted 1 line
./arch/arm/mach-shmobile/pm-rcar-gen2.c:90:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount
incremented on line 66, but without a corresponding object release within this function.
Quoted 1 line
Quoted 1 line

Quoted 7 lines

Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Wen Yang <[email protected]>
Reviewed-by Geert Uytterhoeven <[email protected]>
Thanks, applied for v5.2.
I am sorry for commenting on this just a moment after you took the patch, I guess there is a space missing in the title s/addingmissing/adding missing/ ? Is that still fixable?

Thanks for noticing, fixed.

Wen Yang

author

2019-03-01 08:56 UTC #16 lore raw

PATCH 9/15 ARM: socfpga: fix a leaked reference by addingmissing of_node_put

In reply to Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-socfpga/platsmp.c:93:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 85, but without a corresponding object release within this function.

Signed-off-by Wen Yang <[email protected]>

Cc Dinh Nguyen <[email protected]>

Cc Russell King <[email protected]>

Cc [email protected]

---
 arch/arm/mach-socfpga/platsmp.c | 1 +
 1 file changed, 1 insertion(+)

arch/arm/mach-socfpga/platsmp.c +1 -0

index 0ee7677..55c2884 100644
@@ -89,6 +89,7 @@ static void __init socfpga_smp_prepare_cpus(unsigned int max_cpus)
 	}
 
 	socfpga_scu_base_addr = of_iomap(np, 0);
+	of_node_put(np);
 	if (!socfpga_scu_base_addr)
 		return;
 	scu_enable(socfpga_scu_base_addr);

Signature · 1 line

2.9.5

Wen Yang

author

2019-03-01 08:56 UTC #17 lore raw

PATCH 10/15 ARM: sunxi: fix a leaked reference by addingmissing of_node_put

In reply to Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-sunxi/platsmp.c:55:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 46, but without a corresponding object release within this function. ./arch/arm/mach-sunxi/platsmp.c:138:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 129, but without a corresponding object release within this function.

Signed-off-by Wen Yang <[email protected]>

Cc Maxime Ripard <[email protected]>

Cc Chen-Yu Tsai <[email protected]>

Cc Russell King <[email protected]>

Cc [email protected]

---
 arch/arm/mach-sunxi/platsmp.c | 2 ++
 1 file changed, 2 insertions(+)

arch/arm/mach-sunxi/platsmp.c +2 -0

index 8fb5088..c842209 100644
@@ -50,6 +50,7 @@ static void __init sun6i_smp_prepare_cpus(unsigned int max_cpus)
 	}
 
 	prcm_membase = of_iomap(node, 0);
+	of_node_put(node);
 	if (!prcm_membase) {
 		pr_err("Couldn't map A31 PRCM registers\n");
 		return;

@@ -63,6 +64,7 @@ static void __init sun6i_smp_prepare_cpus(unsigned int max_cpus)
 	}
 
 	cpucfg_membase = of_iomap(node, 0);
+	of_node_put(node);
 	if (!cpucfg_membase)
 		pr_err("Couldn't map A31 CPU config registers\n");

Signature · 1 line

2.9.5

Wen Yang

author

2019-03-01 08:56 UTC #18 lore raw

PATCH 11/15 ARM: versatile: fix a leaked reference by addingmissing of_node_put

In reply to Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-versatile/versatile_dt.c:315:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 302, but without a corresponding object release within this function. ./arch/arm/mach-versatile/versatile_dt.c:320:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 302, but without a corresponding object release within this function.

Signed-off-by Wen Yang <[email protected]>

Cc Linus Walleij <[email protected]>

Cc Russell King <[email protected]>

Cc [email protected]

---
 arch/arm/mach-versatile/versatile_dt.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

arch/arm/mach-versatile/versatile_dt.c +5 -2

index e9d6068..028463a 100644
@@ -312,12 +312,12 @@ static void __init versatile_dt_pci_init(void)
 		 * driver had it so we will keep it.
 		 */
 		writel(1, versatile_sys_base + VERSATILE_SYS_PCICTL_OFFSET);
-		return;
+		goto out_put_node;
 	}
 
 	newprop = kzalloc(sizeof(*newprop), GFP_KERNEL);
 	if (!newprop)
-		return;
+		goto out_put_node;
 
 	newprop->name = kstrdup("status", GFP_KERNEL);
 	newprop->value = kstrdup("disabled", GFP_KERNEL);

@@ -325,6 +325,9 @@ static void __init versatile_dt_pci_init(void)
 	of_update_property(np, newprop);
 
 	pr_info("Not plugged into PCI backplane!\n");
+
+out_put_node:
+	of_node_put(np);
 }
 
 static void __init versatile_dt_init(void)

Signature · 1 line

2.9.5

Linus Walleij

2019-03-01 13:30 UTC #19 lore raw

Re: [PATCH 11/15] ARM: versatile: fix a leaked reference by addingmissing of_node_put

Quoted 8 lines · Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.
Detected by coccinelle with the following warnings:
./arch/arm/mach-versatile/versatile_dt.c:315:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 302, but without a corresponding object release within this function. ./arch/arm/mach-versatile/versatile_dt.c:320:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 302, but without a corresponding object release within this function.

Quoted 5 lines

Signed-off-by Wen Yang <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Russell King <[email protected]>
Cc [email protected]
Cc [email protected]

Patch applied. Will send upstream next kernel cycle or so.

Yours,
Linus Walleij

Wen Yang

author

2019-03-01 08:56 UTC #20 lore raw

PATCH 12/15 ARM: vexpress: fix a leaked reference by addingmissing of_node_put

In reply to Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-vexpress/dcscb.c:150:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function. ./arch/arm/mach-vexpress/dcscb.c:160:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function. ./arch/arm/mach-vexpress/dcscb.c:171:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function.

Signed-off-by Wen Yang <[email protected]>

Cc Liviu Dudau <[email protected]>

Cc Sudeep Holla <[email protected]>

Cc Lorenzo Pieralisi <[email protected]>

Cc Russell King <[email protected]>

Cc [email protected]

---
 arch/arm/mach-vexpress/dcscb.c | 1 +
 1 file changed, 1 insertion(+)

arch/arm/mach-vexpress/dcscb.c +1 -0

index ee2a0fa..aaade91 100644
@@ -146,6 +146,7 @@ static int __init dcscb_init(void)
 	if (!node)
 		return -ENODEV;
 	dcscb_base = of_iomap(node, 0);
+	of_node_put(node);
 	if (!dcscb_base)
 		return -EADDRNOTAVAIL;
 	cfg = readl_relaxed(dcscb_base + DCS_CFG_R);

Signature · 1 line

2.9.5

Sudeep Holla

Acked-by on v1 12/15

2019-03-04 14:46 UTC #21 lore raw

Re: [PATCH 12/15] ARM: vexpress: fix a leaked reference by addingmissing of_node_put

Quoted 4 lines · Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.

Quoted 8 lines

Detected by coccinelle with the following warnings:
./arch/arm/mach-vexpress/dcscb.c:150:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function. ./arch/arm/mach-vexpress/dcscb.c:160:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function. ./arch/arm/mach-vexpress/dcscb.c:171:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function.
Signed-off-by Wen Yang <[email protected]>
Cc Liviu Dudau <[email protected]>
Cc Sudeep Holla <[email protected]>

Looks good, assuming you want to take this as a series. Please shout if you want us to take this.

Acked-by Sudeep Holla <[email protected]>

--
Regards,
Sudeep

[email protected]

author

2019-03-05 01:28 UTC #22 lore raw

Re: [PATCH 12/15] ARM: vexpress: fix a leaked reference byaddingmissing of_node_put

Quoted 9 lines

Quoted 9 lines
The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.
Detected by coccinelle with the following warnings:
./arch/arm/mach-vexpress/dcscb.c:150:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function. ./arch/arm/mach-vexpress/dcscb.c:160:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function. ./arch/arm/mach-vexpress/dcscb.c:171:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function.

Quoted 8 lines

Quoted 3 lines
Signed-off-by Wen Yang <[email protected]>
Cc Liviu Dudau <[email protected]>
Cc Sudeep Holla <[email protected]>
Looks good, assuming you want to take this as a series. Please shout if you want us to take this.
Acked-by Sudeep Holla <[email protected]>

Thank you very much, we will submit a v2 series patch that will fix a typo soon:
add a missing space between "adding" and "missing"

--
Regards,
Wen

Wen Yang

author

2019-03-01 08:56 UTC #23 lore raw

PATCH 13/15 ARM: zynq: fix a leaked reference by addingmissing of_node_put

In reply to Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-zynq/common.c:89:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 80, but without a corresponding object release within this function. ./arch/arm/mach-zynq/common.c:98:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 80, but without a corresponding object release within this function.

Signed-off-by Wen Yang <[email protected]>

Cc Russell King <[email protected]>

Cc Michal Simek <[email protected]>

Cc [email protected]

---
 arch/arm/mach-zynq/common.c | 1 +
 1 file changed, 1 insertion(+)

arch/arm/mach-zynq/common.c +1 -0

index 6aba9eb..a8b1b9c 100644
@@ -84,6 +84,7 @@ static int __init zynq_get_revision(void)
 	}
 
 	zynq_devcfg_base = of_iomap(np, 0);
+	of_node_put(np);
 	if (!zynq_devcfg_base) {
 		pr_err("%s: Unable to map I/O memory\n", __func__);
 		return -1;

Signature · 1 line

2.9.5

Wen Yang

author

2019-03-01 08:56 UTC #24 lore raw

PATCH 14/15 arm64: cpu_ops: fix a leaked reference by addingmissing of_node_put

In reply to Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.

Detected by coccinelle with the following warnings:
./arch/arm64/kernel/cpu_ops.c:102:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 69, but without a corresponding object release within this function.

Signed-off-by Wen Yang <[email protected]>

Cc Catalin Marinas <[email protected]>

Cc Will Deacon <[email protected]>

Cc [email protected]

---
 arch/arm64/kernel/cpu_ops.c | 1 +
 1 file changed, 1 insertion(+)

arch/arm64/kernel/cpu_ops.c +1 -0

index ea00124..00f8b86 100644
@@ -85,6 +85,7 @@ static const char *__init cpu_read_enable_method(int cpu)
 				pr_err("%pOF: missing enable-method property\n",
 					dn);
 		}
+		of_node_put(dn);
 	} else {
 		enable_method = acpi_get_enable_method(cpu);
 		if (!enable_method) {

Signature · 1 line

2.9.5

Wen Yang

author

2019-03-01 08:56 UTC #25 lore raw

PATCH 15/15 ARM: axxia: fix a leaked reference by addingmissing of_node_put

In reply to Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-axxia/platsmp.c:46:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 40, but without a corresponding object release within this function. ./arch/arm/mach-axxia/platsmp.c:53:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 40, but without a corresponding object release within this function.

Signed-off-by Wen Yang <[email protected]>

Cc Russell King <[email protected]>

Cc [email protected]

---
 arch/arm/mach-axxia/platsmp.c | 1 +
 1 file changed, 1 insertion(+)

arch/arm/mach-axxia/platsmp.c +1 -0

index 502e3df..c706a11 100644
@@ -42,6 +42,7 @@ static int axxia_boot_secondary(unsigned int cpu, struct task_struct *idle)
 		return -ENOENT;
 
 	syscon = of_iomap(syscon_np, 0);
+	of_node_put(syscon_np);
 	if (!syscon)
 		return -ENOMEM;

Signature · 1 line

2.9.5

Manivannan Sadhasivam

2019-03-01 15:55 UTC #26 lore raw

In reply to Wen Yang

Hi Wen,

Quoted 9 lines · Wen Yang

The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.
Detected by coccinelle with the following warnings:
./arch/arm/mach-actions/platsmp.c:112:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 103, but without a corresponding object release within this function. ./arch/arm/mach-actions/platsmp.c:124:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 115, but without a corresponding object release within this function. ./arch/arm/mach-actions/platsmp.c:137:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 128, but without a corresponding object release within this function.

We have a floating patch for this:
https://www.spinics.net/lists/arm-kernel/msg694544.html

Andreas: Can you please take a second look at the patchset submitted by Linus Walleij and Russel for simplifying the Actions startup code?

Thanks,
Mani

Quoted 41 lines

Signed-off-by Wen Yang <[email protected]>

Cc "Andreas Färber" <[email protected]>

Cc Manivannan Sadhasivam <[email protected]>

Cc Russell King <[email protected]>

Cc [email protected]

---
 arch/arm/mach-actions/platsmp.c | 3 +++
 1 file changed, 3 insertions(+)

arch/arm/mach-actions/platsmp.c +3 -0

index 4fd479c..1a8e078 100644
@@ -107,6 +107,7 @@ static void __init s500_smp_prepare_cpus(unsigned int max_cpus)
 	}
 
 	timer_base_addr = of_iomap(node, 0);
+	of_node_put(node);
 	if (!timer_base_addr) {
 		pr_err("%s: could not map timer registers\n", __func__);
 		return;

@@ -119,6 +120,7 @@ static void __init s500_smp_prepare_cpus(unsigned int max_cpus)
 	}
 
 	sps_base_addr = of_iomap(node, 0);
+	of_node_put(node);
 	if (!sps_base_addr) {
 		pr_err("%s: could not map sps registers\n", __func__);
 		return;

@@ -132,6 +134,7 @@ static void __init s500_smp_prepare_cpus(unsigned int max_cpus)
 		}
 
 		scu_base_addr = of_iomap(node, 0);
+		of_node_put(node);
 		if (!scu_base_addr) {
 			pr_err("%s: could not map scu registers\n", __func__);
 			return;

Signature · 1 line

2.9.5

Linus Walleij

2019-03-04 12:29 UTC #27 lore raw

Quoted 13 lines · Manivannan Sadhasivam

Hi Wen,
Quoted 9 lines · Wen Yang
The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.
Detected by coccinelle with the following warnings:
./arch/arm/mach-actions/platsmp.c:112:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 103, but without a corresponding object release within this function. ./arch/arm/mach-actions/platsmp.c:124:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 115, but without a corresponding object release within this function. ./arch/arm/mach-actions/platsmp.c:137:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 128, but without a corresponding object release within this function.

Quoted 5 lines

We have a floating patch for this:
https://www.spinics.net/lists/arm-kernel/msg694544.html
Andreas: Can you please take a second look at the patchset submitted by Linus Walleij and Russel for simplifying the Actions startup code?

Andreas wrote a version of simplifying secondary startup in the same spirit as Russell's patches, and it's merged and all is fine I think.

If this patch applied on top of the current upstream code I'd say just forget about my patch and merge Wen's patch instead.

Yours,
Linus Walleij

Manivannan Sadhasivam

2019-03-04 14:48 UTC #28 lore raw

Hi Linus,

Quoted 18 lines · Linus Walleij

Quoted 16 lines · Manivannan Sadhasivam
Hi Wen,
Quoted 9 lines · Wen Yang
The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.
Detected by coccinelle with the following warnings:
./arch/arm/mach-actions/platsmp.c:112:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 103, but without a corresponding object release within this function. ./arch/arm/mach-actions/platsmp.c:124:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 115, but without a corresponding object release within this function. ./arch/arm/mach-actions/platsmp.c:137:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 128, but without a corresponding object release within this function.
We have a floating patch for this:
https://www.spinics.net/lists/arm-kernel/msg694544.html

Quoted 7 lines

Quoted 2 lines
Andreas: Can you please take a second look at the patchset submitted by Linus Walleij and Russel for simplifying the Actions startup code?
Andreas wrote a version of simplifying secondary startup in the same spirit as Russell's patches, and it's merged and all is fine I think.

Oops. I think I missed that! Can you please point me to that patch? And how it got merged? I did the PR for actions stuff this time and haven't included any mach-actions patches.

Thanks,
Mani

Quoted 5 lines

If this patch applied on top of the current upstream code I'd say just forget about my patch and merge Wen's patch instead.
Yours,
Linus Walleij

Linus Walleij

2019-03-04 22:37 UTC #29 lore raw

Quoted 22 lines · Manivannan Sadhasivam

Quoted 21 lines · Linus Walleij
Quoted 18 lines · Manivannan Sadhasivam
Hi Wen,
Quoted 9 lines · Wen Yang
The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.
Detected by coccinelle with the following warnings:
./arch/arm/mach-actions/platsmp.c:112:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 103, but without a corresponding object release within this function. ./arch/arm/mach-actions/platsmp.c:124:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 115, but without a corresponding object release within this function. ./arch/arm/mach-actions/platsmp.c:137:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 128, but without a corresponding object release within this function.
We have a floating patch for this:
https://www.spinics.net/lists/arm-kernel/msg694544.html
Andreas: Can you please take a second look at the patchset submitted by Linus Walleij and Russel for simplifying the Actions startup code?

Quoted 8 lines

Quoted 4 lines
Andreas wrote a version of simplifying secondary startup in the same spirit as Russell's patches, and it's merged and all is fine I think.
Oops. I think I missed that! Can you please point me to that patch? And how it got merged? I did the PR for actions stuff this time and haven't included any mach-actions patches.

I just did git log arch/arm/mach-actions but I think it came in quite some time ago, not last merge window:

But you see:
commit 6c2eb3e76fb84e2eb46d484f71fab469c0d9532c
"ARM: owl: smp: Drop owl_secondary_boot()"
commit bad29933fef76fb6ee577f4a0b6d145c1f52f663
"ARM: owl: smp: Use __pa_symbol()"
commit 18cfd9429d8a82c49add8f3ca9d366599bfcac45
"ARM: owl: smp: Drop bogus holding pen"

platsmp.c looks just fine these days. Except for what Wei's patch is fixing, of_node_put().

Yours,
Linus Walleij

Manivannan Sadhasivam

2019-03-05 01:51 UTC #30 lore raw

Quoted 54 lines · On Tue, 5 Mar, 2019, 4:08 AM Linus Walleij <[email protected] wrote:

Quoted 5 lines · Manivannan Sadhasivam
Quoted 4 lines · Linus Walleij
Quoted 2 lines · Manivannan Sadhasivam
Hi Wen,
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines · Wen Yang
Quoted 6 lines
The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.
Detected by coccinelle with the following warnings:
./arch/arm/mach-actions/platsmp.c:112:2-8: ERROR: missing
of_node_put; acquired a node pointer with refcount incremented on line 103, but without a corresponding object release within this function.
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
./arch/arm/mach-actions/platsmp.c:124:2-8: ERROR: missing
of_node_put; acquired a node pointer with refcount incremented on line 115, but without a corresponding object release within this function.
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
./arch/arm/mach-actions/platsmp.c:137:3-9: ERROR: missing
of_node_put; acquired a node pointer with refcount incremented on line 128, but without a corresponding object release within this function.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 1 line
We have a floating patch for this:
https://www.spinics.net/lists/arm-kernel/msg694544.html
Andreas: Can you please take a second look at the patchset submitted
by Linus
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Walleij and Russel for simplifying the Actions startup code?
Andreas wrote a version of simplifying secondary startup in the same spirit as Russell's patches, and it's merged and all is fine I think.
Oops. I think I missed that! Can you please point me to that patch? And
how it
Quoted 1 line
got merged? I did the PR for actions stuff this time and haven't
included any
Quoted 1 line
mach-actions patches.
I just did git log arch/arm/mach-actions but I think it came in quite some time
ago, not last merge window:
But you see:
commit 6c2eb3e76fb84e2eb46d484f71fab469c0d9532c
"ARM: owl: smp: Drop owl_secondary_boot()"
commit bad29933fef76fb6ee577f4a0b6d145c1f52f663
"ARM: owl: smp: Use __pa_symbol()"
commit 18cfd9429d8a82c49add8f3ca9d366599bfcac45
"ARM: owl: smp: Drop bogus holding pen"

Quoted 4 lines

platsmp.c looks just fine these days. Except for what Wei's patch is fixing,
of_node_put().

Nope. platsmp.c still requires some cleanup like removing the redundant bootlock and pen_release flag as pointed out by Russel. Andreas just replied to your cleanup patches but there was no follow up since that. So, I guess we can just apply Russell's patches and this patch once Andreas is fine with it (it looks good to me though).

Thanks,
Mani

Quoted 3 lines

Yours,
Linus Walleij

Russell King - ARM Linux admin

maintainer

2019-03-05 09:55 UTC #31 lore raw

Quoted 61 lines · Manivannan Sadhasivam

Quoted 54 lines · On Tue, 5 Mar, 2019, 4:08 AM Linus Walleij <[email protected] wrote:
Quoted 5 lines · Manivannan Sadhasivam
Quoted 4 lines · Linus Walleij
Quoted 2 lines · Manivannan Sadhasivam
Hi Wen,
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines · Wen Yang
Quoted 6 lines
The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage.
Detected by coccinelle with the following warnings:
./arch/arm/mach-actions/platsmp.c:112:2-8: ERROR: missing
of_node_put; acquired a node pointer with refcount incremented on line 103, but without a corresponding object release within this function.
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
./arch/arm/mach-actions/platsmp.c:124:2-8: ERROR: missing
of_node_put; acquired a node pointer with refcount incremented on line 115, but without a corresponding object release within this function.
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
./arch/arm/mach-actions/platsmp.c:137:3-9: ERROR: missing
of_node_put; acquired a node pointer with refcount incremented on line 128, but without a corresponding object release within this function.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 1 line
We have a floating patch for this:
https://www.spinics.net/lists/arm-kernel/msg694544.html
Andreas: Can you please take a second look at the patchset submitted
by Linus
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Walleij and Russel for simplifying the Actions startup code?
Andreas wrote a version of simplifying secondary startup in the same spirit as Russell's patches, and it's merged and all is fine I think.
Oops. I think I missed that! Can you please point me to that patch? And
how it
Quoted 1 line
got merged? I did the PR for actions stuff this time and haven't
included any
Quoted 1 line
mach-actions patches.
I just did git log arch/arm/mach-actions but I think it came in quite some time
ago, not last merge window:
But you see:
commit 6c2eb3e76fb84e2eb46d484f71fab469c0d9532c
"ARM: owl: smp: Drop owl_secondary_boot()"
commit bad29933fef76fb6ee577f4a0b6d145c1f52f663
"ARM: owl: smp: Use __pa_symbol()"
commit 18cfd9429d8a82c49add8f3ca9d366599bfcac45
"ARM: owl: smp: Drop bogus holding pen"
Quoted 4 lines
platsmp.c looks just fine these days. Except for what Wei's patch is fixing,
of_node_put().

Quoted 5 lines

Nope. platsmp.c still requires some cleanup like removing the redundant bootlock and pen_release flag as pointed out by Russel. Andreas just replied to your cleanup patches but there was no follow up since that. So, I guess we can just apply Russell's patches and this patch once Andreas is fine with it (it looks good to me though).

No. My patches are in my tree queued for this merge window. They are part of a series that can not be broken up and merged separately because all the per-platform patches need to be merged before the final patch "ARM: smp: remove arch-provided "pen_release"" otherwise the platforms break. I thought that was already explained.

Signature · 3 lines

RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up