pwm: atmel: Remove useless symbolic definitions
Subsystems (3)
PATCH 1/1 pwm: atmel: Remove useless symbolic definitions
The values that these symbols define are only assigned to the per-SoC structure where the context is clear, so there's no need for the extra symbolic name.
Signed-off-by Thierry Reding <[email protected]>
--- drivers/pwm/pwm-atmel.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-)
drivers/pwm/pwm-atmel.c +6 -14
@@ -48,14 +48,6 @@#define PWMV2_CPRD 0x0C#define PWMV2_CPRDUPD 0x10 -/* Max values for period and prescaler */ - -/* Only the LSB 16 bits are significant. */ -#define PWM_MAXV1_PRD 0xFFFF -/* All 32 bits are significant. */ -#define PWM_MAXV2_PRD 0xFFFFFFFF -#define PRD_MAXV1_PRES 10 -struct atmel_pwm_registers {u8 period;u8 period_upd;
@@ -294,8 +286,8 @@ static const struct atmel_pwm_data atmel_sam9rl_pwm_data = { }, .cfg = {/* 16 bits to keep period and duty. */ - .max_period = PWM_MAXV1_PRD, - .max_pres = PRD_MAXV1_PRES, + .max_period = 0xffff, + .max_pres = 10, }, };
@@ -308,8 +300,8 @@ static const struct atmel_pwm_data atmel_sama5_pwm_data = { }, .cfg = {/* 16 bits to keep period and duty. */ - .max_period = PWM_MAXV1_PRD, - .max_pres = PRD_MAXV1_PRES, + .max_period = 0xffff, + .max_pres = 10, }, };
@@ -322,8 +314,8 @@ static const struct atmel_pwm_data mchp_sam9x60_pwm_data = { }, .cfg = {/* 32 bits to keep period and duty. */ - .max_period = PWM_MAXV2_PRD, - .max_pres = PRD_MAXV1_PRES, + .max_period = 0xffffffff, + .max_pres = 10, }, };
Signature · 1 line
2.20.1
Quoted 8 lines · Thierry Reding
The values that these symbols define are only assigned to the per-SoC structure where the context is clear, so there's no need for the extra symbolic name.
Signed-off-by Thierry Reding <[email protected]>--- drivers/pwm/pwm-atmel.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-)
Acked-by Claudiu Beznea <[email protected]>
Thierry Reding
AppliedQuoted 8 lines · Thierry Reding
The values that these symbols define are only assigned to the per-SoC structure where the context is clear, so there's no need for the extra symbolic name.
Signed-off-by Thierry Reding <[email protected]>--- drivers/pwm/pwm-atmel.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-)
Applied.
Thierry