Skip to contentSkip to conversation

libcomps: put PV in filename

PATCH In review Ross Burton 2 participants 3 messages Mar 4, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libcomps: put PV in filename

This isn't a git snapshot recipe but a release that is fetched over it. For clarity, put the PV in the filename.

---
 meta/recipes-devtools/libcomps/{libcomps_git.bb => libcomps_0.10.0.bb} | 1 -
 1 file changed, 1 deletion(-)
 rename meta/recipes-devtools/libcomps/{libcomps_git.bb => libcomps_0.10.0.bb} (98%)
meta/recipes-devtools/libcomps/libcomps_0.10.0.bb renamed from meta/recipes-devtools/libcomps/libcomps_git.bb +0 -1
similarity index 98%
rename from meta/recipes-devtools/libcomps/libcomps_git.bb
rename to meta/recipes-devtools/libcomps/libcomps_0.10.0.bb
index ff6820851fe..1c4f3bde65e 100644
@@ -9,7 +9,6 @@ SRC_URI = "git://github.com/rpm-software-management/libcomps.git \
            file://0001-Add-crc32.c-to-sources-list.patch \
            "
 
-PV = "0.1.10"
 SRCREV = "86a82fcd155c27092340d15a34f5c75c4da88243"
 
 S = "${WORKDIR}/git"
Signature · 1 line
2.11.0
#1 lore raw
Quoted 21 lines · Ross Burton

This isn't a git snapshot recipe but a release that is fetched over it. For
clarity, put the PV in the filename.

---
meta/recipes-devtools/libcomps/{libcomps_git.bb =>
libcomps_0.10.0.bb} | 1 -

 1 file changed, 1 deletion(-)
 rename meta/recipes-devtools/libcomps/{libcomps_git.bb =>

libcomps_0.10.0.bb} (98%)

meta/recipes-devtools/libcomps/libcomps_0.10.0.bb renamed from meta/recipes-devtools/libcomps/libcomps_git.bb +0 -0
similarity index 98%
rename from meta/recipes-devtools/libcomps/libcomps_git.bb
rename to meta/recipes-devtools/libcomps/libcomps_0.10.0.bb
index ff6820851fe..1c4f3bde65e 100644

meta/recipes-devtools/libcomps/libcomps_0.10.0.bb SRC_URI = "git://github.com/rpm-software- · line 13

Quoted 6 lines
meta/recipes-devtools/libcomps/libcomps_0.10.0.bb renamed from meta/recipes-devtools/libcomps/libcomps_git.bb +0 -1
@@ -9,7 +9,6 @@ SRC_URI = "git://github.com/rpm-software-
 management/libcomps.git \
            file://0001-Add-crc32.c-to-sources-list.patch \
            "
 
-PV = "0.1.10"
 SRCREV = "86a82fcd155c27092340d15a34f5c75c4da88243"

I suspect we have this issue in a few cases and having PV next to the SRCREV may prompt people to keep things more in sync?

Cheers,

Richard

#2 lore raw
Quoted 2 lines · Richard Purdie

I suspect we have this issue in a few cases and having PV next to the SRCREV may prompt people to keep things more in sync?

I'm sure we do, but I spotted this one. The AUH will do the prompting so I'm not sure what else needs to be kept in sync.

Ross