Skip to contentSkip to conversation

of: Add vendor prefix for Menlo Systems GmbH

PATCH Applied Marek Vasut 4 participants 10 messages Mar 4, 2019 – Mar 21, 2019

Subsystems (3)
Device tree bindings Arm i.MX and Layerscape Arm and arm64 SoC sub-architectures (common parts)

v3 of 4 Applied Latest is v4 →

lore
Share & tools
lore

Marek Vasut

author
#0 lore raw

PATCH v3 1/2 of: Add vendor prefix for Menlo Systems GmbH

Add vendor prefix for Menlo Systems GmbH, http://www.menlosystems.com/ .

Signed-off-by Marek Vasut <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc NXP Linux Team <[email protected]>
Cc Rob Herring <[email protected]>
Cc Shawn Guo <[email protected]>
Cc [email protected]
Reviewed-by Rob Herring <[email protected]>

To: [email protected]
---
V2: - Rebase on latest next/master
V3: - No change

---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index bb6f6e8a2eee..0ccf97d44a32 100644
@@ -244,6 +244,7 @@ melexis	Melexis N.V.
 melfas	MELFAS Inc.
 mellanox	Mellanox Technologies
 memsic	MEMSIC Inc.
+menlo	Menlo Systems GmbH
 merrii	Merrii Technology Co., Ltd.
 micrel	Micrel Inc.
 microchip	Microchip Technology Inc.
Signature · 1 line
2.19.2
author
#1 lore raw

PATCH v3 2/2 ARM: dts: imx53: Add Menlosystems M53 board

Add device tree for the Menlosystems board based on i.MX53 M53 SoM.

Signed-off-by Marek Vasut <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc NXP Linux Team <[email protected]>

To: [email protected]
---
V2: - Rebase on latest next/master
V3: - Add vendor specific compatible for the platform
- Rename ledgrp and touchscreen nodes to follow DT spec
- Update pinmux (LVDS has no pin config, so use default settings)

---
 arch/arm/boot/dts/Makefile           |   1 +
 arch/arm/boot/dts/imx53-m53menlo.dts | 316 +++++++++++++++++++++++++++
 2 files changed, 317 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx53-m53menlo.dts
arch/arm/boot/dts/Makefile +1 -0
index ebe409a3f0e6..89911779f1a1 100644
@@ -380,6 +380,7 @@ dtb-$(CONFIG_SOC_IMX53) += \
 	imx53-kp-ddc.dtb \
 	imx53-kp-hsc.dtb \
 	imx53-m53evk.dtb \
+	imx53-m53menlo.dtb \
 	imx53-mba53.dtb \
 	imx53-ppd.dtb \
 	imx53-qsb.dtb \
arch/arm/boot/dts/imx53-m53menlo.dts new file +316 -0

316 lines not on this page · raw message

Signature · 7 lines
2.19.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw

Re: [PATCH V3 2/2] ARM: dts: imx53: Add Menlosystems M53 board

Hello,

arch/arm/boot/dts/imx53-m53menlo.dts line 11

Quoted 2 lines · Marek Vasut
arch/arm/boot/dts/imx53-m53menlo.dts new file +2 -0
+	model = "MENLO M53 EMBEDDED DEVICE";
+	compatible = "menlo,m53menlo", "fsl,imx53";

Doesn't this need adding to
Documentation/devicetree/bindings/arm/fsl.yaml ?

Best regards
Uwe

Signature · 7 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw

Re: [PATCH V3 2/2] ARM: dts: imx53: Add Menlosystems M53 board

Quoted 8 lines · Uwe Kleine-König

Hello,

arch/arm/boot/dts/imx53-m53menlo.dts line 11

Quoted 2 lines · Marek Vasut
arch/arm/boot/dts/imx53-m53menlo.dts new file +2 -0
+	model = "MENLO M53 EMBEDDED DEVICE";
+	compatible = "menlo,m53menlo", "fsl,imx53";

Doesn't this need adding to
Documentation/devicetree/bindings/arm/fsl.yaml ?

Yes, missed that.

Marek,

Please send an incremental patch for that. Thanks.

Shawn

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author
#4 lore raw

Re: [PATCH V3 2/2] ARM: dts: imx53: Add Menlosystems M53 board

In reply to Uwe Kleine-König
Quoted 8 lines · Uwe Kleine-König

Hello,

arch/arm/boot/dts/imx53-m53menlo.dts line 11

Quoted 2 lines · Marek Vasut
arch/arm/boot/dts/imx53-m53menlo.dts new file +2 -0
+	model = "MENLO M53 EMBEDDED DEVICE";
+	compatible = "menlo,m53menlo", "fsl,imx53";

Doesn't this need adding to
Documentation/devicetree/bindings/arm/fsl.yaml ?

OK

Signature · 7 lines
Best regards,
Marek Vasut

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
reviewer
#5 lore raw

Re: [PATCH V3 2/2] ARM: dts: imx53: Add Menlosystems M53 board

In reply to Marek Vasut

Hi Marek,

arch/arm/boot/dts/imx53-m53menlo.dts line 53

Quoted 6 lines · Marek Vasut
arch/arm/boot/dts/imx53-m53menlo.dts new file +6 -0
+       regulators {
+               compatible = "simple-bus";
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               reg_usbh1_vbus: regulator@3 {

Please move the regulator outside the 'simple-bus':

reg_usbh1_vbus: regulator-usbh1-vbus {

arch/arm/boot/dts/imx53-m53menlo.dts line 55

Quoted 2 lines
arch/arm/boot/dts/imx53-m53menlo.dts new file +2 -0
+                       compatible = "regulator-fixed";
+                       reg = <3>;

The 'reg' property can also be removed.

arch/arm/boot/dts/imx53-m53menlo.dts line 59

Quoted 4 lines
arch/arm/boot/dts/imx53-m53menlo.dts new file +4 -0
+                       regulator-name = "vbus";
+                       regulator-min-microvolt = <5000000>;
+                       regulator-max-microvolt = <5000000>;
+                       gpio = <&gpio1 2 0>;

The GPIO flag 0 means active high, but since you are not passing 'enable-active-high' this should be:

gpio = <&gpio1 2 GPIO_ACTIVE_LOW>;

Quoted 2 lines

+&i2c2 {
+ stmpe610@41 {

Node name should be generic, so:

touchscreen@41

arch/arm/boot/dts/imx53-m53menlo.dts line 277

Quoted 6 lines

+&ldb {

arch/arm/boot/dts/imx53-m53menlo.dts new file +5 -0
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_lvds0>;
+       status = "okay";
+
+       lvds0: lvds-channel@0 {

There is an @0 without a corresponding reg property. This triggers a dtc warning when building with W=1.

Please fix it.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#6 lore raw

Re: [PATCH V3 2/2] ARM: dts: imx53: Add Menlosystems M53 board

Quoted 44 lines · Fabio Estevam

Hi Marek,

arch/arm/boot/dts/imx53-m53menlo.dts line 53

Quoted 6 lines · Marek Vasut
arch/arm/boot/dts/imx53-m53menlo.dts new file +6 -0
+       regulators {
+               compatible = "simple-bus";
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               reg_usbh1_vbus: regulator@3 {

Please move the regulator outside the 'simple-bus':

reg_usbh1_vbus: regulator-usbh1-vbus {

arch/arm/boot/dts/imx53-m53menlo.dts line 55

Quoted 2 lines
arch/arm/boot/dts/imx53-m53menlo.dts new file +2 -0
+                       compatible = "regulator-fixed";
+                       reg = <3>;

The 'reg' property can also be removed.

arch/arm/boot/dts/imx53-m53menlo.dts line 59

Quoted 4 lines
arch/arm/boot/dts/imx53-m53menlo.dts new file +4 -0
+                       regulator-name = "vbus";
+                       regulator-min-microvolt = <5000000>;
+                       regulator-max-microvolt = <5000000>;
+                       gpio = <&gpio1 2 0>;

The GPIO flag 0 means active high, but since you are not passing 'enable-active-high' this should be:

gpio = <&gpio1 2 GPIO_ACTIVE_LOW>;

Quoted 2 lines

+&i2c2 {
+ stmpe610@41 {

Node name should be generic, so:

touchscreen@41

arch/arm/boot/dts/imx53-m53menlo.dts line 277

Quoted 6 lines

+&ldb {

arch/arm/boot/dts/imx53-m53menlo.dts new file +5 -0
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_lvds0>;
+       status = "okay";
+
+       lvds0: lvds-channel@0 {
Quoted 4 lines

There is an @0 without a corresponding reg property. This triggers a dtc warning when building with W=1.

Please fix it.

Okay, I dropped the patch and wait for new version.

Shawn

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author
#7 lore raw

Re: [PATCH V3 2/2] ARM: dts: imx53: Add Menlosystems M53 board

Quoted 45 lines · Shawn Guo
Quoted 44 lines · Fabio Estevam

Hi Marek,

arch/arm/boot/dts/imx53-m53menlo.dts line 53

Quoted 6 lines · Marek Vasut
arch/arm/boot/dts/imx53-m53menlo.dts new file +6 -0
+       regulators {
+               compatible = "simple-bus";
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               reg_usbh1_vbus: regulator@3 {

Please move the regulator outside the 'simple-bus':

reg_usbh1_vbus: regulator-usbh1-vbus {

arch/arm/boot/dts/imx53-m53menlo.dts line 55

Quoted 2 lines
arch/arm/boot/dts/imx53-m53menlo.dts new file +2 -0
+                       compatible = "regulator-fixed";
+                       reg = <3>;

The 'reg' property can also be removed.

arch/arm/boot/dts/imx53-m53menlo.dts line 59

Quoted 4 lines
arch/arm/boot/dts/imx53-m53menlo.dts new file +4 -0
+                       regulator-name = "vbus";
+                       regulator-min-microvolt = <5000000>;
+                       regulator-max-microvolt = <5000000>;
+                       gpio = <&gpio1 2 0>;

The GPIO flag 0 means active high, but since you are not passing 'enable-active-high' this should be:

gpio = <&gpio1 2 GPIO_ACTIVE_LOW>;

Quoted 2 lines

+&i2c2 {
+ stmpe610@41 {

Node name should be generic, so:

touchscreen@41

Quoted 6 lines

+&ldb {

arch/arm/boot/dts/imx53-m53menlo.dts new file +5 -0
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_lvds0>;
+       status = "okay";
+
+       lvds0: lvds-channel@0 {
Quoted 6 lines
Quoted 4 lines

There is an @0 without a corresponding reg property. This triggers a dtc warning when building with W=1.

Please fix it.

Okay, I dropped the patch and wait for new version.

Okay ...

Signature · 7 lines
Best regards,
Marek Vasut

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author
#8 lore raw

Re: [PATCH V3 2/2] ARM: dts: imx53: Add Menlosystems M53 board

In reply to Fabio Estevam
Quoted 1 line · Fabio Estevam

Hi Marek,

Hi,

Quoted 26 lines · Marek Vasut

arch/arm/boot/dts/imx53-m53menlo.dts line 53

Quoted 7 lines
arch/arm/boot/dts/imx53-m53menlo.dts new file +6 -0
+       regulators {
+               compatible = "simple-bus";
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               reg_usbh1_vbus: regulator@3 {

Please move the regulator outside the 'simple-bus':

reg_usbh1_vbus: regulator-usbh1-vbus {

arch/arm/boot/dts/imx53-m53menlo.dts line 55

Quoted 2 lines
arch/arm/boot/dts/imx53-m53menlo.dts new file +2 -0
+                       compatible = "regulator-fixed";
+                       reg = <3>;

The 'reg' property can also be removed.

arch/arm/boot/dts/imx53-m53menlo.dts line 59

Quoted 4 lines
arch/arm/boot/dts/imx53-m53menlo.dts new file +4 -0
+                       regulator-name = "vbus";
+                       regulator-min-microvolt = <5000000>;
+                       regulator-max-microvolt = <5000000>;
+                       gpio = <&gpio1 2 0>;

The GPIO flag 0 means active high, but since you are not passing 'enable-active-high' this should be:

Quoted 8 lines

gpio = <&gpio1 2 GPIO_ACTIVE_LOW>;

Quoted 2 lines

+&i2c2 {
+ stmpe610@41 {

Node name should be generic, so:

touchscreen@41

This is referencing a node in DTSi, so I can't change it here.

Quoted 11 lines

arch/arm/boot/dts/imx53-m53menlo.dts line 277

Quoted 6 lines

+&ldb {

arch/arm/boot/dts/imx53-m53menlo.dts new file +5 -0
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_lvds0>;
+       status = "okay";
+
+       lvds0: lvds-channel@0 {

There is an @0 without a corresponding reg property. This triggers a dtc warning when building with W=1.

Please fix it.

Okay

Signature · 7 lines
Best regards,
Marek Vasut

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel