Skip to contentSkip to conversation

update copyright notice

PATCH In review David Kiarie 3 participants 14 messages Mar 4, 2019 – Mar 5, 2019 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

cover update copyright notice

i think it is best put as i've updated.

David Kiarie (1):
update copyright notice

 hw/i386/amd_iommu.c | 2 +-
 hw/i386/amd_iommu.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 update copyright notice

---
 hw/i386/amd_iommu.c | 2 +-
 hw/i386/amd_iommu.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
hw/i386/amd_iommu.c +1 -1
index 8ad707a..6eabdf9 100644
@@ -2,7 +2,7 @@
  * QEMU emulation of AMD IOMMU (AMD-Vi)
  *
  * Copyright (C) 2011 Eduard - Gabriel Munteanu
- * Copyright (C) 2015 David Kiarie, <[email protected]>
+ * Copyright (C) 2015, 2016 David Kiarie Kahurani
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
hw/i386/amd_iommu.h +1 -1
index c52886f..0ff9095 100644
@@ -2,7 +2,7 @@
  * QEMU emulation of an AMD IOMMU (AMD-Vi)
  *
  * Copyright (C) 2011 Eduard - Gabriel Munteanu
- * Copyright (C) 2015 David Kiarie, <[email protected]>
+ * Copyright (C) 2015, 2016 David Kiarie Kahurani
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
Signature · 1 line
2.21.0
Reviewed-by on v1 1/1
#2 lore raw
Quoted 1 line · David Kiarie
Quoted 32 lines
---
 hw/i386/amd_iommu.c | 2 +-
 hw/i386/amd_iommu.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
hw/i386/amd_iommu.c +1 -1
index 8ad707a..6eabdf9 100644
@@ -2,7 +2,7 @@
  * QEMU emulation of AMD IOMMU (AMD-Vi)
  *
  * Copyright (C) 2011 Eduard - Gabriel Munteanu
- * Copyright (C) 2015 David Kiarie, <[email protected]>
+ * Copyright (C) 2015, 2016 David Kiarie Kahurani
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
hw/i386/amd_iommu.h +1 -1
index c52886f..0ff9095 100644
@@ -2,7 +2,7 @@
  * QEMU emulation of an AMD IOMMU (AMD-Vi)
  *
  * Copyright (C) 2011 Eduard - Gabriel Munteanu
- * Copyright (C) 2015 David Kiarie, <[email protected]>
+ * Copyright (C) 2015, 2016 David Kiarie Kahurani
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
#3 lore raw
Quoted 5 lines · Philippe Mathieu-Daudé
Quoted 1 line · David Kiarie

would i be wrong to say this patch received unwarranted scrutiny from you, Philippe?

Quoted 33 lines
Quoted 32 lines
---
 hw/i386/amd_iommu.c | 2 +-
 hw/i386/amd_iommu.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
hw/i386/amd_iommu.c +1 -1
index 8ad707a..6eabdf9 100644
@@ -2,7 +2,7 @@
  * QEMU emulation of AMD IOMMU (AMD-Vi)
  *
  * Copyright (C) 2011 Eduard - Gabriel Munteanu
- * Copyright (C) 2015 David Kiarie, <[email protected]>
+ * Copyright (C) 2015, 2016 David Kiarie Kahurani
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
hw/i386/amd_iommu.h +1 -1
index c52886f..0ff9095 100644
@@ -2,7 +2,7 @@
  * QEMU emulation of an AMD IOMMU (AMD-Vi)
  *
  * Copyright (C) 2011 Eduard - Gabriel Munteanu
- * Copyright (C) 2015 David Kiarie, <[email protected]>
+ * Copyright (C) 2015, 2016 David Kiarie Kahurani
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
#4 lore raw
Quoted 5 lines · David Kiarie

On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé <[email protected]> wrote:

Quoted 9 lines
Quoted 5 lines · David Kiarie
Quoted 1 line

would i be wrong to say this patch received unwarranted scrutiny from you, Philippe?

i mean, given you have never been involved in any IOMMU work, i wouldn't expect that you're in a position to asking questions about the copyright.

Quoted 36 lines
Quoted 35 lines
Quoted 34 lines

---
 hw/i386/amd_iommu.c | 2 +-
 hw/i386/amd_iommu.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
hw/i386/amd_iommu.c +1 -1
index 8ad707a..6eabdf9 100644
@@ -2,7 +2,7 @@
  * QEMU emulation of AMD IOMMU (AMD-Vi)
  *
  * Copyright (C) 2011 Eduard - Gabriel Munteanu
- * Copyright (C) 2015 David Kiarie, <[email protected]>
+ * Copyright (C) 2015, 2016 David Kiarie Kahurani
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
hw/i386/amd_iommu.h +1 -1
index c52886f..0ff9095 100644
@@ -2,7 +2,7 @@
  * QEMU emulation of an AMD IOMMU (AMD-Vi)
  *
  * Copyright (C) 2011 Eduard - Gabriel Munteanu
- * Copyright (C) 2015 David Kiarie, <[email protected]>
+ * Copyright (C) 2015, 2016 David Kiarie Kahurani
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
#5 lore raw
Quoted 16 lines · David Kiarie
Quoted 11 lines · David Kiarie
Quoted 5 lines · Philippe Mathieu-Daudé
Quoted 1 line · David Kiarie
Quoted 7 lines
Quoted 3 lines

would i be wrong to say this patch received unwarranted scrutiny from you, Philippe?

i mean, given you have never been involved in any IOMMU work, i wouldn't expect that you're in a position to asking questions about the copyright.

yet, for some strange reason, you just couldn't help it.

ok.

Quoted 42 lines
Quoted 42 lines
Quoted 41 lines
Quoted 14 lines



---
 hw/i386/amd_iommu.c | 2 +-
 hw/i386/amd_iommu.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
hw/i386/amd_iommu.c +0 -0
index 8ad707a..6eabdf9 100644

hw/i386/amd_iommu.c line 7

Quoted 7 lines
hw/i386/amd_iommu.c +1 -1
@@ -2,7 +2,7 @@
  * QEMU emulation of AMD IOMMU (AMD-Vi)
  *
  * Copyright (C) 2011 Eduard - Gabriel Munteanu
- * Copyright (C) 2015 David Kiarie, <[email protected]>
+ * Copyright (C) 2015, 2016 David Kiarie Kahurani
  *
  * This program is free software; you can redistribute it and/or

modify

hw/i386/amd_iommu.c line 8

Quoted 1 line
hw/i386/amd_iommu.c +0 -0
  * it under the terms of the GNU General Public License as published

by

hw/i386/amd_iommu.h line 7

Quoted 12 lines
hw/i386/amd_iommu.h +1 -1
index c52886f..0ff9095 100644
@@ -2,7 +2,7 @@
  * QEMU emulation of an AMD IOMMU (AMD-Vi)
  *
  * Copyright (C) 2011 Eduard - Gabriel Munteanu
- * Copyright (C) 2015 David Kiarie, <[email protected]>
+ * Copyright (C) 2015, 2016 David Kiarie Kahurani
  *
  * This program is free software; you can redistribute it and/or

modify

hw/i386/amd_iommu.h line 8

Quoted 1 line
hw/i386/amd_iommu.h +0 -0
  * it under the terms of the GNU General Public License as published

by

Quoted 1 line
#6 lore raw
Quoted 11 lines
Quoted 11 lines
Quoted 10 lines · David Kiarie
Quoted 4 lines
Quoted 1 line

would i be wrong to say this patch received unwarranted scrutiny from you, Philippe?

Quoted 8 lines
Quoted 3 lines

i mean, given you have never been involved in any IOMMU work, i wouldn't expect that you're in a position to asking questions about the copyright.

yet, for some strange reason, you just couldn't help it.

ok.

and, by the way, if you can't answer my question, then your review is just as good as none.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
#7 lore raw
In reply to David Kiarie

Hi David,

Quoted 18 lines · David Kiarie

On Mon, Mar 4, 2019 at 10:20 PM David Kiarie <[email protected] <mailto:[email protected]>> wrote:

On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé <[email protected] <mailto:[email protected]>> wrote:

On 3/4/19 4:18 PM, David Kiarie wrote:
> Signed-off-by: David Kiarie <[email protected] <mailto:[email protected]>>

<mailto:[email protected]>>

Quoted 6 lines

would i be wrong to say this patch received unwarranted scrutiny from you, Philippe?

i mean, given you have never been involved in any IOMMU work, i wouldn't expect that you're in a position to asking questions about the copyright.

IANAL and I have no knowledge of IOMMU indeed.
I noticed first this patch is sent from the same email used in this copyright notice, then the patch content merged in commit d29a09ca684 was accepted in 2016 with a copyright date of 2015, hence your copyright modification looks correct to me.

Regards,

Philippe.

Quoted 43 lines

        > ---
        >  hw/i386/amd_iommu.c | 2 +-
        >  hw/i386/amd_iommu.h | 2 +-
        >  2 files changed, 2 insertions(+), 2 deletions(-)
        >
        > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
        > index 8ad707a..6eabdf9 100644
        > --- a/hw/i386/amd_iommu.c
        > +++ b/hw/i386/amd_iommu.c
        > @@ -2,7 +2,7 @@
        >   * QEMU emulation of AMD IOMMU (AMD-Vi)
        >   *
        >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
        > - * Copyright (C) 2015 David Kiarie, <[email protected]
        <mailto:[email protected]>>
        > + * Copyright (C) 2015, 2016 David Kiarie Kahurani
        >   *
        >   * This program is free software; you can redistribute it
        and/or modify
        >   * it under the terms of the GNU General Public License as
        published by
        > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
        > index c52886f..0ff9095 100644
        > --- a/hw/i386/amd_iommu.h
        > +++ b/hw/i386/amd_iommu.h
        > @@ -2,7 +2,7 @@
        >   * QEMU emulation of an AMD IOMMU (AMD-Vi)
        >   *
        >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
        > - * Copyright (C) 2015 David Kiarie, <[email protected]
        <mailto:[email protected]>>
        > + * Copyright (C) 2015, 2016 David Kiarie Kahurani
        >   *
        >   * This program is free software; you can redistribute it
        and/or modify
        >   * it under the terms of the GNU General Public License as
        published by
        >
#8 lore raw
Quoted 10 lines

IANAL and I have no knowledge of IOMMU indeed.
I noticed first this patch is sent from the same email used in this copyright notice, then the patch content merged in commit d29a09ca684 was accepted in 2016 with a copyright date of 2015, hence your copyright modification looks correct to me.

Regards,

Philippe.

it looks like i already discarded(in the confusion that issued from Qemu not being able to merge a simple patch and creating theories around it) Daniel's review, wouldn't it be unfair to keep yours?

Quoted 3 lines
Quoted 2 lines

A message that is not in the archive (sent off-list or not yet received): [email protected]

#10 lore raw

PATCH 1/1 update copyright notice

i hope you don't find this offensive, Eric but i'm forwarding this message to all the people on this thread.

i don't find anything exactly private in this email.

[off-list]

Quoted 11 lines · David Kiarie
Quoted 5 lines · Philippe Mathieu-Daudé
Quoted 1 line · David Kiarie

would i be wrong to say this patch received unwarranted scrutiny from you, Philippe?

David, please calm down, and don't write emails that can sound like you are attacking your reviewers on list. Assume good intent - Philippe reviewed your patch with the same level of scrutiny as many other patches he reviews, and his question for your previous patch revision about whether you intended to change the copyright year was not an attack, but an honest question.

Open source works best when anyone feels like they can contribute. Copyright lines are an interesting beast - they carry legal significance, so care should be taken that they aren't changed by mistake, but at the same time, you do not have to know the code that the copyright is protecting to ask an honest question about whether a change is intentional.

Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org
#11 lore raw
Quoted 29 lines · David Kiarie

i hope you don't find this offensive, Eric but i'm forwarding this message to all the people on this thread.

i don't find anything exactly private in this email.

[off-list]

Quoted 11 lines · David Kiarie

On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé <[email protected]

Quoted 5 lines · wrote:
Quoted 1 line · David Kiarie

would i be wrong to say this patch received unwarranted scrutiny from

you,

Quoted 1 line

Philippe?

David, please calm down, and don't write emails that can sound like you are attacking your reviewers on list. Assume good intent - Philippe reviewed your patch with the same level of scrutiny as many other patches he reviews, and his question for your previous patch revision about whether you intended to change the copyright year was not an attack, but an honest question.

Quoted 7 lines

Open source works best when anyone feels like they can contribute. Copyright lines are an interesting beast - they carry legal significance, so care should be taken that they aren't changed by mistake, but at the same time, you do not have to know the code that the copyright is protecting to ask an honest question about whether a change is intentional.

it's simply not fair for me to waiting for you guys to merge this patch. i sent both, you can pick whichever.

Quoted 6 lines

--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org

#12 lore raw
In reply to David Kiarie
Quoted 8 lines · David Kiarie

i think it is best put as i've updated.

David Kiarie (1):
update copyright notice

  hw/i386/amd_iommu.c | 2 +-
  hw/i386/amd_iommu.h | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

You have now posted two separate threads with identical subjects but with different contents. As a courtesy to your reviewers, and to help the maintainers know for sure which version you want incorporated, it would have been nicer if you had used 'git send-email -v4' for this series, to differentiate it from v3 (if I counted right) sent at https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg06457.html, as well as summarizing how this version differs from the previous.

That said, I do not think you need to send a v5 just to fix the subject line in the cover letter (as the cover letter doesn't end up in git anyways), especially since Paolo has already said he will queue your patch, and I trust Paolo to get the right version included.

Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org
#13 lore raw
Quoted 18 lines · Eric Blake
Quoted 8 lines · David Kiarie

i think it is best put as i've updated.

David Kiarie (1):
update copyright notice

  hw/i386/amd_iommu.c | 2 +-
  hw/i386/amd_iommu.h | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

You have now posted two separate threads with identical subjects but with different contents. As a courtesy to your reviewers, and to help the maintainers know for sure which version you want incorporated, it would have been nicer if you had used 'git send-email -v4' for this series, to differentiate it from v3 (if I counted right) sent at
https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg06457.html, as well as summarizing how this version differs from the previous.

Quoted 5 lines

That said, I do not think you need to send a v5 just to fix the subject line in the cover letter (as the cover letter doesn't end up in git anyways), especially since Paolo has already said he will queue your patch, and I trust Paolo to get the right version included.

i am not okay with maintainer behaviour, this is just something personal.

i will definitely send v4 but this series will include a patch stripping all AMD IOMMU code from for Paolo to choose what to merge.

Quoted 5 lines

--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org

#14 lore raw
Quoted 22 lines · David Kiarie
Quoted 18 lines · Eric Blake
Quoted 8 lines · David Kiarie

i think it is best put as i've updated.

David Kiarie (1):
update copyright notice

  hw/i386/amd_iommu.c | 2 +-
  hw/i386/amd_iommu.h | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

You have now posted two separate threads with identical subjects but with different contents. As a courtesy to your reviewers, and to help the maintainers know for sure which version you want incorporated, it would have been nicer if you had used 'git send-email -v4' for this series, to differentiate it from v3 (if I counted right) sent at
https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg06457.html, as well as summarizing how this version differs from the previous.

Quoted 8 lines
Quoted 5 lines

That said, I do not think you need to send a v5 just to fix the subject line in the cover letter (as the cover letter doesn't end up in git anyways), especially since Paolo has already said he will queue your patch, and I trust Paolo to get the right version included.

i am not okay with maintainer behaviour, this is just something personal.

Paolo noted that code doesn't get merged right away on Qemu.

consider this:

i) i don't have any interests whatsoever in Qemu and will never have

ii) i will never have any interests in Qemu

iii) i have zero interests in the code we are updating let alone the bugs i recently helped report on this list.

iv)i am taking my own time to send this patch which was merely supposed to reduce any such confusion reporting bugs in the future.

v)* maintainer - patches don't merged right away unless they fix broken things, i have your patch queued. honestly?*

what are we queuing for? why not just rid of rest of my code because this is the epitome of maintainer arrogance.

Quoted 10 lines

i will definitely send v4 but this series will include a patch stripping all AMD IOMMU code from for Paolo to choose what to merge.

Quoted 5 lines

--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org