Skip to contentSkip to conversation

selftest/rseq: Remove duplicate header

PATCH In review Souptick Joarder 3 participants 6 messages Mar 4, 2019 – Mar 5, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftest/rseq: Remove duplicate header

Remove duplicate header which is included twice

---
 tools/testing/selftests/rseq/rseq.h | 1 -
 1 file changed, 1 deletion(-)
tools/testing/selftests/rseq/rseq.h +0 -1
index c72eb70..6c1126e7 100644
@@ -16,7 +16,6 @@
 #include <errno.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <sched.h>
 #include <linux/rseq.h>
 
 /*
Signature · 1 line
1.9.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Souptick Joarder jrdr.linux at gmail.com

Remove duplicate header which is included twice

Signed-off-by Sabyasachi Gupta <sabyasachi.linux at gmail.com>
Signed-off-by Souptick Joarder <jrdr.linux at gmail.com>
Acked-by Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
Quoted 19 lines

---
tools/testing/selftests/rseq/rseq.h | 1 -

1 file changed, 1 deletion(-)
tools/testing/selftests/rseq/rseq.h +0 -2
index c72eb70..6c1126e7 100644
@@ -16,7 +16,6 @@
 #include <errno.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <sched.h>
 #include <linux/rseq.h>
 
 /*
--

1.9.1

Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
maintainer
#2 lore raw
In reply to Souptick Joarder
Quoted 4 lines · Souptick Joarder

Remove duplicate header which is included twice

Signed-off-by Sabyasachi Gupta <sabyasachi.linux at gmail.com>
Signed-off-by Souptick Joarder <jrdr.linux at gmail.com>

That SoB chain is invalid.

#3 lore raw
Quoted 8 lines · Peter Zijlstra
Quoted 4 lines · Souptick Joarder

Remove duplicate header which is included twice

Signed-off-by Sabyasachi Gupta <sabyasachi.linux at gmail.com>
Signed-off-by Souptick Joarder <jrdr.linux at gmail.com>

That SoB chain is invalid.

I didn't get why it is invalid ?

#4 lore raw
Quoted 11 lines · ----- On Mar 4, 2019,@1:53 PM, Souptick Joarder [email protected] wrote:
Quoted 8 lines · Peter Zijlstra
Quoted 4 lines · Souptick Joarder

Remove duplicate header which is included twice

Signed-off-by Sabyasachi Gupta <sabyasachi.linux at gmail.com>
Signed-off-by Souptick Joarder <jrdr.linux at gmail.com>

That SoB chain is invalid.

I didn't get why it is invalid ?

I think it's about having the author of the patch (From) as first Signed-off-by, and then apply following Signed-off-by by maintainers who pick up the patch. (That's what I am used to see)

What is the intent behind the second Signed-off-by by Sabyasachi Gupta ?

Thanks,

Mathieu

Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
#5 lore raw
Quoted 13 lines · Mathieu Desnoyers
Quoted 10 lines · Souptick Joarder jrdr.linux at gmail.com
Quoted 8 lines · Peter Zijlstra
Quoted 4 lines · Souptick Joarder

Remove duplicate header which is included twice

Signed-off-by Sabyasachi Gupta <sabyasachi.linux at gmail.com>
Signed-off-by Souptick Joarder <jrdr.linux at gmail.com>

That SoB chain is invalid.

Quoted 7 lines
Quoted 1 line

I didn't get why it is invalid ?

I think it's about having the author of the patch (From) as first Signed-off-by, and then apply following Signed-off-by by maintainers who pick up the patch. (That's what I am used to see)

What is the intent behind the second Signed-off-by by Sabyasachi Gupta ?

Sabyasachi is the author and I am posting his patches as his email client has some issue. I think I need to add Sabyasachi's From: @ the beginning of change log.
Andrew suggested the same in another thread.

Quoted 9 lines

Thanks,

Mathieu

--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com