Skip to contentSkip to conversation

ARM: dts: r8a7792: blanche: Add IIC3 and DA9063 PMIC node

PATCH Applied [email protected] 3 participants 4 messages Mar 4, 2019 – May 2, 2019 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: r8a7792: blanche: Add IIC3 and DA9063 PMIC node

From: Marek Vasut <[email protected]>

Add IIC3 node to R8A7792 SoC device tree and a DA9063 PMIC node to V2H Blanche board device tree.

Cc Geert Uytterhoeven <[email protected]>
Cc Simon Horman <[email protected]>

To: [email protected]
---
NOTE: R8A7792 Blanche does not share the PMIC IRQ line with other PMICs,
hence the regulator-quirk-rcar-gen2.c does not need a new entry.

---
 arch/arm/boot/dts/r8a7792-blanche.dts | 20 ++++++++++++++++++++
 arch/arm/boot/dts/r8a7792.dtsi        | 18 ++++++++++++++++++
 2 files changed, 38 insertions(+)
arch/arm/boot/dts/r8a7792-blanche.dts +20 -0
index f92301290b02..b6fa80c3b07e 100644
@@ -308,6 +308,26 @@
 	};
 };
 
+&iic3 {
+	status = "okay";
+
+	pmic@58 {
+		compatible = "dlg,da9063";
+		reg = <0x58>;
+		interrupt-parent = <&irqc>;
+		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-controller;
+
+		rtc {
+			compatible = "dlg,da9063-rtc";
+		};
+
+		wdt {
+			compatible = "dlg,da9063-watchdog";
+		};
+	};
+};
+
 &du {
 	pinctrl-0 = <&du0_pins &du1_pins>;
 	pinctrl-names = "default";
arch/arm/boot/dts/r8a7792.dtsi +18 -0
index 8e9eb4b704d3..38fb43d11b27 100644
@@ -22,6 +22,7 @@
 		i2c3 = &i2c3;
 		i2c4 = &i2c4;
 		i2c5 = &i2c5;
+		i2c6 = &iic3;
 		spi0 = &qspi;
 		spi1 = &msiof0;
 		spi2 = &msiof1;
@@ -444,6 +445,23 @@
 			status = "disabled";
 		};
 
+		iic3: i2c@e60b0000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "renesas,iic-r8a7792",
+				     "renesas,rcar-gen2-iic",
+				     "renesas,rmobile-iic";
+			reg = <0 0xe60b0000 0 0x425>;
+			interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 926>;
+			dmas = <&dmac0 0x77>, <&dmac0 0x78>,
+			       <&dmac1 0x77>, <&dmac1 0x78>;
+			dma-names = "tx", "rx", "tx", "rx";
+			power-domains = <&sysc R8A7792_PD_ALWAYS_ON>;
+			resets = <&cpg 926>;
+			status = "disabled";
+		};
+
 		dmac0: dma-controller@e6700000 {
 			compatible = "renesas,dmac-r8a7792",
 				     "renesas,rcar-dmac";
Signature · 1 line
2.19.2
Applied
#1 lore raw
Quoted 9 lines · On Mon, Mar 04, 2019 at 08:59:58PM +0100, [email protected] wrote:

From: Marek Vasut <[email protected]>

Add IIC3 node to R8A7792 SoC device tree and a DA9063 PMIC node to V2H Blanche board device tree.

Cc Geert Uytterhoeven <[email protected]>
Cc Simon Horman <[email protected]>
Quoted 8 lines

To: [email protected]
---
NOTE: R8A7792 Blanche does not share the PMIC IRQ line with other PMICs,
hence the regulator-quirk-rcar-gen2.c does not need a new entry.

---
 arch/arm/boot/dts/r8a7792-blanche.dts | 20 ++++++++++++++++++++
 arch/arm/boot/dts/r8a7792.dtsi        | 18 ++++++++++++++++++
 2 files changed, 38 insertions(+)

Thanks, applied for v5.2.

Reviewed-by on v1 1/1
#2 lore raw
In reply to [email protected]

Hi Marek,

Quoted 6 lines · On Mon, Mar 4, 2019 at 9:00 PM <[email protected]> wrote:

From: Marek Vasut <[email protected]>

Add IIC3 node to R8A7792 SoC device tree and a DA9063 PMIC node to V2H Blanche board device tree.

Quoted 4 lines
arch/arm/boot/dts/r8a7792-blanche.dts +0 -0
@@ -308,6 +308,26 @@
        };

arch/arm/boot/dts/r8a7792-blanche.dts line 318

Quoted 10 lines
arch/arm/boot/dts/r8a7792-blanche.dts +8 -0
 };
 
+&iic3 {
+       status = "okay";
+
+       pmic@58 {
+               compatible = "dlg,da9063";
+               reg = <0x58>;
+               interrupt-parent = <&irqc>;
+               interrupts = <2 IRQ_TYPE_LEVEL_LOW>;

I've just realized none of the R-Car Gen2 boards configure pinctrl for the IRQC2 line (intc_irq2/intc), so they all rely on the boot loader doing that.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#3 lore raw
Quoted 18 lines · Geert Uytterhoeven

Hi Marek,

Quoted 6 lines · On Mon, Mar 4, 2019 at 9:00 PM <[email protected]> wrote:

From: Marek Vasut <[email protected]>

Add IIC3 node to R8A7792 SoC device tree and a DA9063 PMIC node to V2H Blanche board device tree.

Quoted 6 lines
arch/arm/boot/dts/r8a7792-blanche.dts +0 -0
@@ -308,6 +308,26 @@
        };
 };
 
Quoted 11 lines

arch/arm/boot/dts/r8a7792-blanche.dts line 318

Quoted 8 lines
arch/arm/boot/dts/r8a7792-blanche.dts +8 -0
+&iic3 {
+       status = "okay";
+
+       pmic@58 {
+               compatible = "dlg,da9063";
+               reg = <0x58>;
+               interrupt-parent = <&irqc>;
+               interrupts = <2 IRQ_TYPE_LEVEL_LOW>;

I've just realized none of the R-Car Gen2 boards configure pinctrl for the IRQC2 line (intc_irq2/intc), so they all rely on the boot loader doing that.

I just sent out a patch

Signature · 2 lines
Best regards,
Marek Vasut