netfilter: nf_conntrack_sip: fix IPV6 dependency
Subsystems (3)
PATCH 1/1 netfilter: nf_conntrack_sip: fix IPV6 dependency
With CONFIG_IPV6=m and CONFIG_NF_CONNTRACK_SIP=y, we now get a link failure:
net/netfilter/nf_conntrack_sip.o: In function `process_sdp':
nf_conntrack_sip.c:(.text+0x4344): undefined reference to `ip6_route_output_flags'
Fix this by adding a dependency that forces CONFIG_NF_CONNTRACK_SIP to be =m when CONFIG_IPV6=m, as we already do for several other drivers with a similar requirement.
--- net/netfilter/Kconfig | 1 + 1 file changed, 1 insertion(+)
net/netfilter/Kconfig +1 -0
@@ -333,6 +333,7 @@ config NF_CONNTRACK_SANE config NF_CONNTRACK_SIP tristate "SIP protocol support" + depends on IPV6 || IPV6=n default m if NETFILTER_ADVANCED=n help SIP is an application-layer control protocol that can establish,
Signature · 1 line
2.20.0
Pablo Neira Ayuso
maintainerhi Arnd,
Cc'ing Alin Nastac.
Quoted 4 lines · Arnd Bergmann
With
CONFIG_IPV6=mandCONFIG_NF_CONNTRACK_SIP=y, we now get a link failure:
net/netfilter/nf_conntrack_sip.o: In function `process_sdp':
nf_conntrack_sip.c:(.text+0x4344): undefined reference to `ip6_route_output_flags'
I see. We can probably use nf_route() instead.
Or if needed, use struct nf_ipv6_ops for this.
if (v6ops)
ret = v6ops->route_xyz(...);@Alin: Would you send us a patch to do so to fix a3419ce3356cf1f
netfilter: nf_conntrack_sip: add sip_external_media logic".
This direct dependency with IPv6 is superfluous, it should not happen.
Thanks!
Hi Pablo,
Quoted 13 lines · Pablo Neira Ayuso
hi Arnd,
Cc'ing Alin Nastac.
Quoted 4 lines · Arnd Bergmann
With
CONFIG_IPV6=mandCONFIG_NF_CONNTRACK_SIP=y, we now get a link failure:
net/netfilter/nf_conntrack_sip.o: In function `process_sdp':
nf_conntrack_sip.c:(.text+0x4344): undefined reference to `ip6_route_output_flags'I see. We can probably use
nf_route()instead.
Quoted 7 lines
Or if needed, use struct
nf_ipv6_opsfor this.if (v6ops) ret = v6ops->route_xyz(...);@Alin: Would you send us a patch to do so to fix
a3419ce3356cf1f
netfilter:nf_conntrack_sip: addsip_external_medialogic".
nf_ip6_route(net, &dst, &fl6, false) seems to be appropriate. I'll send the patch Monday.
Quoted 11 lines · Alin Năstac
Quoted 10 lines · Pablo Neira Ayuso
Quoted 4 lines · Arnd Bergmann
With
CONFIG_IPV6=mandCONFIG_NF_CONNTRACK_SIP=y, we now get a link failure:
net/netfilter/nf_conntrack_sip.o: In function `process_sdp':
nf_conntrack_sip.c:(.text+0x4344): undefined reference to `ip6_route_output_flags'I see. We can probably use
nf_route()instead.Or if needed, use struct
nf_ipv6_opsfor this.
Quoted 8 lines
Quoted 5 lines
if (v6ops) ret = v6ops->route_xyz(...);@Alin: Would you send us a patch to do so to fix
a3419ce3356cf1f
netfilter:nf_conntrack_sip: addsip_external_medialogic".
nf_ip6_route(net, &dst, &fl6, false)seems to be appropriate. I'll send the patch Monday.
I see the original bug I reported is still there. Can you send that patch you had planned to do?
Arnd
Quoted 15 lines · Arnd Bergmann
Quoted 14 lines · Alin Năstac
Quoted 13 lines · Pablo Neira Ayuso
Quoted 4 lines · Arnd Bergmann
With
CONFIG_IPV6=mandCONFIG_NF_CONNTRACK_SIP=y, we now get a link failure:
net/netfilter/nf_conntrack_sip.o: In function `process_sdp':
nf_conntrack_sip.c:(.text+0x4344): undefined reference to `ip6_route_output_flags'I see. We can probably use
nf_route()instead.Or if needed, use struct
nf_ipv6_opsfor this.if (v6ops) ret = v6ops->route_xyz(...);
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
@Alin: Would you send us a patch to do so to fix
a3419ce3356cf1f
netfilter:nf_conntrack_sip: addsip_external_medialogic".
nf_ip6_route(net, &dst, &fl6, false)seems to be appropriate. I'll send the patch Monday.I see the original bug I reported is still there. Can you send that patch you had planned to do?
Hmm, I think I mixed up this patch with a different one that is missing. Please ignore my reply above.
Arnd