Skip to contentSkip to conversation

package/systemd: fix "Timed out waiting for device /dev/console."

PATCH New Xavier Ruppen 3 participants 4 messages Mar 4, 2019 – Mar 17, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 package/systemd: fix "Timed out waiting for device /dev/console."

Buildroot built with systemd fails to open a login prompt on the serial port when /dev/console is specified as BR2_TARGET_GENERIC_GETTY_PORT (which is its default value):

systemd[1]: dev-console.device: Job dev-console.device/start timed out.
systemd[1]: Timed out waiting for device /dev/console.
systemd[1]: Dependency failed for Serial Getty on console.
systemd[1]: serial-getty at console.service: Job serial-getty at console.service/start failed with result 'dependency'. systemd[1]: dev-console.device: Job dev-console.device/start failed with result 'timeout'. systemd[1]: Reached target Login Prompts.
systemd[1]: Reached target Multi-User System.

According to this issue on Github [1], serial-getty at .service should not be instantiated on /dev/console, console-getty at .service should be used instead. This stems from the fact that there should be no dependency on /dev/console.

[1] https://github.com/systemd/systemd/issues/10914

---

Changes v2 -> v3:
- introduce two separate variables, $TARGET and $LINK_NAME, in order to solve various '@' problems.
- I tested this patch with console and serial-getty. I also

    checked that sed works when changing the baudrate:

    $ ls -al output/target/etc/systemd/system/getty.target.wants/
    total 8
    drwxr-xr-x 2 user user 4096 Mar  4 20:09 .
    drwxr-xr-x 8 user user 4096 Mar  4 20:09 ..
    lrwxrwxrwx 1 user user   52 Mar  4 20:09 console-getty.service -> ../../../../lib/systemd/system/console-getty.service
    
    $ ls -al output/target/etc/systemd/system/getty.target.wants/
    total 8
    drwxr-xr-x 2 user user 4096 Mar  4 20:12 .
    drwxr-xr-x 8 user user 4096 Mar  4 20:12 ..
    lrwxrwxrwx 1 user user   45 Mar  4 20:12 getty at serial-getty.service -> ../../../../lib/systemd/system/getty at .service

Changes v1 -> v2:
- swap tty and console if statements
- use equality operator instead of grep for "console"

 package/systemd/systemd.mk | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)
package/systemd/systemd.mk +14 -4
index 7a46a50ed3..1d0141f20b 100644
@@ -397,19 +397,29 @@ endef
 
 ifneq ($(call qstrip,$(BR2_TARGET_GENERIC_GETTY_PORT)),)
 # systemd needs getty.service for VTs and serial-getty.service for serial ttys
+# note that console-getty.service should be used on /dev/console as it should not have dependencies
 # also patch the file to use the correct baud-rate, the default baudrate is 115200 so look for that
 define SYSTEMD_INSTALL_SERVICE_TTY
-	if echo $(BR2_TARGET_GENERIC_GETTY_PORT) | egrep -q 'tty[0-9]*$$'; \
+	if [ $(BR2_TARGET_GENERIC_GETTY_PORT) = "console" ]; \
+	then \
+		SERVICE="console-getty"; \
+		TARGET=$${SERVICE}.service; \
+		LINK_NAME=$${SERVICE}.service; \
+	elif echo $(BR2_TARGET_GENERIC_GETTY_PORT) | egrep -q 'tty[0-9]*$$'; \
 	then \
 		SERVICE="getty"; \
+		TARGET=$${SERVICE}@.service; \
+		LINK_NAME=$${SERVICE}@$(BR2_TARGET_GENERIC_GETTY_PORT).service; \
 	else \
 		SERVICE="serial-getty"; \
+		TARGET=$${SERVICE}@.service; \
+		LINK_NAME=$${SERVICE}@$(BR2_TARGET_GENERIC_GETTY_PORT).service; \
 	fi; \
-	ln -fs ../../../../lib/systemd/system/$${SERVICE}@.service \
-		$(TARGET_DIR)/etc/systemd/system/getty.target.wants/$${SERVICE}@$(BR2_TARGET_GENERIC_GETTY_PORT).service; \
+	ln -fs ../../../../lib/systemd/system/$${TARGET} \
+		$(TARGET_DIR)/etc/systemd/system/getty.target.wants/$${LINK_NAME}; \
 	if [ $(call qstrip,$(BR2_TARGET_GENERIC_GETTY_BAUDRATE)) -gt 0 ] ; \
 	then \
-		$(SED) 's,115200,$(BR2_TARGET_GENERIC_GETTY_BAUDRATE),' $(TARGET_DIR)/lib/systemd/system/$${SERVICE}@.service; \
+		$(SED) 's,115200,$(BR2_TARGET_GENERIC_GETTY_BAUDRATE),' $(TARGET_DIR)/lib/systemd/system/$${TARGET}; \
 	fi
 endef
 endif
Signature · 1 line
2.21.0
#1 lore raw

PATCH v3 1/1 package/systemd: fix "Timed out waiting for device /dev/console."

Xavier, All,

On 2019-03-04 20:25 +0100, Xavier Ruppen spake thusly:

Quoted 12 lines

Buildroot built with systemd fails to open a login prompt on the serial port when /dev/console is specified as BR2_TARGET_GENERIC_GETTY_PORT (which is its default value):

systemd[1]: dev-console.device: Job dev-console.device/start timed out.
systemd[1]: Timed out waiting for device /dev/console.
systemd[1]: Dependency failed for Serial Getty on console.
systemd[1]: serial-getty at console.service: Job serial-getty at console.service/start failed with result 'dependency'. systemd[1]: dev-console.device: Job dev-console.device/start failed with result 'timeout'. systemd[1]: Reached target Login Prompts.
systemd[1]: Reached target Multi-User System.

Quoted 8 lines

According to this issue on Github [1], serial-getty at .service should not be instantiated on /dev/console, console-getty at .service should be used instead. This stems from the fact that there should be no dependency on /dev/console.

[1] https://github.com/systemd/systemd/issues/10914

However, a slight improvement that can be done when applying, see below...

[--SNIP--]

Quoted 7 lines
package/systemd/systemd.mk +0 -0
index 7a46a50ed3..1d0141f20b 100644
@@ -397,19 +397,29 @@ endef
 
 ifneq ($(call qstrip,$(BR2_TARGET_GENERIC_GETTY_PORT)),)

package/systemd/systemd.mk endef · line 407

Quoted 10 lines
package/systemd/systemd.mk +6 -1
 # systemd needs getty.service for VTs and serial-getty.service for serial ttys
+# note that console-getty.service should be used on /dev/console as it should not have dependencies
 # also patch the file to use the correct baud-rate, the default baudrate is 115200 so look for that
 define SYSTEMD_INSTALL_SERVICE_TTY
-	if echo $(BR2_TARGET_GENERIC_GETTY_PORT) | egrep -q 'tty[0-9]*$$'; \
+	if [ $(BR2_TARGET_GENERIC_GETTY_PORT) = "console" ]; \
+	then \
+		SERVICE="console-getty"; \
+		TARGET=$${SERVICE}.service; \
+		LINK_NAME=$${SERVICE}.service; \

There is now no real need for the SERVICE variable anymore, since we can simply write:

    TARGET='console-getty.service'; \
    LINK_NAME='console-getty.service'

or:

    TARGET='getty at .service'; \
    LINK_NAME='getty@$(BR2_TARGET_GENERIC_GETTY_PORT).service'

Note also that $(BR2_TARGET_GENERIC_GETTY_PORT) whould probably be qstrip-ed now.

Peter, can you handle that when applying?

Regards,
Yann E. MORIN.

Quoted 24 lines
package/systemd/systemd.mk +8 -3
+	elif echo $(BR2_TARGET_GENERIC_GETTY_PORT) | egrep -q 'tty[0-9]*$$'; \
 	then \
 		SERVICE="getty"; \
+		TARGET=$${SERVICE}@.service; \
+		LINK_NAME=$${SERVICE}@$(BR2_TARGET_GENERIC_GETTY_PORT).service; \
 	else \
 		SERVICE="serial-getty"; \
+		TARGET=$${SERVICE}@.service; \
+		LINK_NAME=$${SERVICE}@$(BR2_TARGET_GENERIC_GETTY_PORT).service; \
 	fi; \
-	ln -fs ../../../../lib/systemd/system/$${SERVICE}@.service \
-		$(TARGET_DIR)/etc/systemd/system/getty.target.wants/$${SERVICE}@$(BR2_TARGET_GENERIC_GETTY_PORT).service; \
+	ln -fs ../../../../lib/systemd/system/$${TARGET} \
+		$(TARGET_DIR)/etc/systemd/system/getty.target.wants/$${LINK_NAME}; \
 	if [ $(call qstrip,$(BR2_TARGET_GENERIC_GETTY_BAUDRATE)) -gt 0 ] ; \
 	then \
-		$(SED) 's,115200,$(BR2_TARGET_GENERIC_GETTY_BAUDRATE),' $(TARGET_DIR)/lib/systemd/system/$${SERVICE}@.service; \
+		$(SED) 's,115200,$(BR2_TARGET_GENERIC_GETTY_BAUDRATE),' $(TARGET_DIR)/lib/systemd/system/$${TARGET}; \
 	fi
 endef
 endif
Signature · 1 line
2.21.0
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH v3 1/1 package/systemd: fix "Timed out waiting for device /dev/console."

In reply to Xavier Ruppen
Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Xavier" == Xavier Ruppen <[email protected]> writes:

Buildroot built with systemd fails to open a login prompt on the serial port when /dev/console is specified as BR2_TARGET_GENERIC_GETTY_PORT (which is its default value):

systemd[1]: dev-console.device: Job dev-console.device/start timed out.
systemd[1]: Timed out waiting for device /dev/console.
systemd[1]: Dependency failed for Serial Getty on console.
systemd[1]: serial-getty at console.service: Job serial-getty at console.service/start failed with result 'dependency'. systemd[1]: dev-console.device: Job dev-console.device/start failed with result 'timeout'. systemd[1]: Reached target Login Prompts.
systemd[1]: Reached target Multi-User System.

Quoted 8 lines

According to this issue on Github [1], serial-getty at .service should not be instantiated on /dev/console, console-getty at .service should be used instead. This stems from the fact that there should be no dependency on /dev/console.

[1] https://github.com/systemd/systemd/issues/10914

Committed after adding the cleanups as suggested by Yann, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH v3 1/1 package/systemd: fix "Timed out waiting for device /dev/console."

In reply to Xavier Ruppen
Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Xavier" == Xavier Ruppen <[email protected]> writes:

Buildroot built with systemd fails to open a login prompt on the serial port when /dev/console is specified as BR2_TARGET_GENERIC_GETTY_PORT (which is its default value):

systemd[1]: dev-console.device: Job dev-console.device/start timed out.
systemd[1]: Timed out waiting for device /dev/console.
systemd[1]: Dependency failed for Serial Getty on console.
systemd[1]: serial-getty at console.service: Job serial-getty at console.service/start failed with result 'dependency'. systemd[1]: dev-console.device: Job dev-console.device/start failed with result 'timeout'. systemd[1]: Reached target Login Prompts.
systemd[1]: Reached target Multi-User System.

Quoted 8 lines

According to this issue on Github [1], serial-getty at .service should not be instantiated on /dev/console, console-getty at .service should be used instead. This stems from the fact that there should be no dependency on /dev/console.

[1] https://github.com/systemd/systemd/issues/10914

Committed to 2018.02.x and 2018.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard