Skip to contentSkip to conversation

mips: loongson64: lemote-2f: Add IRQF_NO_SUSPEND to "cascade" irqaction.

PATCH Applied Yifeng Li 2 participants 2 messages Mar 4, 2019 – Mar 11, 2019

Subsystems (2)
lore
Share & tools
lore

Yifeng Li

author
#0 lore raw

PATCH 1/1 mips: loongson64: lemote-2f: Add IRQF_NO_SUSPEND to "cascade" irqaction.

Timekeeping IRQs from CS5536 MFGPT are routed to i8259, which then triggers the "cascade" IRQ on MIPS CPU. Without IRQF_NO_SUSPEND in cascade_irqaction, MFGPT interrupts will be masked in suspend mode, and the machine would be unable to resume once suspended.

Previously, MIPS IRQs were not disabled properly, so the original code appeared to work. Commit a3e6c1eff5 (MIPS: IRQ: Fix disable_irq on CPU IRQs) uncovers the bug. To fix it, add IRQF_NO_SUSPEND to cascade_irqaction.

This commit is functionally identical to 0add9c2f1cff ("MIPS:
Loongson-3: Add IRQF_NO_SUSPEND to Cascade irqaction"), but it forgot to apply the same fix to Loongson2.

---
 arch/mips/loongson64/lemote-2f/irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/loongson64/lemote-2f/irq.c +1 -1
index 9e33e45aa17c..b213cecb8e3a 100644
@@ -103,7 +103,7 @@ static struct irqaction ip6_irqaction = {
 static struct irqaction cascade_irqaction = {
 	.handler = no_action,
 	.name = "cascade",
-	.flags = IRQF_NO_THREAD,
+	.flags = IRQF_NO_THREAD | IRQF_NO_SUSPEND,
 };
 
 void __init mach_init_irq(void)
Signature · 1 line
2.20.1
Applied
#1 lore raw

Hello,

Quoted 10 lines · Yifeng Li

Timekeeping IRQs from CS5536 MFGPT are routed to i8259, which then triggers the "cascade" IRQ on MIPS CPU. Without IRQF_NO_SUSPEND in cascade_irqaction, MFGPT interrupts will be masked in suspend mode, and the machine would be unable to resume once suspended.

Previously, MIPS IRQs were not disabled properly, so the original code appeared to work. Commit a3e6c1eff5 (MIPS: IRQ: Fix disable_irq on CPU IRQs) uncovers the bug. To fix it, add IRQF_NO_SUSPEND to cascade_irqaction.

Quoted 5 lines

This commit is functionally identical to 0add9c2f1cff ("MIPS:
Loongson-3: Add IRQF_NO_SUSPEND to Cascade irqaction"), but it forgot to apply the same fix to Loongson2.

Applied to mips-fixes.

Thanks,
Paul

[ This message was auto-generated; if you believe anything is incorrect
then please email [email protected] to report it. ]