Skip to contentSkip to conversation

tty: vt.c: Fix TIOCL_BLANKSCREEN console blanking if blankinterval == 0

PATCH RESEND New Yifeng Li 1 participant 1 message Mar 4, 2019 TTY layer and serial drivers

lore
Share & tools
lore

Yifeng Li

author
#0 lore raw

PATCH RESEND 1/1 tty: vt.c: Fix TIOCL_BLANKSCREEN console blanking if blankinterval == 0

Previously, in the userspace, it was possible to use the "setterm" command from util-linux to blank the VT console by default, using the following command.

According to the man page,

Quoted 1 line

The force option keeps the screen blank even if a key is pressed.

It was implemented by calling TIOCL_BLANKSCREEN.

	case BLANKSCREEN:
		ioctlarg = TIOCL_BLANKSCREEN;
		if (ioctl(STDIN_FILENO, TIOCLINUX, &ioctlarg))
			warn(_("cannot force blank"));
		break;

However, after Linux 4.12, this command ceased to work anymore, which is unexpected. By inspecting the kernel source, it shows that the issue was triggered by the side-effect from commit a4199f5eb809 ("tty: Disable default console blanking interval").

The console blanking is implemented by function do_blank_screen() in vt.c:
"blank_state" will be initialized to "blank_normal_wait" in con_init() if AND ONLY IF ("blankinterval" > 0). If "blankinterval" is 0, "blank_state" will be "blank_off" (== 0), and a call to do_blank_screen() will always abort, even if a forced blanking is required from the user by calling TIOCL_BLANKSCREEN, the console won't be blanked.

This behavior is unexpected from a user's point-of-view, since it's not mentioned in any documentation. The setterm man page suggests it will always work, and the kernel comments in uapi/linux/tiocl.h says

Quoted 2 lines

/* keep screen blank even if a key is pressed */
#define TIOCL_BLANKSCREEN 14

To fix it, we simply remove the "blank_state != blank_off" check, as pointed out by Nicolas Pitre, this check doesn't logically make sense and it's safe to remove.

Fixes a4199f5eb809 ("tty: Disable default console blanking interval")
---
 drivers/tty/vt/vt.c | 2 --
 1 file changed, 2 deletions(-)
drivers/tty/vt/vt.c +0 -2
index 41ec8e5010f3..279f5b2ac44a 100644
@@ -4168,8 +4168,6 @@ void do_blank_screen(int entering_gfx)
 		return;
 	}
 
-	if (blank_state != blank_normal_wait)
-		return;
 	blank_state = blank_off;
 
 	/* don't blank graphics */
Signature · 1 line
2.20.1