blktests: add userspace IO test
PATCH v2 1/1 blktests: add userspace IO test
Add one test to cover changes on block passthrough IO interface, such as blk_rq_map_user(), blk_rq_map_user_iov(), blk_rq_unmap_user() and blk_rq_map_kern().
--- tests/block/029 | 111 ++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/block/029.out | 4 ++ 2 files changed, 115 insertions(+) create mode 100755 tests/block/029 create mode 100644 tests/block/029.out
tests/block/029 new file +111 -0
@@ -0,0 +1,111 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0+ +# Copyright (c) 2019 Ming Lei <[email protected]> +# +# Test userspace IO on NVMe loop device + +. tests/nvme/rc + +DESCRIPTION="test userspace IO via nvme-cli read/write interface" +QUICK=1 + +requires() { + _have_program nvme && _have_modules loop nvme-loop nvmet && \ + _have_configfs +} + +__test_user_io() +{ + local disk="$1" + local start=$2 + local cnt=$3 + + local bs=$(blockdev --getss $disk) + local size=$(($cnt * $bs)) + + local img=`mktemp /tmp/blk_img_XXXXXX` + local img1=`mktemp /tmp/blk_img_XXXXXX` + + dd if=/dev/urandom of=$img bs=$bs count=$cnt status=none + + cnt=$(($cnt - 1)) + + nvme write --start-block=$start --block-count=$cnt --data-size=$size --data=$img $disk + [ $? -ne 0 ] && return -1 + nvme read --start-block=$start --block-count=$cnt --data-size=$size --data=$img1 $disk + [ $? -ne 0 ] && return -1 + + diff -q -u $img $img1 + res=$? + + rm -f $img $img1 + return $res +} + +test_user_io() +{ + local dev="$1" + + __test_user_io $dev 1 512 > "$FULL" 2>&1 + [ -$? -ne 0 ] && echo "FAIL" + + __test_user_io $dev 1 511 > "$FULL" 2>&1 + [ -$? -ne 0 ] && echo "FAIL" + + __test_user_io $dev 1 513 > "$FULL" 2>&1 + [ -$? -ne 0 ] && echo "FAIL" + + __test_user_io $dev 511 1024 > "$FULL" 2>&1 + [ -$? -ne 0 ] && echo "FAIL" + + __test_user_io $dev 511 1023 > "$FULL" 2>&1 + [ -$? -ne 0 ] && echo "FAIL" + + __test_user_io $dev 511 1025 > "$FULL" 2>&1 + [ -$? -ne 0 ] && echo "FAIL" +} + +test() { + echo "Running ${TEST_NAME}" + + modprobe nvmet + modprobe nvme-loop + + local port + local nvmedev + local loop_dev + local file_path="$TMPDIR/img" + local subsys_name="blktests-subsystem-1" + + truncate -s 1G "${file_path}" + + loop_dev="$(losetup -f --show "${file_path}")" + + _create_nvmet_subsystem "${subsys_name}" "${loop_dev}" \ + "91fdba0d-f87b-4c25-b80f-db7be1418b9e" + port="$(_create_nvmet_port "loop")" + _add_nvmet_subsys_to_port "${port}" "${subsys_name}" + + nvme connect -t loop -n "${subsys_name}" + + nvmedev="$(_find_nvme_loop_dev)" + cat "/sys/block/${nvmedev}n1/uuid" + cat "/sys/block/${nvmedev}n1/wwid" + + test_user_io "/dev/${nvmedev}n1" + + nvme disconnect -n "${subsys_name}" >> "$FULL" 2>&1 + + _remove_nvmet_subsystem_from_port "${port}" "${subsys_name}" + _remove_nvmet_subsystem "${subsys_name}" + _remove_nvmet_port "${port}" + + losetup -d "${loop_dev}" + + rm "${file_path}" + + modprobe -r nvme-loop + modprobe -r nvmet + + echo "Test complete" +}
tests/block/029.out new file +4 -0
@@ -0,0 +1,4 @@ +Running block/029 +91fdba0d-f87b-4c25-b80f-db7be1418b9e +uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e +Test complete
Signature · 1 line
2.9.5
Quoted 18 lines · Ming Lei
Add one test to cover changes on block passthrough IO interface, such as
blk_rq_map_user(),blk_rq_map_user_iov(),blk_rq_unmap_user()andblk_rq_map_kern().Signed-off-by Ming Lei <[email protected]>--- tests/block/029 | 111 ++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/block/029.out | 4 ++ 2 files changed, 115 insertions(+) create mode 100755 tests/block/029 create mode 100644 tests/block/029.outtests/block/029 new file +0
-0
tests/block/029 line 5
Quoted 5 lines
tests/block/029 new file +5
-0@@ -0,0 +1,111 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0+ +# Copyright (c) 2019 Ming Lei <[email protected]> +# +# Test userspace IO on NVMe loop device
This is still missing a reference to the patch it's testing.
tests/block/029 line 7
Quoted 1 line
tests/block/029 new file +1
-0+. tests/nvme/rc
Shouldn't this be in the nvme group?
Quoted 5 lines
tests/block/029 new file +5
-0+DESCRIPTION="test userspace IO via nvme-cli read/write interface" +QUICK=1 + +requires() { + _have_program nvme && _have_modules loop nvme-loop nvmet && \
tests/block/029 line 23
Quoted 10 lines
tests/block/029 new file +10
-0+ _have_configfs +} + +__test_user_io() +{ + local disk="$1" + local start=$2 + local cnt=$3 + + local bs=$(blockdev --getss $disk)
This still has a ton of missing quoting and shellcheck errors.
I fixed all of this and pushed to
https://github.com/osandov/blktests/tree/user-io. Let me know if this looks fine and I'll push it to master.
Quoted 49 lines · Omar Sandoval
Quoted 18 lines · Ming Lei
Add one test to cover changes on block passthrough IO interface, such as
blk_rq_map_user(),blk_rq_map_user_iov(),blk_rq_unmap_user()andblk_rq_map_kern().Signed-off-by Ming Lei <[email protected]>--- tests/block/029 | 111 ++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/block/029.out | 4 ++ 2 files changed, 115 insertions(+) create mode 100755 tests/block/029 create mode 100644 tests/block/029.outtests/block/029 new file +0
-0tests/block/029 line 5
Quoted 5 lines
tests/block/029 new file +5
-0@@ -0,0 +1,111 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0+ +# Copyright (c) 2019 Ming Lei <[email protected]> +# +# Test userspace IO on NVMe loop deviceThis is still missing a reference to the patch it's testing.
tests/block/029 line 7
Quoted 1 line
tests/block/029 new file +1
-0+. tests/nvme/rcShouldn't this be in the nvme group?
Quoted 5 lines
tests/block/029 new file +5
-0+DESCRIPTION="test userspace IO via nvme-cli read/write interface" +QUICK=1 + +requires() { + _have_program nvme && _have_modules loop nvme-loop nvmet && \tests/block/029 line 23
Quoted 10 lines
tests/block/029 new file +10
-0+ _have_configfs +} + +__test_user_io() +{ + local disk="$1" + local start=$2 + local cnt=$3 + + local bs=$(blockdev --getss $disk)This still has a ton of missing quoting and shellcheck errors.
Quoted 3 lines
I fixed all of this and pushed to
https://github.com/osandov/blktests/tree/user-io. Let me know if this looks fine and I'll push it to master.
Ping.
Quoted 50 lines · Omar Sandoval
Quoted 49 lines · Omar Sandoval
Quoted 18 lines · Ming Lei
Add one test to cover changes on block passthrough IO interface, such as
blk_rq_map_user(),blk_rq_map_user_iov(),blk_rq_unmap_user()andblk_rq_map_kern().Signed-off-by Ming Lei <[email protected]>--- tests/block/029 | 111 ++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/block/029.out | 4 ++ 2 files changed, 115 insertions(+) create mode 100755 tests/block/029 create mode 100644 tests/block/029.outtests/block/029 new file +0
-0tests/block/029 line 5
Quoted 5 lines
tests/block/029 new file +5
-0@@ -0,0 +1,111 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0+ +# Copyright (c) 2019 Ming Lei <[email protected]> +# +# Test userspace IO on NVMe loop deviceThis is still missing a reference to the patch it's testing.
tests/block/029 line 7
Quoted 1 line
tests/block/029 new file +1
-0+. tests/nvme/rcShouldn't this be in the nvme group?
Quoted 5 lines
tests/block/029 new file +5
-0+DESCRIPTION="test userspace IO via nvme-cli read/write interface" +QUICK=1 + +requires() { + _have_program nvme && _have_modules loop nvme-loop nvmet && \tests/block/029 line 23
Quoted 10 lines
tests/block/029 new file +10
-0+ _have_configfs +} + +__test_user_io() +{ + local disk="$1" + local start=$2 + local cnt=$3 + + local bs=$(blockdev --getss $disk)This still has a ton of missing quoting and shellcheck errors.
Quoted 3 lines
Quoted 3 lines
I fixed all of this and pushed to
https://github.com/osandov/blktests/tree/user-io. Let me know if this looks fine and I'll push it to master.
Yeah, it is fine for me.
Thanks,
Ming
Omar Sandoval
AppliedQuoted 51 lines · Ming Lei
Quoted 50 lines · Omar Sandoval
Quoted 49 lines · Omar Sandoval
Quoted 18 lines · Ming Lei
Add one test to cover changes on block passthrough IO interface, such as
blk_rq_map_user(),blk_rq_map_user_iov(),blk_rq_unmap_user()andblk_rq_map_kern().Signed-off-by Ming Lei <[email protected]>--- tests/block/029 | 111 ++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/block/029.out | 4 ++ 2 files changed, 115 insertions(+) create mode 100755 tests/block/029 create mode 100644 tests/block/029.outtests/block/029 new file +0
-0tests/block/029 line 5
Quoted 5 lines
tests/block/029 new file +5
-0@@ -0,0 +1,111 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0+ +# Copyright (c) 2019 Ming Lei <[email protected]> +# +# Test userspace IO on NVMe loop deviceThis is still missing a reference to the patch it's testing.
tests/block/029 line 7
Quoted 1 line
tests/block/029 new file +1
-0+. tests/nvme/rcShouldn't this be in the nvme group?
Quoted 5 lines
tests/block/029 new file +5
-0+DESCRIPTION="test userspace IO via nvme-cli read/write interface" +QUICK=1 + +requires() { + _have_program nvme && _have_modules loop nvme-loop nvmet && \tests/block/029 line 23
Quoted 10 lines
tests/block/029 new file +10
-0+ _have_configfs +} + +__test_user_io() +{ + local disk="$1" + local start=$2 + local cnt=$3 + + local bs=$(blockdev --getss $disk)This still has a ton of missing quoting and shellcheck errors.
Quoted 6 lines
Quoted 3 lines
Quoted 3 lines
I fixed all of this and pushed to
https://github.com/osandov/blktests/tree/user-io. Let me know if this looks fine and I'll push it to master.Yeah, it is fine for me.
Thanks, applied.