Skip to contentSkip to conversation

Add new xattr test 532

PATCH In review Ronnie Sahlberg 2 participants 2 messages Mar 5, 2019 – Mar 6, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add new xattr test 532

This test is cloned from 097 but has had all the tests for trusted.* removed.
This makes it possible to use this test on filesystems that can only provide user.* xattrs such as CIFS.

---
 tests/generic/532     | 144 ++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/generic/532.out | 108 +++++++++++++++++++++++++++++++++++++
 tests/generic/group   |   1 +
 3 files changed, 253 insertions(+)
 create mode 100755 tests/generic/532
 create mode 100644 tests/generic/532.out
tests/generic/532 new file +144 -0
new file mode 100755
index 00000000..86adb3a6
@@ -0,0 +1,144 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2000-2004 Silicon Graphics, Inc.  All Rights Reserved.
+# Copyright (c) 2017 Google, Inc.  All Rights Reserved.
+# Copyright (c) 2019 Red Hat Inc.  All Rights Reserved.
+#
+# FS QA Test No. 526. Modified from 097.
+#
+# simple attr tests for user. EAs:
+#  - set
+#  - get
+#  - list
+#  - remove
+# Basic testing.
+#
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1	# failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+file=$TEST_DIR/foo
+
+_cleanup()
+{
+	rm -f $tmp.* $file
+}
+
+getfattr()
+{
+	_getfattr --absolute-names "$@" |& _filter_test_dir
+}
+
+setfattr()
+{
+	$SETFATTR_PROG "$@" |& _filter_test_dir
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/attr
+. ./common/filter
+
+# real QA test starts here
+_supported_fs generic
+_supported_os Linux
+
+_require_test
+_require_attrs
+
+echo -e "\ncreate file foo"
+rm -f $file
+touch $file
+
+echo -e "\nshould be no EAs for foo:"
+getfattr -d $file
+
+echo -e "\nset EA <NOISE,woof>:"
+setfattr -n user.NOISE -v woof $file
+
+echo -e "\nset EA <COLOUR,blue>:"
+setfattr -n user.COLOUR -v blue $file
+
+echo -e "\nset EA <SIZE,small>:"
+setfattr -n user.SIZE -v small $file
+
+echo -e "\nlist the EAs for foo: NOISE, COLOUR, SIZE"
+getfattr -d $file
+
+echo -e "\ncheck the list again for foo"
+getfattr -d $file
+
+echo -e "\nunmount the FS and see if EAs are persistent"
+_test_cycle_mount
+
+echo -e "\ncheck the list again for foo after umount/mount"
+getfattr -d $file
+
+echo -e "\nremove the COLOUR EA on foo"
+setfattr -x user.COLOUR $file
+
+echo -e "\nlist EAs for foo: NOISE, SIZE"
+getfattr -d $file
+
+echo -e "\nget the value of the NOISE EA"
+getfattr -n user.NOISE $file
+
+echo -e "\nget the value of the COLOUR EA which was removed earlier"
+getfattr -n user.COLOUR $file
+
+echo -e "\nget the value of the SIZE EA"
+getfattr -n user.SIZE $file
+
+echo -e "\nlist all the EAs again: NOISE, SIZE"
+getfattr -d $file
+
+echo -e "\nchange the value of the SIZE EA from small to huge"
+setfattr -n user.SIZE -v huge $file
+
+echo -e "\nget the SIZE EA which should now have value huge"
+getfattr -n user.SIZE $file
+
+echo -e "\nlist EAs: NOISE, SIZE"
+getfattr -d $file
+
+echo -e "\nremove the SIZE EA from foo"
+setfattr -x user.SIZE $file
+
+echo -e "\nlist EAs: NOISE (SIZE EA has been removed)"
+getfattr -d $file
+
+echo -e "\ntry removing non-existent EA named woof"
+setfattr -x user.WOOF $file
+
+echo -e "\ntry removing already removed EA SIZE"
+setfattr -x user.SIZE $file
+
+echo -e "\nlist EAs: NOISE"
+getfattr -d $file
+
+echo -e "\ntry removing already removed EA COLOUR"
+setfattr -x user.COLOUR $file
+
+echo -e "\nlist EAs: NOISE"
+getfattr -d $file
+
+echo -e "\nremove remaining EA NOISE"
+setfattr -x user.NOISE $file
+
+echo -e "\nlist EAs: should be no EAs left now"
+getfattr -d $file
+
+echo -e "\nunmount the FS and see if EAs are persistent"
+_test_cycle_mount
+
+echo -e "\nlist EAs: should still be no EAs left"
+getfattr -d $file
+
+# success, all done
+status=0
+exit
tests/generic/532.out new file +108 -0

108 lines not on this page · raw message

tests/generic/group +1 -0
index 15227b67..14cb479a 100644
@@ -534,3 +534,4 @@
 529 auto quick attr
 530 auto quick unlink
 531 auto quick unlink
+532 attr auto quick
Signature · 1 line
2.13.6
#1 lore raw
Quoted 4 lines · Ronnie Sahlberg

This test is cloned from 097 but has had all the tests for trusted.* removed.
This makes it possible to use this test on filesystems that can only provide user.* xattrs such as CIFS.

Looks mostly OK, Ronnie. Couple of minor things below.

Quoted 15 lines
---
 tests/generic/532     | 144 ++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/generic/532.out | 108 +++++++++++++++++++++++++++++++++++++
 tests/generic/group   |   1 +
 3 files changed, 253 insertions(+)
 create mode 100755 tests/generic/532
 create mode 100644 tests/generic/532.out
tests/generic/532 new file +0 -0
new file mode 100755
index 00000000..86adb3a6

tests/generic/532 line 7

Quoted 7 lines
tests/generic/532 new file +7 -0
@@ -0,0 +1,144 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2000-2004 Silicon Graphics, Inc.  All Rights Reserved.
+# Copyright (c) 2017 Google, Inc.  All Rights Reserved.
+# Copyright (c) 2019 Red Hat Inc.  All Rights Reserved.
+#
+# FS QA Test No. 526. Modified from 097.

Put the "Modified from 097" in the long description below.

tests/generic/532 line 14

Quoted 7 lines
tests/generic/532 new file +7 -0
+#
+# simple attr tests for user. EAs:
+#  - set
+#  - get
+#  - list
+#  - remove
+# Basic testing.

i.e. This is about all that is necessary:

# FS QA Test No. generic/526.
#
# Simple attr smoke tests for user EAs, dereived from generic/097.

tests/generic/532 line 25

Quoted 11 lines
tests/generic/532 new file +11 -0
+#
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1	# failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+file=$TEST_DIR/foo

Usual thing to do here with test files on the TEST_DIR is to append the test number to them and then leave them hanging around.

tests/generic/532 line 30

Quoted 5 lines
tests/generic/532 new file +5 -0
+
+_cleanup()
+{
+	rm -f $tmp.* $file
+}

i.e.

file=$TEST_DIR/foo.$seq

_cleanup()

{
	cd /
	rm -f $tmp.*
}

I think the test is also missing a:

rm -f $seqres.full

as part of the test initialisation.

tests/generic/532 line 56

Quoted 3 lines
tests/generic/532 new file +3 -0
+echo -e "\ncreate file foo"
+rm -f $file
+touch $file

because the file is removed at the start of the test anyway.

tests/generic/group line 537

Quoted 7 lines
tests/generic/group +1 -0
@@ -534,3 +534,4 @@
 529 auto quick attr
 530 auto quick unlink
 531 auto quick unlink
+532 attr auto quick

"auto quick attr" so the group order list is consistent with most of the other lines in the file...

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]