staging: iio: Line over 80 characters
Subsystems (4)
PATCH 1/1 staging: iio: Line over 80 characters
Fix line over 80 characters to get rid of checkpatch warning
--- drivers/staging/iio/addac/adt7316.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/iio/addac/adt7316.c +2 -1
@@ -2155,7 +2155,8 @@ int adt7316_probe(struct device *dev, struct adt7316_bus *bus,else chip->dac_bits =8 ; - chip->ldac_pin =devm_gpiod_get_optional (dev,"adi,ldac" ,GPIOD_OUT_LOW ); + chip->ldac_pin =devm_gpiod_get_optional (dev, +"adi,ldac" ,GPIOD_OUT_LOW );if (IS_ERR (chip->ldac_pin)) { ret =PTR_ERR (chip->ldac_pin);dev_err (dev,"Failed to request ldac GPIO: %d\n" , ret);
Signature · 1 line
2.7.4
Quoted 12 lines · Daniela Mormocea
Fix line over 80 characters to get rid of checkpatch warning
Signed-off-by Daniela Mormocea <[email protected]>--- drivers/staging/iio/addac/adt7316.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/iio/addac/adt7316.c +0
-0
drivers/staging/iio/addac/adt7316.c int adt7316_probe(struct device *dev, struct adt7316_bus *bus, · line 2159
Quoted 6 lines
drivers/staging/iio/addac/adt7316.c +2
-1@@ -2155,7 +2155,8 @@ int adt7316_probe(struct device *dev, struct adt7316_bus *bus,else chip->dac_bits =8 ; - chip->ldac_pin =devm_gpiod_get_optional (dev,"adi,ldac" ,GPIOD_OUT_LOW ); + chip->ldac_pin =devm_gpiod_get_optional (dev, +"adi,ldac" ,GPIOD_OUT_LOW );
Shouldn't this be:
chip->ldac_pin = devm_gpiod_get_optional(dev, "adi,ldac", GPIOD_OUT_LOW);
?
thanks,
greg k-h
Quoted 25 lines · Greg Kroah-Hartman
Review
Quoted 8 lines · Daniela Mormocea
Fix line over 80 characters to get rid of checkpatch warning
Signed-off-by Daniela Mormocea <[email protected] <javascript:>>---
drivers/staging/iio/addac/adt7316.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/staging/iio/addac/adt7316.cdrivers/staging/iio/addac/adt7316.c int adt7316_probe(struct device *dev, struct
Quoted 4 lines
index 6f7891b..be2dfdb 100644
drivers/staging/iio/addac/adt7316.c +0
-0@@ -2155,7 +2155,8 @@ int adt7316_probe(struct device *dev, struct
adt7316_bus*bus,drivers/staging/iio/addac/adt7316.c int adt7316_probe(struct device *dev, struct adt7316_bus *bus,
Quoted 4 lines
drivers/staging/iio/addac/adt7316.c +0
-1else chip->dac_bits =8 ; - chip->ldac_pin = devm_gpiod_get_optional(dev, "adi,ldac",
GPIOD_OUT_LOW);drivers/staging/iio/addac/adt7316.c int adt7316_probe(struct device *dev, struct · line 2159
Quoted 2 lines
drivers/staging/iio/addac/adt7316.c +2
-0+ chip->ldac_pin = devm_gpiod_get_optional(dev, + "adi,ldac",
GPIOD_OUT_LOW);
Quoted 9 lines
Shouldn't this be:
chip->ldac_pin = devm_gpiod_get_optional(dev, "adi,ldac", GPIOD_OUT_LOW);?
thanks,
greg k-h
oops.. yes.. I will revert the changes and mail it back