Skip to contentSkip to conversation

ipsec-secgw: fix AES-CTR block size in legacy mode

PATCH Applied Fan Zhang 3 participants 4 messages Mar 5, 2019 – Mar 19, 2019

lore
Share & tools
lore

Fan Zhang

author
#0 lore raw

PATCH 1/1 ipsec-secgw: fix AES-CTR block size in legacy mode

This patch fixes the incorrect block size for AES-CTR in legacy mode. Originally, wrong block size will cause esp_inbound() drop AES-CTR encrypted packets if the payload sizes not equal to multiple times of 16.

Fixes 4470c22de2e1 ("examples/ipsec-secgw: add AES-CTR")
---
 examples/ipsec-secgw/sa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
examples/ipsec-secgw/sa.c +1 -1
index 414fcd26c..93e3620bc 100644
@@ -80,7 +80,7 @@ const struct supported_cipher_algo cipher_algos[] = {
 		.keyword = "aes-128-ctr",
 		.algo = RTE_CRYPTO_CIPHER_AES_CTR,
 		.iv_len = 8,
-		.block_size = 16, /* XXX AESNI MB limition, should be 4 */
+		.block_size = 4,
 		.key_len = 20
 	},
 	{
Signature · 1 line
2.14.5
Acked-by on v1 1/1
#1 lore raw
Quoted 28 lines

-----Original Message-----
From: Zhang, Roy Fan
Sent: Tuesday, March 5, 2019 2:41 PM
To: [email protected]
Cc: [email protected]; Zhang, Roy Fan <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode

This patch fixes the incorrect block size for AES-CTR in legacy mode. Originally, wrong block size will cause esp_inbound() drop AES-CTR encrypted packets if the payload sizes not equal to multiple times of 16.

Fixes 4470c22de2e1 ("examples/ipsec-secgw: add AES-CTR")
---
 examples/ipsec-secgw/sa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
examples/ipsec-secgw/sa.c +0 -0
index 414fcd26c..93e3620bc 100644

examples/ipsec-secgw/sa.c const struct supported_cipher_algo cipher_algos[] = {

Quoted 9 lines
examples/ipsec-secgw/sa.c +1 -2
@@ -80,7 +80,7 @@ const struct supported_cipher_algo cipher_algos[] = {
 		.keyword = "aes-128-ctr",
 		.algo = RTE_CRYPTO_CIPHER_AES_CTR,
 		.iv_len = 8,
-		.block_size = 16, /* XXX AESNI MB limition, should be 4 */
+		.block_size = 4,
 		.key_len = 20
 	},
 	{
--
Quoted 1 line

2.14.5

Acked-by on v1 1/1
#2 lore raw
In reply to Fan Zhang
Quoted 18 lines · Fan Zhang

This patch fixes the incorrect block size for AES-CTR in legacy mode. Originally, wrong block size will cause esp_inbound() drop AES-CTR encrypted packets if the payload sizes not equal to multiple times of 16.

Fixes 4470c22de2e1 ("examples/ipsec-secgw: add AES-CTR")
---
  examples/ipsec-secgw/sa.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
examples/ipsec-secgw/sa.c +0 -0
index 414fcd26c..93e3620bc 100644

examples/ipsec-secgw/sa.c const struct supported_cipher_algo cipher_algos[] = { · line 86

Quoted 8 lines
examples/ipsec-secgw/sa.c +1 -1
@@ -80,7 +80,7 @@ const struct supported_cipher_algo cipher_algos[] = {
  		.keyword = "aes-128-ctr",
  		.algo = RTE_CRYPTO_CIPHER_AES_CTR,
  		.iv_len = 8,
-		.block_size = 16, /* XXX AESNI MB limition, should be 4 */
+		.block_size = 4,
  		.key_len = 20
  	},
  	{

Title should be examples/ipsec-secgw:...
Will correct it while merging

Applied
#3 lore raw
Quoted 30 lines · Akhil Goyal
Quoted 18 lines · Fan Zhang

This patch fixes the incorrect block size for AES-CTR in legacy mode. Originally, wrong block size will cause esp_inbound() drop AES-CTR encrypted packets if the payload sizes not equal to multiple times of 16.

Fixes 4470c22de2e1 ("examples/ipsec-secgw: add AES-CTR")
---
   examples/ipsec-secgw/sa.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
examples/ipsec-secgw/sa.c +0 -0
index 414fcd26c..93e3620bc 100644

examples/ipsec-secgw/sa.c const struct supported_cipher_algo cipher_algos[] = { · line 86

Quoted 8 lines
examples/ipsec-secgw/sa.c +1 -1
@@ -80,7 +80,7 @@ const struct supported_cipher_algo cipher_algos[] = {
   		.keyword = "aes-128-ctr",
   		.algo = RTE_CRYPTO_CIPHER_AES_CTR,
   		.iv_len = 8,
-		.block_size = 16, /* XXX AESNI MB limition, should be 4 */
+		.block_size = 4,
   		.key_len = 20
   	},
   	{
Quoted 2 lines

Title should be examples/ipsec-secgw:...
Will correct it while merging

Applied to dpdk-next-crypto

Thanks.