syscalls: add rt_tgsigqueueinfo() test-case
PATCH v2 1/1 syscalls: add rt_tgsigqueueinfo() test-case
This tests the rt_tgsigqueueinfo() syscall used to queue a signal and data to the single thread specified by the combination of tgid, a thread group ID, and tid, a thread in that thread group.
Also this test implement 3 cases differing on the basis of signal sender:
- Sender and receiver is the same thread.
- Sender is parent of the thread.
- Sender is different thread.
---
Changes in v2:
1. Add following cases where the sender differs:
- parent -> thread
- thread1 -> thread2
2. Add verification of signal and data delivered by rt_tgsigqueueinfo().
runtest/syscalls | 1 + .../kernel/syscalls/rt_tgsigqueueinfo/.gitignore | 1 + .../kernel/syscalls/rt_tgsigqueueinfo/Makefile | 10 ++ .../rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c | 200 +++++++++++++++++++++ 4 files changed, 212 insertions(+) create mode 100644 testcases/kernel/syscalls/rt_tgsigqueueinfo/.gitignore create mode 100644 testcases/kernel/syscalls/rt_tgsigqueueinfo/Makefile create mode 100644 testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c
runtest/syscalls +1 -0
@@ -999,6 +999,7 @@ rt_sigprocmask01 rt_sigprocmask01 rt_sigprocmask02 rt_sigprocmask02 rt_sigqueueinfo01 rt_sigqueueinfo01 rt_sigsuspend01 rt_sigsuspend01 +rt_tgsigqueueinfo01 rt_tgsigqueueinfo01 sbrk01 sbrk01 sbrk02 sbrk02
testcases/kernel/syscalls/rt_tgsigqueueinfo/.gitignore new file +1 -0
@@ -0,0 +1 @@ +rt_tgsigqueueinfo01
testcases/kernel/syscalls/rt_tgsigqueueinfo/Makefile new file +10 -0
@@ -0,0 +1,10 @@ +# Copyright (c) 2019 - Linaro Limited. All rights reserved. +# SPDX-License-Identifier: GPL-2.0-or-later + +top_srcdir ?= ../../../.. + +rt_tgsigqueueinfo01: CFLAGS+=-pthread + +include $(top_srcdir)/include/mk/testcases.mk + +include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +200 -0
200 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v2 1/1 syscalls: add rt_tgsigqueueinfo() test-case
Hi!
Quoted 25 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +19
-0@@ -0,0 +1,200 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Copyright (c) 2019 Linaro Limited. All rights reserved. +* Author: Sumit Garg <[email protected]> +*/ + +/* +* Test rt_tgsigqueueinfo +* +* This tests the rt_tgsigqueueinfo() syscall. It sends the signal and data +* to the single thread specified by the combination of tgid, a thread group +* ID, and tid, a thread in that thread group. +* +* Also this implement 3 tests differing on the basis of signal sender: +* - Sender and receiver is the same thread. +* - Sender is parent of the thread. +* - Sender is different thread. +*/ +
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 29
Quoted 10 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +10
-0+#define _GNU_SOURCE +#include <err.h> +#include <string.h> +#include <pthread.h> +#include "tst_safe_pthread.h" +#include "tst_test.h" +#include "lapi/syscalls.h" + +static char sigval_send[] ="rt_tgsigqueueinfo data" ; +static int signum_rcv;
This has to be volatile, otherwise compiler has no idea that the value could be changed asynchronically from within the signal handler and may miscompile the loop (when optimalizations are enabled) that waits for the signal arrival.
Quoted 5 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +5
-0+static char sigval_rcv[128 ]; + +static pthread_cond_t sigusr1_cond =PTHREAD_COND_INITIALIZER ; +static pthread_mutex_t sigusr1_mutex =PTHREAD_MUTEX_INITIALIZER ; +
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 44
Quoted 10 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +10
-0+static pthread_cond_t tid_cond =PTHREAD_COND_INITIALIZER ; +static pthread_mutex_t tid_mutex =PTHREAD_MUTEX_INITIALIZER ; + +static void sigusr1_handler (int signum,siginfo_t *uinfo, + void *p LTP_ATTRIBUTE_UNUSED) +{ +char *rcv = uinfo->_sifields._rt.si_sigval.sival_ptr; + +if (rcv) +strcpy (sigval_rcv, rcv);
I do wonder if we need to really copy the data here. If we send a pointer shouldn't be enough to store the pointer and check it against sigval_send later on?
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 47
Quoted 3 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +3
-0+ signum_rcv = signum; + +pthread_cond_broadcast (&sigusr1_cond);
It's not safe to call anything but a couple of signal-async-safe functions in the signal handler, see:
http://www.man7.org/linux/man-pages/man7/signal-safety.7.html
I guess that the easiest solution here would be doing something as:
while (!signum_rcv) usleep(1000);
Instead of the pthread_cond_wait().
Quoted 17 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +17
-0+} + +void *tfunc_self(void *arg LTP_ATTRIBUTE_UNUSED) +{ +siginfo_t uinfo; + + signum_rcv =0 ; +memset (sigval_rcv,0 ,sizeof (sigval_rcv)); + + uinfo.si_errno =0 ; + uinfo.si_code =SI_QUEUE ; + uinfo._sifields._rt.si_sigval.sival_ptr = sigval_send; + +TEST (tst_syscall (__NR_rt_tgsigqueueinfo,getpid (), +syscall (__NR_gettid),SIGUSR1 , &uinfo)); +if (TST_RET ) +tst_brk (TFAIL |TTERRNO ,"rt_tgsigqueueinfo failed" );
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 74
Quoted 10 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +10
-0+ +pthread_mutex_lock (&sigusr1_mutex); +while (!signum_rcv) +pthread_cond_wait (&sigusr1_cond, &sigusr1_mutex); +pthread_mutex_unlock (&sigusr1_mutex); + +if ((signum_rcv ==SIGUSR1 ) && !strcmp (sigval_send, sigval_rcv)) +tst_res (TPASS ,"Test signal to self succeeded" ); +else +tst_res (TFAIL ,"Test failed" );
It wouldn't harm to be a bit more verbose here. I.e. tell the user what exactly was wrong.
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 75
Quoted 1 line
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +1
-0+return NULL ;
There is a nice trick we use in LTP, if you do return arg; here you can drop the ATTRIBUTE_UNUSED.
Quoted 11 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +11
-0+} + +static void verify_signal_self (void ) +{ +pthread_t pt; + +SAFE_PTHREAD_CREATE (&pt,NULL , tfunc_self,NULL ); + +SAFE_PTHREAD_JOIN (pt,NULL ); +} +
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 97
Quoted 10 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +10
-0+void *t1func (void *arg) +{ +pid_t *tid = arg; + + *tid =syscall (__NR_gettid); + +pthread_cond_broadcast (&tid_cond); + + signum_rcv =0 ; +memset (sigval_rcv,0 ,sizeof (sigval_rcv));
This initialization has to be done before we notify the parent thread, otherwise there is a race.
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 107
Quoted 9 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +9
-0+pthread_mutex_lock (&sigusr1_mutex); +while (!signum_rcv) +pthread_cond_wait (&sigusr1_cond, &sigusr1_mutex); +pthread_mutex_unlock (&sigusr1_mutex); + +if ((signum_rcv ==SIGUSR1 ) && !strcmp (sigval_send, sigval_rcv)) +tst_res (TPASS ,"Test signal to different thread succeeded" ); +else +tst_res (TFAIL ,"Test failed" );
Here as well, a bit more verbose, maybe we should put the code into a common check function, since it's the same as in the self function.
Quoted 5 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +5
-0+return NULL ; +} + +static void verify_signal_parent_thread (void ) +{
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 123
Quoted 10 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +10
-0+pid_t tid =-1 ; +pthread_t pt; +siginfo_t uinfo; + +SAFE_PTHREAD_CREATE (&pt,NULL , t1func, &tid); + +pthread_mutex_lock (&tid_mutex); +while (tid ==-1 ) +pthread_cond_wait (&tid_cond, &tid_mutex); +pthread_mutex_unlock (&tid_mutex);
We do have checkpoint library in LTP that is much easier to use than this, see:
Quoted 32 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +32
-0+ uinfo.si_errno =0 ; + uinfo.si_code =SI_QUEUE ; + uinfo._sifields._rt.si_sigval.sival_ptr = sigval_send; + +TEST (tst_syscall (__NR_rt_tgsigqueueinfo,getpid (), + tid,SIGUSR1 , &uinfo)); +if (TST_RET ) +tst_brk (TFAIL |TTERRNO ,"rt_tgsigqueueinfo failed" ); + +SAFE_PTHREAD_JOIN (pt,NULL ); +} + +void *t2func (void *arg) +{ +pid_t *tid = arg; +siginfo_t uinfo; + + uinfo.si_errno =0 ; + uinfo.si_code =SI_QUEUE ; + uinfo._sifields._rt.si_sigval.sival_ptr = sigval_send; + +TEST (tst_syscall (__NR_rt_tgsigqueueinfo,getpid (), + *tid,SIGUSR1 , &uinfo)); +if (TST_RET ) +tst_brk (TFAIL |TTERRNO ,"rt_tgsigqueueinfo failed" ); + +return NULL ; +} + +static void verify_signal_inter_thread (void ) +{ +pid_t tid =-1 ;
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 166
Quoted 10 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +10
-0+pthread_t pt1, pt2; + +SAFE_PTHREAD_CREATE (&pt1,NULL , t1func, &tid); + +pthread_mutex_lock (&tid_mutex); +while (tid ==-1 ) +pthread_cond_wait (&tid_cond, &tid_mutex); +pthread_mutex_unlock (&tid_mutex); + +SAFE_PTHREAD_CREATE (&pt2,NULL , t2func, &tid);
That's very minor but maybe it would be a bit more readable if we named the t1func and t2func sender_func and receiver_func or anything that hints the function purpose.
Quoted 23 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +23
-0+SAFE_PTHREAD_JOIN (pt2,NULL ); + +SAFE_PTHREAD_JOIN (pt1,NULL ); +} + +static struct tcase { +void (*tfunc)(void ); +} tcases[] = { + {&verify_signal_self}, + {&verify_signal_parent_thread}, + {&verify_signal_inter_thread}, +}; + +static void run (unsigned int i) +{ + tcases[i].tfunc (); +} + +static void setup (void ) +{ +struct sigaction sigusr1 = { + .sa_flags =SA_SIGINFO , + .sa_sigaction = sigusr1_handler,
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 200
Quoted 10 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +10
-0+ }; + +SAFE_SIGACTION (SIGUSR1 , &sigusr1,NULL ); +} + +static struct tst_test test = { + .tcnt =ARRAY_SIZE (tcases), + .setup = setup, + .test = run, +};
Otherwise it looks good.
Signature · 2 lines
Cyril Hrubis [email protected]
PATCH v2 1/1 syscalls: add rt_tgsigqueueinfo() test-case
Thanks for the review.
Quoted 34 lines · Cyril Hrubis
Hi!
Quoted 32 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +26
-0@@ -0,0 +1,200 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Copyright (c) 2019 Linaro Limited. All rights reserved. +* Author: Sumit Garg <[email protected]> +*/ + +/* +* Test rt_tgsigqueueinfo +* +* This tests the rt_tgsigqueueinfo() syscall. It sends the signal and data +* to the single thread specified by the combination of tgid, a thread group +* ID, and tid, a thread in that thread group. +* +* Also this implement 3 tests differing on the basis of signal sender: +* - Sender and receiver is the same thread. +* - Sender is parent of the thread. +* - Sender is different thread. +*/ + +#define _GNU_SOURCE +#include <err.h> +#include <string.h> +#include <pthread.h> +#include "tst_safe_pthread.h" +#include "tst_test.h" +#include "lapi/syscalls.h"
Quoted 9 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 29
Quoted 3 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +3
-0+ +static char sigval_send[] ="rt_tgsigqueueinfo data" ; +static int signum_rcv;This has to be volatile, otherwise compiler has no idea that the value could be changed asynchronically from within the signal handler and may miscompile the loop (when optimalizations are enabled) that waits for the signal arrival.
Agree, will make it volatile.
Quoted 11 lines
Quoted 11 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +11
-0+static char sigval_rcv[128 ]; + +static pthread_cond_t sigusr1_cond =PTHREAD_COND_INITIALIZER ; +static pthread_mutex_t sigusr1_mutex =PTHREAD_MUTEX_INITIALIZER ; + +static pthread_cond_t tid_cond =PTHREAD_COND_INITIALIZER ; +static pthread_mutex_t tid_mutex =PTHREAD_MUTEX_INITIALIZER ; + +static void sigusr1_handler (int signum,siginfo_t *uinfo, + void *p LTP_ATTRIBUTE_UNUSED) +{
Quoted 9 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 44
Quoted 4 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +4
-0+char *rcv = uinfo->_sifields._rt.si_sigval.sival_ptr; + +if (rcv) +strcpy (sigval_rcv, rcv);I do wonder if we need to really copy the data here. If we send a pointer shouldn't be enough to store the pointer and check it against
sigval_sendlater on?
Hmm, will assign pointer only rather than copy data.
Quoted 9 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 47
Quoted 3 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +3
-0+ signum_rcv = signum; + +pthread_cond_broadcast (&sigusr1_cond);It's not safe to call anything but a couple of signal-async-safe functions in the signal handler, see:
http://www.man7.org/linux/man-pages/man7/signal-safety.7.html
Thanks for this info.
Quoted 7 lines
I guess that the easiest solution here would be doing something as:
while (!signum_rcv) usleep(1000);Instead of the
pthread_cond_wait().
Ok will use this approach instead.
Quoted 22 lines
Quoted 22 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +22
-0+} + +void *tfunc_self(void *arg LTP_ATTRIBUTE_UNUSED) +{ +siginfo_t uinfo; + + signum_rcv =0 ; +memset (sigval_rcv,0 ,sizeof (sigval_rcv)); + + uinfo.si_errno =0 ; + uinfo.si_code =SI_QUEUE ; + uinfo._sifields._rt.si_sigval.sival_ptr = sigval_send; + +TEST (tst_syscall (__NR_rt_tgsigqueueinfo,getpid (), +syscall (__NR_gettid),SIGUSR1 , &uinfo)); +if (TST_RET ) +tst_brk (TFAIL |TTERRNO ,"rt_tgsigqueueinfo failed" ); + +pthread_mutex_lock (&sigusr1_mutex); +while (!signum_rcv) +pthread_cond_wait (&sigusr1_cond, &sigusr1_mutex); +pthread_mutex_unlock (&sigusr1_mutex);
Quoted 9 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 74
Quoted 5 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +5
-0+ +if ((signum_rcv ==SIGUSR1 ) && !strcmp (sigval_send, sigval_rcv)) +tst_res (TPASS ,"Test signal to self succeeded" ); +else +tst_res (TFAIL ,"Test failed" );It wouldn't harm to be a bit more verbose here. I.e. tell the user what exactly was wrong.
Will update failure message as follows:
tst_res(TFAIL, "Failed to deliver signal/data to self thread");
Quoted 5 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 75
Quoted 1 line
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +1
-0+return NULL ;There is a nice trick we use in LTP, if you do return arg; here you can drop the
ATTRIBUTE_UNUSED.
Ok.
Quoted 16 lines
Quoted 16 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +16
-0+} + +static void verify_signal_self (void ) +{ +pthread_t pt; + +SAFE_PTHREAD_CREATE (&pt,NULL , tfunc_self,NULL ); + +SAFE_PTHREAD_JOIN (pt,NULL ); +} + +void *t1func (void *arg) +{ +pid_t *tid = arg; + + *tid =syscall (__NR_gettid);
Quoted 9 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 97
Quoted 5 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +5
-0+ +pthread_cond_broadcast (&tid_cond); + + signum_rcv =0 ; +memset (sigval_rcv,0 ,sizeof (sigval_rcv));This initialization has to be done before we notify the parent thread, otherwise there is a race.
Good catch. Will move the initialization before notify.
Quoted 10 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 107
Quoted 9 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +9
-0+pthread_mutex_lock (&sigusr1_mutex); +while (!signum_rcv) +pthread_cond_wait (&sigusr1_cond, &sigusr1_mutex); +pthread_mutex_unlock (&sigusr1_mutex); + +if ((signum_rcv ==SIGUSR1 ) && !strcmp (sigval_send, sigval_rcv)) +tst_res (TPASS ,"Test signal to different thread succeeded" ); +else +tst_res (TFAIL ,"Test failed" );
Quoted 3 lines
Here as well, a bit more verbose, maybe we should put the code into a common check function, since it's the same as in the self function.
Check is same but to provide case specific info message is different as:
tst_res(TFAIL, "Failed to deliver signal/data to different thread");
Quoted 19 lines
Quoted 5 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +5
-0+return NULL ; +} + +static void verify_signal_parent_thread (void ) +{testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 123
Quoted 10 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +10
-0+pid_t tid =-1 ; +pthread_t pt; +siginfo_t uinfo; + +SAFE_PTHREAD_CREATE (&pt,NULL , t1func, &tid); + +pthread_mutex_lock (&tid_mutex); +while (tid ==-1 ) +pthread_cond_wait (&tid_cond, &tid_mutex); +pthread_mutex_unlock (&tid_mutex);We do have checkpoint library in LTP that is much easier to use than this, see:
Quoted 2 lines
Looks good, will use this library instead.
Quoted 38 lines
Quoted 38 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +38
-0+ uinfo.si_errno =0 ; + uinfo.si_code =SI_QUEUE ; + uinfo._sifields._rt.si_sigval.sival_ptr = sigval_send; + +TEST (tst_syscall (__NR_rt_tgsigqueueinfo,getpid (), + tid,SIGUSR1 , &uinfo)); +if (TST_RET ) +tst_brk (TFAIL |TTERRNO ,"rt_tgsigqueueinfo failed" ); + +SAFE_PTHREAD_JOIN (pt,NULL ); +} + +void *t2func (void *arg) +{ +pid_t *tid = arg; +siginfo_t uinfo; + + uinfo.si_errno =0 ; + uinfo.si_code =SI_QUEUE ; + uinfo._sifields._rt.si_sigval.sival_ptr = sigval_send; + +TEST (tst_syscall (__NR_rt_tgsigqueueinfo,getpid (), + *tid,SIGUSR1 , &uinfo)); +if (TST_RET ) +tst_brk (TFAIL |TTERRNO ,"rt_tgsigqueueinfo failed" ); + +return NULL ; +} + +static void verify_signal_inter_thread (void ) +{ +pid_t tid =-1 ; +pthread_t pt1, pt2; + +SAFE_PTHREAD_CREATE (&pt1,NULL , t1func, &tid); + +pthread_mutex_lock (&tid_mutex); +while (tid ==-1 )
Quoted 9 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 166
Quoted 4 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +4
-0+pthread_cond_wait (&tid_cond, &tid_mutex); +pthread_mutex_unlock (&tid_mutex); + +SAFE_PTHREAD_CREATE (&pt2,NULL , t2func, &tid);That's very minor but maybe it would be a bit more readable if we named the t1func and t2func
sender_funcandreceiver_funcor anything that hints the function purpose.
Ok. Also will rename tfunc_self -> send_rcv_func.
-Sumit
Quoted 38 lines
Quoted 23 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +23
-0+SAFE_PTHREAD_JOIN (pt2,NULL ); + +SAFE_PTHREAD_JOIN (pt1,NULL ); +} + +static struct tcase { +void (*tfunc)(void ); +} tcases[] = { + {&verify_signal_self}, + {&verify_signal_parent_thread}, + {&verify_signal_inter_thread}, +}; + +static void run (unsigned int i) +{ + tcases[i].tfunc (); +} + +static void setup (void ) +{ +struct sigaction sigusr1 = { + .sa_flags =SA_SIGINFO , + .sa_sigaction = sigusr1_handler,testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c line 200
Quoted 10 lines
testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c new file +10
-0+ }; + +SAFE_SIGACTION (SIGUSR1 , &sigusr1,NULL ); +} + +static struct tst_test test = { + .tcnt =ARRAY_SIZE (tcases), + .setup = setup, + .test = run, +};Otherwise it looks good.
--
Cyril Hrubis
[email protected]