Skip to contentSkip to conversation

Staging: most: dim2: Fix malformed SPDX-License-Identifier

PATCH Superseded Wentao Cai 3 participants 8 messages Mar 6, 2019 – Mar 7, 2019

Subsystems (2)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Wentao Cai

author
#0 lore raw

PATCH 1/4 Staging: most: dim2: Fix malformed SPDX-License-Identifier

This patch fixes the checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

---
 drivers/staging/most/dim2/errors.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/most/dim2/errors.h +1 -1
index 3487510fbd2f..cbbdaaf5c52d 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * errors.h - Definitions of errors for DIM2 HAL API
  * (MediaLB, Device Interface Macro IP, OS62420)
Signature · 1 line
2.11.0
author
#1 lore raw

PATCH 2/4 Staging: most: dim2: Fix malformed SPDX-License-Identifier

This patch fixes the checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

---
 drivers/staging/most/dim2/hal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/most/dim2/hal.h +1 -1
index e04a5350f134..fca6c22de8a6 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * hal.h - DIM2 HAL interface
  * (MediaLB, Device Interface Macro IP, OS62420)
Signature · 1 line
2.11.0
author
#2 lore raw

PATCH 3/4 Staging: most: dim2: Fix malformed SPDX-License-Identifier

In reply to Wentao Cai

This patch fixes the checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

---
 drivers/staging/most/dim2/reg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/most/dim2/reg.h +1 -1
index 4343a483017e..b0f36c208a57 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * reg.h - Definitions for registers of DIM2
  * (MediaLB, Device Interface Macro IP, OS62420)
Signature · 1 line
2.11.0
author
#3 lore raw

PATCH 4/4 Staging: most: dim2: Fix malformed SPDX-License-Identifier

In reply to Wentao Cai

This patch fixes the checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

---
 drivers/staging/most/dim2/sysfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/most/dim2/sysfs.h +1 -1
index 33756a3bffe2..24277a17cff3 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * sysfs.h - MediaLB sysfs information
  *
Signature · 1 line
2.11.0
#4 lore raw
In reply to Wentao Cai
Quoted 2 lines · Wentao Cai

This patch fixes the checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

Hello,

When you make a series, you should also make a cover letter that gives an overview of what is done in the series. You can find information about how to do this in the tutorial.

Also, previously Greg has asked that patches that add SPDX identifiers be accompanised by subsequent patches that remove existing boilerplate license text, if there is any. So you may want to check on this.

julia

Quoted 26 lines
---
 drivers/staging/most/dim2/errors.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/most/dim2/errors.h +1 -2
index 3487510fbd2f..cbbdaaf5c52d 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * errors.h - Definitions of errors for DIM2 HAL API
  * (MediaLB, Device Interface Macro IP, OS62420)
--

2.11.0

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190306043941.6141-1-etsai042%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

maintainer
#5 lore raw
Quoted 9 lines · Julia Lawall
Quoted 2 lines · Wentao Cai

This patch fixes the checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

Hello,

Quoted 7 lines

When you make a series, you should also make a cover letter that gives an overview of what is done in the series. You can find information about how to do this in the tutorial.

Also, previously Greg has asked that patches that add SPDX identifiers be accompanised by subsequent patches that remove existing boilerplate license text, if there is any. So you may want to check on this.

These files do not have any license boilerplate, I just used the wrong comment character when I did the initial conversion to SPDX a year ago :(

thanks,

greg k-h

#6 lore raw
In reply to Julia Lawall
Quoted 9 lines
Quoted 8 lines

Hello,

When you make a series, you should also make a cover letter that gives an overview of what is done in the series. You can find information about how to do this in the tutorial.

Sorry, I'll resubmit it!

Wentao

maintainer
#7 lore raw
In reply to Wentao Cai
Quoted 7 lines · Wentao Cai

This patch fixes the checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

---
 drivers/staging/most/dim2/errors.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

All 4 of these patches had the same identical subject line, yet they did different things :(

Please make them unique by at least adding the filename to the subject line. See other patches on this mailing list for examples of how to do this.

thanks,

greg k-h