net: hns3: Fix a logical vs bitwise typo
Subsystems (5)
PATCH 1/1 net: hns3: Fix a logical vs bitwise typo
There were a couple logical ORs accidentally mixed in with the bitwise ORs.
Fixes e8149933b1fa ("net: hns3: remove hnae3_get_bit in data path")
Signed-off-by Dan Carpenter <[email protected]>
---
Very recent bug.
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +2 -2
@@ -2321,8 +2321,8 @@ static void hns3_rx_checksum(struct hns3_enet_ring *ring, struct sk_buff *skb,if (!(bd_base_info &BIT (HNS3_RXD_L3L4P_B )))return ; -if (unlikely (l234info & (BIT (HNS3_RXD_L3E_B ) |BIT (HNS3_RXD_L4E_B ) || -BIT (HNS3_RXD_OL3E_B ) || +if (unlikely (l234info & (BIT (HNS3_RXD_L3E_B ) |BIT (HNS3_RXD_L4E_B ) | +BIT (HNS3_RXD_OL3E_B ) |BIT (HNS3_RXD_OL4E_B )))) {u64_stats_update_begin (&ring->syncp); ring->stats.l3l4_csum_err++;
Signature · 1 line
2.17.1
Quoted 2 lines · Dan Carpenter
There were a couple logical ORs accidentally mixed in with the bitwise ORs.
Thanks for the fix.
Reviewed-by Yunsheng Lin <[email protected]>
Quoted 25 lines
Fixes e8149933b1fa ("net: hns3: remove hnae3_get_bit in data path")Signed-off-by Dan Carpenter <[email protected]>---
Very recent bug.drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +2
-2@@ -2321,8 +2321,8 @@ static void hns3_rx_checksum(struct hns3_enet_ring *ring, struct sk_buff *skb,if (!(bd_base_info &BIT (HNS3_RXD_L3L4P_B )))return ; -if (unlikely (l234info & (BIT (HNS3_RXD_L3E_B ) |BIT (HNS3_RXD_L4E_B ) || -BIT (HNS3_RXD_OL3E_B ) || +if (unlikely (l234info & (BIT (HNS3_RXD_L3E_B ) |BIT (HNS3_RXD_L4E_B ) | +BIT (HNS3_RXD_OL3E_B ) |BIT (HNS3_RXD_OL4E_B )))) {u64_stats_update_begin (&ring->syncp); ring->stats.l3l4_csum_err++;
From: Dan Carpenter <[email protected]>
Date: Wed, 6 Mar 2019 11:12:34 +0300
Quoted 7 lines
There were a couple logical ORs accidentally mixed in with the bitwise ORs.
Fixes e8149933b1fa ("net: hns3: remove hnae3_get_bit in data path")Signed-off-by Dan Carpenter <[email protected]>---
Very recent bug.
Applied.