Staging: pi433: Fix line over 80 characters issue
PATCH 1/1 Staging: pi433: Fix line over 80 characters issue
Break the lines after '&' and match the alignment with '(' to remove the checkpatch.pl warning. Remove whitespace after '&' if any.
--- drivers/staging/pi433/rf69.c | 48 +++++++++++++++++++++++++++++--------------- 1 file changed, 32 insertions(+), 16 deletions(-)
drivers/staging/pi433/rf69.c +32 -16
@@ -566,39 +566,55 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag)return (rf69_read_reg (spi,REG_IRQFLAGS1 ) &MASK_IRQFLAGS1_MODE_READY );case ready_to_receive: -return (rf69_read_reg (spi,REG_IRQFLAGS1 ) &MASK_IRQFLAGS1_RX_READY ); +return (rf69_read_reg (spi,REG_IRQFLAGS1 ) & +MASK_IRQFLAGS1_RX_READY );case ready_to_send: -return (rf69_read_reg (spi,REG_IRQFLAGS1 ) &MASK_IRQFLAGS1_TX_READY ); +return (rf69_read_reg (spi,REG_IRQFLAGS1 ) & +MASK_IRQFLAGS1_TX_READY );case pll_locked: -return (rf69_read_reg (spi,REG_IRQFLAGS1 ) &MASK_IRQFLAGS1_PLL_LOCK ); +return (rf69_read_reg (spi,REG_IRQFLAGS1 ) & +MASK_IRQFLAGS1_PLL_LOCK );case rssi_exceeded_threshold: -return (rf69_read_reg (spi,REG_IRQFLAGS1 ) &MASK_IRQFLAGS1_RSSI ); +return (rf69_read_reg (spi,REG_IRQFLAGS1 ) & +MASK_IRQFLAGS1_RSSI );case timeout: -return (rf69_read_reg (spi,REG_IRQFLAGS1 ) &MASK_IRQFLAGS1_TIMEOUT ); +return (rf69_read_reg (spi,REG_IRQFLAGS1 ) & +MASK_IRQFLAGS1_TIMEOUT );case automode: -return (rf69_read_reg (spi,REG_IRQFLAGS1 ) &MASK_IRQFLAGS1_AUTOMODE ); +return (rf69_read_reg (spi,REG_IRQFLAGS1 ) & +MASK_IRQFLAGS1_AUTOMODE );case sync_address_match: -return (rf69_read_reg (spi,REG_IRQFLAGS1 ) &MASK_IRQFLAGS1_SYNC_ADDRESS_MATCH ); +return (rf69_read_reg (spi,REG_IRQFLAGS1 ) & +MASK_IRQFLAGS1_SYNC_ADDRESS_MATCH );case fifo_full: -return (rf69_read_reg (spi,REG_IRQFLAGS2 ) &MASK_IRQFLAGS2_FIFO_FULL ); +return (rf69_read_reg (spi,REG_IRQFLAGS2 ) & +MASK_IRQFLAGS2_FIFO_FULL );/* * case fifo_not_empty: -* return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY); +* return (rf69_read_reg(spi, REG_IRQFLAGS2) & +* MASK_IRQFLAGS2_FIFO_NOT_EMPTY); */ case fifo_empty: -return !(rf69_read_reg (spi,REG_IRQFLAGS2 ) &MASK_IRQFLAGS2_FIFO_NOT_EMPTY ); +return !(rf69_read_reg (spi,REG_IRQFLAGS2 ) & +MASK_IRQFLAGS2_FIFO_NOT_EMPTY );case fifo_level_below_threshold: -return (rf69_read_reg (spi,REG_IRQFLAGS2 ) &MASK_IRQFLAGS2_FIFO_LEVEL ); +return (rf69_read_reg (spi,REG_IRQFLAGS2 ) & +MASK_IRQFLAGS2_FIFO_LEVEL );case fifo_overrun: -return (rf69_read_reg (spi,REG_IRQFLAGS2 ) &MASK_IRQFLAGS2_FIFO_OVERRUN ); +return (rf69_read_reg (spi,REG_IRQFLAGS2 ) & +MASK_IRQFLAGS2_FIFO_OVERRUN );case packet_sent: -return (rf69_read_reg (spi,REG_IRQFLAGS2 ) &MASK_IRQFLAGS2_PACKET_SENT ); +return (rf69_read_reg (spi,REG_IRQFLAGS2 ) & +MASK_IRQFLAGS2_PACKET_SENT );case payload_ready: -return (rf69_read_reg (spi,REG_IRQFLAGS2 ) &MASK_IRQFLAGS2_PAYLOAD_READY ); +return (rf69_read_reg (spi,REG_IRQFLAGS2 ) & +MASK_IRQFLAGS2_PAYLOAD_READY );case crc_ok: -return (rf69_read_reg (spi,REG_IRQFLAGS2 ) &MASK_IRQFLAGS2_CRC_OK ); +return (rf69_read_reg (spi,REG_IRQFLAGS2 ) & +MASK_IRQFLAGS2_CRC_OK );case battery_low: -return (rf69_read_reg (spi,REG_IRQFLAGS2 ) &MASK_IRQFLAGS2_LOW_BAT ); +return (rf69_read_reg (spi,REG_IRQFLAGS2 ) & +MASK_IRQFLAGS2_LOW_BAT );default :return false; } }
Signature · 1 line
2.7.4
Greg KH
maintainerQuoted 4 lines · Debleena Sen
Break the lines after '&' and match the alignment with '(' to remove the checkpatch.pl warning. Remove whitespace after '&' if any.
Signed-off-by Debleena Sen <[email protected]>
This has the same subject line as your previous patch, yet does different things :(
Please resend them all, as a patch series, with unique subject lines.
thanks,
greg k-h
A message that is not in the archive (sent off-list or not yet received): CACw+u4GRhRY5kgjQgd-sYOLp4nfHU-tp_oKfK74i+QR7cnWQNg@mail.gmail.com
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 4 lines · Greg KH
On Wed, Mar 06, 2019 at 02:54:44PM +0530, Debleena Sen wrote:
<snip>
Quoted 8 lines
For some reason you sent this only to me, which is a bit rude to everyone else on the mailing list. I'll be glad to respond if you resend it to everyone.
thanks,
greg k-h
Sorry didn't notice
PATCH 1/1 Staging: pi433: Fix line over 80 characters issue
In reply to a message not in the archive---------- Forwarded message ---------
From: Debleena Sen <[email protected]>
Date: Wed, Mar 6, 2019 at 2:54 PM
Subject: Re: [PATCH] Staging: pi433: Fix line over 80 characters issue
To: Greg KH <[email protected]>
Quoted 6 lines · Greg KH
Quoted 4 lines · Debleena Sen
Break the lines after '&' and match the alignment with '(' to remove the checkpatch.pl warning. Remove whitespace after '&' if any.
Signed-off-by Debleena Sen <[email protected]>
Quoted 9 lines
This has the same subject line as your previous patch, yet does different things :(
Please resend them all, as a patch series, with unique subject lines.
thanks,
greg k-h
Actually in pi433/rf69.c there were like 16 warnings of the same type. In my previous patch I had fixed only one warning. In this patch, I fixed all of them. They have the same styling issue and I did the same thing on all the lines. So I thought to put the same subject because essentially all of them are same.
Debleena
Quoted 25 lines · Debleena Sen
---------- Forwarded message ---------
From: Debleena Sen <[email protected]>
Date: Wed, Mar 6, 2019 at 2:54 PM
Subject: Re: [PATCH] Staging: pi433: Fix line over 80 characters issue
To: Greg KH <[email protected]>On Wed, Mar 6, 2019 at 2:45 PM Greg KH <[email protected]> wrote:
On Tue, Mar 05, 2019 at 09:13:06AM -0800, Debleena Sen wrote:
> Break the lines after '&' and match the alignment with '(' to remove the
> checkpatch.pl warning. Remove whitespace after '&' if any. >
> Signed-off-by: Debleena Sen <[email protected]>This has the same subject line as your previous patch, yet does different things :(
Please resend them all, as a patch series, with unique subject lines.
thanks,
Quoted 8 lines
greg k-h
ᅵ
Actually inpi433/rf69.cthere were like 16 warnings of the same type. In my previous patch I had fixed only one warning. In this patch, I fixed all of them. They have the same styling issue and I did the same thing on all the lines. So I thought to put the same subject because essentially all of them are same.
Every patch in the Linux kernel needs a different subject.
julia
Quoted 14 lines
Debleenaᅵ
--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CACw%2Bu4FaS0PDoxh2urUrq gBfRJWD7qY7xchgVEaKLZ06PD6a%2BA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.