Skip to contentSkip to conversation

How to upload proposal and code for specifying and customizing projects?

DISCUSSION Tony Lee (李文富) 3 participants 6 messages Mar 5, 2019 – Mar 11, 2019

lore
Share & tools
lore
#0 lore raw

Hi Brad,

I have two new packages "phosphor-nvme" and "quanta-dbus-interfaces" for specifying and customizing projects. There was a service pooling status of NVMe devices in " phosphor-nvme " and several d-bus interfaces for Quanta in "quanta-dbus-interfaces".

1. Is it will be put into a new repository or put it under the meta-quanta?
2. As for the proposal, is it still need to commit to gerrit under openbmc/docs ?

Thanks
Best Regards,
Tony

#1 lore raw
Quoted 3 lines · Tony Lee (李文富)

Hi Brad,

I have two new packages "phosphor-nvme"

Is this package already written? Would you mind filling out a design template for it?

https://github.com/openbmc/docs/blob/master/designs/design-template.md

Quoted 6 lines

and "quanta-dbus-interfaces" for specifying and customizing projects. There was a service pooling status of NVMe devices in " phosphor-nvme " and several d-bus interfaces for Quanta in "quanta-dbus-interfaces".

1. Is it will be put into a new repository or put it under the meta-quanta?
2. As for the proposal, is it still need to commit to gerrit under openbmc/docs ?

I can certainly create a quanta-dbus-interfaces repository if you'd like. But first - I'm just curious abouut what sorts of DBus APIs you have? Are they actually specific to Quanta machines, or could they be put in phosphor-dbus-interfaces?

Do the applications that implement the APIs in quanta-dbus-interfaces already exist or are you planning on writing them in the future?

Could you briefly talk about what some of the applications that present/would present these APIs do?

thx - brad

#2 lore raw

Hi Brad,

Quoted 1 line

Is this package already written? Would you mind filling out a design template for it?

No, the package is not ready yet. I will filling out a design template for it.

Quoted 1 line

I can certainly create a quanta-dbus-interfaces repository if you'd like. But first - I'm just curious about what sorts of DBus APIs you have? Are they actually specific to Quanta machines, or could they be put in phosphor-dbus-interfaces?

Understood. It can also be used for the machine has NVMe drives on it. The APIs could be put in phosphor-dbus-interfaces. for example, "xyz.openbmc_project.Nvme.Information”. The properties will be SerialNumber, VendorID, SmartWarnings, StatusFlags, DriveLifeUsed.

Quoted 1 line

Could you briefly talk about what some of the applications that present/would present these APIs do?

The application is to retrieve information of the NVMe devices by NVMe-MI commands via SMBus directly.

Thanks
Best Regards,
Tony

-----Original Message-----
From: Brad Bishop [mailto:[email protected]]
Sent: Thursday, March 7, 2019 12:20 PM
To: Tony Lee (李文富) <[email protected]>
Cc: [email protected]
Subject: Re: How to upload proposal and code for specifying and customizing projects?

Quoted 3 lines · Tony Lee (李文富)

Hi Brad,

I have two new packages "phosphor-nvme"

Is this package already written? Would you mind filling out a design template for it?

https://github.com/openbmc/docs/blob/master/designs/design-template.md

Quoted 6 lines

and "quanta-dbus-interfaces" for specifying and customizing projects. There was a service pooling status of NVMe devices in " phosphor-nvme " and several d-bus interfaces for Quanta in "quanta-dbus-interfaces".

1. Is it will be put into a new repository or put it under the meta-quanta?
2. As for the proposal, is it still need to commit to gerrit under openbmc/docs ?

I can certainly create a quanta-dbus-interfaces repository if you'd like. But first - I'm just curious abouut what sorts of DBus APIs you have? Are they actually specific to Quanta machines, or could they be put in phosphor-dbus-interfaces?

Do the applications that implement the APIs in quanta-dbus-interfaces already exist or are you planning on writing them in the future?

Could you briefly talk about what some of the applications that present/would present these APIs do?

thx - brad

#3 lore raw
Quoted 6 lines · Tony Lee (李文富)

Hi Brad,

Quoted 1 line

I can certainly create a quanta-dbus-interfaces repository if you'd like. But first - I'm just curious about what sorts of DBus APIs you have? Are they actually specific to Quanta machines, or could they be put in phosphor-dbus-interfaces?

Understood. It can also be used for the machine has NVMe drives on it. The APIs could be put in phosphor-dbus-interfaces. for example, "xyz.openbmc_project.Nvme.Information”. The properties will be SerialNumber, VendorID, SmartWarnings, StatusFlags, DriveLifeUsed.

There is already some initial work to do this, and this is definitely not a quanta specific feature. It should not be put in quanta-dbus-interfaces. The design document below is laying the ground work to enable NVMe-MI. It be great if you could help to review it before implementing anything, or pushing your own design doc.
https://gerrit.openbmc-project.xyz/#/c/openbmc/docs/+/18031/

The long term intention is that this will be implemented as part of the xyz.openbmc_project.Asset interface, and leave the NVMe information to an NVME-specific API.

Quoted 7 lines
Quoted 2 lines

Could you briefly talk about what some of the applications that present/would present these APIs do?

The application is to retrieve information of the NVMe devices by NVMe-MI commands via SMBus directly.

Thanks
Best Regards,
Tony

It would help a lot if you could help to review some of the code reviews in progress that are working through NVMe-MI. That will accelerate NVMe support faster than starting over from scratch.

-Ed

#4 lore raw

Hi Ed,

We know that the above proposal can get more fully information and in most cases it matches.
But our design is to provide a simple way to get basic parameters (such as vendor ID, serial numbers, etc.) via SMbus and it is not a quanta specific feature. Currently, it only needs the feature to retrieve NVMe drives information without MCTP. Here is the proposal. https://gerrit.openbmc-project.xyz/#/c/openbmc/docs/+/19061/

Thanks
Best Regards,
Tony

-----Original Message-----
From: Ed Tanous [mailto:[email protected]]
Sent: Saturday, March 9, 2019 1:34 AM
To: Tony Lee (李文富) <[email protected]>; Brad Bishop <[email protected]>
Cc: [email protected]
Subject: Re: How to upload proposal and code for specifying and customizing projects?

Quoted 6 lines · Tony Lee (李文富)

Hi Brad,

Quoted 1 line

I can certainly create a quanta-dbus-interfaces repository if you'd like. But first - I'm just curious about what sorts of DBus APIs you have? Are they actually specific to Quanta machines, or could they be put in phosphor-dbus-interfaces?

Understood. It can also be used for the machine has NVMe drives on it. The APIs could be put in phosphor-dbus-interfaces. for example, "xyz.openbmc_project.Nvme.Information”. The properties will be SerialNumber, VendorID, SmartWarnings, StatusFlags, DriveLifeUsed.

There is already some initial work to do this, and this is definitely not a quanta specific feature. It should not be put in quanta-dbus-interfaces. The design document below is laying the ground work to enable NVMe-MI. It be great if you could help to review it before implementing anything, or pushing your own design doc.
https://gerrit.openbmc-project.xyz/#/c/openbmc/docs/+/18031/

The long term intention is that this will be implemented as part of the xyz.openbmc_project.Asset interface, and leave the NVMe information to an NVME-specific API.

Quoted 7 lines
Quoted 2 lines

Could you briefly talk about what some of the applications that present/would present these APIs do?

The application is to retrieve information of the NVMe devices by NVMe-MI commands via SMBus directly.

Thanks
Best Regards,
Tony

It would help a lot if you could help to review some of the code reviews in progress that are working through NVMe-MI. That will accelerate NVMe support faster than starting over from scratch.

-Ed