drm/amdgpu: fix ras parameter descriptions
Subsystems (2)
PATCH 1/1 drm/amdgpu: fix ras parameter descriptions
The descriptions of modinfo wrongly show two parameters for each feature(see below). This patch can fix this incorrect outputs.
parm: amdgpu_ras_enable:Enable RAS features on the GPU (0 = disable, 1 = enable, -1 = auto (default)) parm: ras_enable:int parm: amdgpu_ras_mask:Mask of RAS features to enable (default 0xffffffff), only valid when ras_enable == 1 parm: ras_mask:uint
--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +4 -4
@@ -512,18 +512,18 @@ MODULE_PARM_DESC(emu_mode, "Emulation mode, (1 = enable, 0 = disable)");module_param_named (emu_mode, amdgpu_emu_mode, int,0444 );/* -* DOC: amdgpu_ras_enable (int) +* DOC: ras_enable (int) * Enable RAS features on the GPU (0 = disable, 1 = enable, -1 = auto (default)) */ -MODULE_PARM_DESC (amdgpu_ras_enable,"Enable RAS features on the GPU (0 = disable, 1 = enable, -1 = auto (default))" ); +MODULE_PARM_DESC (ras_enable,"Enable RAS features on the GPU (0 = disable, 1 = enable, -1 = auto (default))" );module_param_named (ras_enable, amdgpu_ras_enable, int,0444 );/** -* DOC: amdgpu_ras_mask (uint) +* DOC: ras_mask (uint) * Mask of RAS features to enable (default 0xffffffff), only valid when ras_enable == 1 * See the flags in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h */ -MODULE_PARM_DESC (amdgpu_ras_mask,"Mask of RAS features to enable (default 0xffffffff), only valid when ras_enable == 1" ); +MODULE_PARM_DESC (ras_mask,"Mask of RAS features to enable (default 0xffffffff), only valid when ras_enable == 1" );module_param_named (ras_mask, amdgpu_ras_mask, uint,0444 );
Signature · 6 lines
2.21.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
Looks good to me.
Thanks.
-----Original Message-----
From: Evan Quan <[email protected]>
Sent: 2019年3月7日 15:01
To: [email protected]
Cc: Zhang, Hawking <[email protected]>; Pan, Xinhui <[email protected]>; Deucher, Alexander <[email protected]>; Quan, Evan <[email protected]>
Subject: [PATCH] drm/amdgpu: fix ras parameter descriptions
The descriptions of modinfo wrongly show two parameters for each feature(see below). This patch can fix this incorrect outputs.
parm: amdgpu_ras_enable:Enable RAS features on the GPU (0 = disable, 1 = enable, -1 = auto (default)) parm: ras_enable:int parm: amdgpu_ras_mask:Mask of RAS features to enable (default 0xffffffff), only valid when ras_enable == 1 parm: ras_mask:uint
--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +6 -4
@@ -512,18 +512,18 @@ MODULE_PARM_DESC(emu_mode, "Emulation mode, (1 = enable, 0 = disable)"); module_param_named(emu_mode, amdgpu_emu_mode, int, 0444);/* -* DOC: amdgpu_ras_enable (int) +* DOC: ras_enable (int) * Enable RAS features on the GPU (0 = disable, 1 = enable, -1 = auto (default)) */ -MODULE_PARM_DESC (amdgpu_ras_enable,"Enable RAS features on the GPU (0 = disable, 1 = enable, -1 = auto (default))" ); +MODULE_PARM_DESC(ras_enable, "Enable RAS features on the GPU (0 = +disable, 1 = enable, -1 = auto (default))");module_param_named (ras_enable, amdgpu_ras_enable, int,0444 );/** -* DOC: amdgpu_ras_mask (uint) +* DOC: ras_mask (uint) * Mask of RAS features to enable (default 0xffffffff), only valid when ras_enable == 1 * See the flags in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h */ -MODULE_PARM_DESC (amdgpu_ras_mask,"Mask of RAS features to enable (default 0xffffffff), only valid when ras_enable == 1" ); +MODULE_PARM_DESC(ras_mask, "Mask of RAS features to enable (default +0xffffffff), only valid when ras_enable == 1");module_param_named (ras_mask, amdgpu_ras_mask, uint,0444 );
--
2.21.0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Deucher, Alexander
Reviewed-by________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Evan Quan <[email protected]>
Sent: Thursday, March 7, 2019 2:00 AM
To: [email protected]
Cc: Deucher, Alexander; Pan, Xinhui; Quan, Evan; Zhang, Hawking
Subject: [PATCH] drm/amdgpu: fix ras parameter descriptions
The descriptions of modinfo wrongly show two parameters for each feature(see below). This patch can fix this incorrect outputs.
parm: amdgpu_ras_enable:Enable RAS features on the GPU (0 = disable, 1 = enable, -1 = auto (default)) parm: ras_enable:int parm: amdgpu_ras_mask:Mask of RAS features to enable (default 0xffffffff), only valid when ras_enable == 1 parm: ras_mask:uint
--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +4 -4
@@ -512,18 +512,18 @@ MODULE_PARM_DESC(emu_mode, "Emulation mode, (1 = enable, 0 = disable)");module_param_named (emu_mode, amdgpu_emu_mode, int,0444 );/* -* DOC: amdgpu_ras_enable (int) +* DOC: ras_enable (int) * Enable RAS features on the GPU (0 = disable, 1 = enable, -1 = auto (default)) */ -MODULE_PARM_DESC (amdgpu_ras_enable,"Enable RAS features on the GPU (0 = disable, 1 = enable, -1 = auto (default))" ); +MODULE_PARM_DESC (ras_enable,"Enable RAS features on the GPU (0 = disable, 1 = enable, -1 = auto (default))" );module_param_named (ras_enable, amdgpu_ras_enable, int,0444 );/** -* DOC: amdgpu_ras_mask (uint) +* DOC: ras_mask (uint) * Mask of RAS features to enable (default 0xffffffff), only valid when ras_enable == 1 * See the flags in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h */ -MODULE_PARM_DESC (amdgpu_ras_mask,"Mask of RAS features to enable (default 0xffffffff), only valid when ras_enable == 1" ); +MODULE_PARM_DESC (ras_mask,"Mask of RAS features to enable (default 0xffffffff), only valid when ras_enable == 1" );module_param_named (ras_mask, amdgpu_ras_mask, uint,0444 );
--
2.21.0
_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx