systemd: RDEPENDS on util-linux-umount
PATCH 1/1 systemd: RDEPENDS on util-linux-umount
From: André Draszik <[email protected]>
It looks like there is an implicit dependency on util-linux' umount - as otherwise when using busybox' umount we see a long delay on shutdown / reboot.
[YOCTO #13058]
(From OE-Core rev: 39a3d2c603429865af632fe41b2cf32c3dfdfb1d)
--- meta/recipes-core/systemd/systemd_239.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/systemd/systemd_239.bb +1 -1
@@ -544,7 +544,7 @@ FILES_${PN} = " ${base_bindir}/* \ FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-1/interfaces/ ${sysconfdir}/rpm/macros.systemd" -RDEPENDS_${PN} += "kmod dbus util-linux-mount udev (= ${EXTENDPKGV}) util-linux-agetty util-linux-fsck" +RDEPENDS_${PN} += "kmod dbus util-linux-mount util-linux-umount udev (= ${EXTENDPKGV}) util-linux-agetty util-linux-fsck" RDEPENDS_${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'serial-getty-generator', '', 'systemd-serialgetty', d)}" RDEPENDS_${PN} += "volatile-binds update-rc.d systemd-conf"
Signature · 1 line
2.17.1
Quoted 9 lines · Adrian Bunk
From: André Draszik <[email protected]>
It looks like there is an implicit dependency on util-linux' umount - as otherwise when using busybox' umount we see a long delay on shutdown / reboot.
[YOCTO #13058]
That bug number is wrong, seems only slighty related:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=13058
Following the discussions, I think this had to do with older versions of busybox not ignoring the '-c' option that systemd passes to umount.
https://github.com/systemd/systemd/issues/7786
So, systemd has a dependency on *either* util-linux-mount *or* a minimal version of busybox. Do we support minimal version dependencies in Yocto?
Regards,
Leon.
Quoted 13 lines · Leon Woestenberg
Quoted 9 lines · Adrian Bunk
From: André Draszik <[email protected]>
It looks like there is an implicit dependency on util-linux' umount - as otherwise when using busybox' umount we see a long delay on shutdown / reboot.
[YOCTO #13058]
That bug number is wrong, seems only slighty related:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=13058
Quoted 8 lines
Following the discussions, I think this had to do with older versions of busybox not ignoring the '-c' option that systemd passes to umount.
https://github.com/systemd/systemd/issues/7786
So, systemd has a dependency on *either* util-linux-mount *or* a minimal version of busybox. Do we support minimal version dependencies in Yocto?
Then the patch to master didn't make sense,
unfixed busybox is not a problem here.
If systemd needs util-linux mount/umount in master it should also depend on them in older releases (both master and thud had systemd 239 at that point).
If it does not, it should not pull in such dependencies unconditionally in master.
Quoted 3 lines
Regards,
Leon.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedHi Adrian,
Quoted 10 lines · Adrian Bunk
Quoted 8 lines · Leon Woestenberg
Quoted 7 lines · Adrian Bunk
From: André Draszik <[email protected]>
It looks like there is an implicit dependency on util-linux' umount - as otherwise when using busybox' umount we see a long delay on shutdown / reboot.
Quoted 6 lines
Quoted 2 lines
Quoted 2 lines
[YOCTO #13058]
If systemd needs util-linux mount/umount in master it should also depend on them in older releases (both master and thud had systemd 239 at that point).
Agreed. I was just adding info to this e-mail thread. The "looks like there is an implicit dependency" text was a bit too vague for me. I'ld like to add the root cause that was found.
The implicit dependency was for a specific option to umount to be supported.
If we have the proper busybox in master, we no longer have a implicit dependency on util-linux-umount.
(The reason for the util-linux-mount dependency was different, AFAIK.)
Regards,
Leon.
Quoted 16 lines · Adrian Bunk
Quoted 15 lines · Leon Woestenberg
Quoted 8 lines · Adrian Bunk
From: André Draszik <[email protected]>
It looks like there is an implicit dependency on util-linux' umount - as otherwise when using busybox' umount we see a long delay on shutdown / reboot.
[YOCTO #13058]
That bug number is wrong, seems only slighty related:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=13058Following the discussions, I think this had to do with older versions of busybox not ignoring the '-c' option that systemd passes to umount.
Quoted 8 lines
Quoted 5 lines
https://github.com/systemd/systemd/issues/7786
So, systemd has a dependency on *either* util-linux-mount *or* a minimal version of busybox. Do we support minimal version dependencies in Yocto?
Then the patch to master didn't make sense,
unfixed busybox is not a problem here.
Yeah, I did ask for my patch to be ignored, and there was further discussion confirming that it isn't needed these days. Unfortunately my patch still went in.
http://lists.openembedded.org/pipermail/openembedded-core/2019-February/278893.html
Quoted 6 lines
If systemd needs util-linux mount/umount in master it should also depend on them in older releases (both master and thud had systemd 239 at that point).
If it does not, it should not pull in such dependencies unconditionally in master.
Care to post a patch reverting it on master?
Cheers,
Andre'
Quoted 15 lines
Quoted 4 lines
Regards,
Leon.
cu
AdrianSignature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
Quoted 44 lines · André Draszik
Quoted 21 lines · Adrian Bunk
Quoted 20 lines · Leon Woestenberg
Quoted 8 lines · Adrian Bunk
From: André Draszik <[email protected]>
It looks like there is an implicit dependency on util-linux' umount - as otherwise when using busybox' umount we see a long delay on shutdown / reboot.
[YOCTO #13058]
That bug number is wrong, seems only slighty related:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=13058Following the discussions, I think this had to do with older versions
of busybox not ignoring the '-c' option that systemd passes to umount.Quoted 7 lines
Quoted 4 lines
So, systemd has a dependency on *either* util-linux-mount *or* a minimal version of busybox. Do we support minimal version dependencies
in Yocto?Then the patch to master didn't make sense,
unfixed busybox is not a problem here.Yeah, I did ask for my patch to be ignored, and there was further discussion
confirming that it isn't needed these days. Unfortunately my patch still
went in.http://lists.openembedded.org/pipermail/openembedded-core/2019-February/278893.html
Quoted 5 lines
If systemd needs util-linux mount/umount in master it should also depend on them in older releases (both master and thud had systemd 239
at that point).
Quoted 5 lines
Quoted 3 lines
If it does not, it should not pull in such dependencies unconditionally
in master.Care to post a patch reverting it on master?
Going from memory I think there were some responses saying we should probably add this patch regardless since we already needed util-linux- mount. I didn't think it was a huge issue since mount was already there and it seemed to solve some problems others were having.
I don't have a strong preference either way, we just need a general consensus about what to do...
Cheers,
Richard
Quoted 8 lines · Richard Purdie
Going from memory I think there were some responses saying we should probably add this patch regardless since we already needed util-linux- mount. I didn't think it was a huge issue since mount was already there and it seemed to solve some problems others were having.
I don't have a strong preference either way, we just need a general consensus about what to do...
The general problem seems to be that systemd upstream does not care much whether busybox versions of commands work with systemd.
This creates a conflict between upstream recommendations and aiming at a tiny system when using systemd.
The latter would require a continuous effort from someone at OE/Yocto to ensure that the runtime dependencies of systemd are small but working.
Quoted 3 lines
Cheers,
Richard
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed