drm/stm: fix CONFIG_FB dependency
Subsystems (4)
PATCH 1/1 drm/stm: fix CONFIG_FB dependency
The DRM_STM driver can be built independently of the framebuffer layer, but it causes a Kconfig warning:
WARNING: unmet direct dependencies detected for FB_PROVIDE_GET_FB_UNMAPPED_AREA
Depends on [n]: HAS_IOMEM [=y] && FB [=n]
Selected by [y]:
- DRM_STM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_STM32 [=n] || ARCH_MULTIPLATFORM [=y])
Selecting FB_PROVIDE_GET_FB_UNMAPPED_AREA actually has no effect if CONFIG_FB is disabled, so we can make it a conditional 'select' instead.
--- drivers/gpu/drm/stm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/stm/Kconfig +1 -1
@@ -6,7 +6,7 @@ config DRM_STM select DRM_KMS_CMA_HELPER select DRM_PANEL_BRIDGE select VIDEOMODE_HELPERS - select FB_PROVIDE_GET_FB_UNMAPPED_AREA + select FB_PROVIDE_GET_FB_UNMAPPED_AREA if FB help Enable support for the on-chip display controller on
Signature · 6 lines
2.20.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Arnd,
could you merge the patch?
I think that Benjamin could also merge it.
Best regards
Yannick Fertré
On 3/7/19 4:53 PM, Arnd Bergmann wrote:
The DRM_STM driver can be built independently of the framebuffer layer, but it causes a Kconfig warning:
WARNING: unmet direct dependencies detected for FB_PROVIDE_GET_FB_UNMAPPED_AREA
Depends on [n]: HAS_IOMEM [=y] && FB [=n]
Selected by [y]:
- DRM_STM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_STM32 [=n] || ARCH_MULTIPLATFORM [=y])
Selecting FB_PROVIDE_GET_FB_UNMAPPED_AREA actually has no effect if CONFIG_FB is disabled, so we can make it a conditional 'select' instead.
--- drivers/gpu/drm/stm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/stm/Kconfig +1 -1
@@ -6,7 +6,7 @@ config DRM_STM select DRM_KMS_CMA_HELPER select DRM_PANEL_BRIDGE select VIDEOMODE_HELPERS - select FB_PROVIDE_GET_FB_UNMAPPED_AREA + select FB_PROVIDE_GET_FB_UNMAPPED_AREA if FB help Enable support for the on-chip display controller on
--
Yannick Fertré | TINA: 166 7152 | Tel: +33 244027152 | Mobile: +33 620600270 Microcontrollers and Digital ICs Group | Microcontrolleurs Division
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 2 lines · Yannick FERTRE
Reviewed-by Yannick Fertré <[email protected]>
Thanks,
Quoted 3 lines
Arnd,
could you merge the patch?
I think that Benjamin could also merge it.
I think this should go through the drm tree, so someone with access to that should merge it, not me.
Arnd
Quoted 5 lines · Arnd Bergmann
Quoted 2 lines · Yannick FERTRE
Reviewed-by Yannick Fertré <[email protected]>
Quoted 8 lines
Thanks,
Quoted 3 lines
Arnd,
could you merge the patch?
I think that Benjamin could also merge it.I think this should go through the drm tree, so someone with access to that should merge it, not me.
Applied on drm-misc-next,
Thanks,
Benjamin
Quoted 2 lines
Arnd