Staging: vt6655: Remove unused function prototype and definition
PATCH v3 1/1 Staging: vt6655: Remove unused function prototype and definition
Remove an unused function, as it is never called in kernel tree.
---
Changes in v3-
- Changed subject line
- Removed change log above signed-off-by
Changes in v2-
- Changed patch series to a patch
--- drivers/staging/vt6655/mac.c | 7 ------- drivers/staging/vt6655/mac.h | 2 -- 2 files changed, 9 deletions(-)
drivers/staging/vt6655/mac.c +0 -7
@@ -57,13 +57,6 @@* Return Value: true if all test bits On; otherwise false * */ -bool MACbIsRegBitsOn (struct vnt_private *priv,unsigned char byRegOfs, -unsigned char byTestBits) -{ -void __iomem *io_base = priv->PortOffset; - -return (ioread8 (io_base + byRegOfs) & byTestBits) == byTestBits; -}/* * Description:
drivers/staging/vt6655/mac.h +0 -2
@@ -876,8 +876,6 @@ do { \#define MACvSetRFLE_LatchBase (iobase) \ MACvWordRegBitsOn(iobase, MAC_REG_SOFTPWRCTL, SOFTPWRCTL_RFLEOPT) -bool MACbIsRegBitsOn (struct vnt_private *priv,unsigned char byRegOfs, -unsigned char byTestBits);bool MACbIsRegBitsOff (struct vnt_private *priv,unsigned char byRegOfs,unsigned char byTestBits);
Signature · 1 line
2.17.1
Greg KH
maintainerQuoted 3 lines · Madhumitha Prabakaran
Remove an unused function, as it is never called in kernel tree.
Signed-off-by Madhumitha Prabakaran <[email protected]>
Tiny nit, and I'll fix this up on my own, but usually it is nice to put the name of the function that you are removing in the changelog, so it is easier to search for in the future when you are wondering why did a specific function disappear.
thanks,
greg k-h
Quoted 5 lines · Greg KH
Quoted 3 lines · Madhumitha Prabakaran
Remove an unused function, as it is never called in kernel tree.
Signed-off-by Madhumitha Prabakaran <[email protected]>
Quoted 8 lines
Tiny nit, and I'll fix this up on my own, but usually it is nice to put the name of the function that you are removing in the changelog, so it is easier to search for in the future when you are wondering why did a specific function disappear.
thanks,
greg k-h
Thanks, will remember that in future.
Madhumitha