Skip to contentSkip to conversation

package/flashrom: disable on arc, nios and or1k

PATCH New Fabrice Fontaine 2 participants 3 messages Mar 7, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/flashrom: disable on arc, nios and or1k

Fixes:
- http://autobuild.buildroot.org/results/22c72369cd5b7a8200bb03564bdc342ed026ccac
- http://autobuild.buildroot.org/results/ef6869bc40382145fad1079b79107275c4973494
- http://autobuild.buildroot.org/results/09d857102c469ede1db0bff8aa0dcd82a4001eaf

---
 package/flashrom/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/flashrom/Config.in +3 -1
index cf1f53c1a3..b99fc2a960 100644
@@ -1,6 +1,8 @@
 config BR2_PACKAGE_FLASHROM
 	bool "flashrom"
-	depends on !BR2_microblaze && !BR2_xtensa # platform.h
+	# platform.h
+	depends on !(BR2_arc || BR2_microblaze || BR2_nios || \
+		BR2_or1k || BR2_xtensa)
 	help
 	  flashrom is a utility for identifying, reading, writing,
 	  verifying and erasing flash chips. It is designed to flash
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 package/flashrom: disable on arc, nios and or1k

Hello,

Quoted 6 lines · On Thu, 7 Mar 2019 22:34:31 +0100 Fabrice Fontaine…

Fixes:
- http://autobuild.buildroot.org/results/22c72369cd5b7a8200bb03564bdc342ed026ccac
- http://autobuild.buildroot.org/results/ef6869bc40382145fad1079b79107275c4973494
- http://autobuild.buildroot.org/results/09d857102c469ede1db0bff8aa0dcd82a4001eaf

Should we turn this around, and use:

config BR2_PACKAGE_FLASHROM_ARCH_SUPPORTS
bool
default y if ...
default y if ...

etc. ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/flashrom: disable on arc, nios and or1k

Dear Thomas,
Le jeu. 7 mars 2019 ? 22:36, Thomas Petazzoni
<[email protected]> a ?crit :

Quoted 13 lines

Hello,

Quoted 6 lines · On Thu, 7 Mar 2019 22:34:31 +0100 Fabrice Fontaine…

Fixes:
- http://autobuild.buildroot.org/results/22c72369cd5b7a8200bb03564bdc342ed026ccac
- http://autobuild.buildroot.org/results/ef6869bc40382145fad1079b79107275c4973494
- http://autobuild.buildroot.org/results/09d857102c469ede1db0bff8aa0dcd82a4001eaf

Quoted 8 lines

Should we turn this around, and use:

config BR2_PACKAGE_FLASHROM_ARCH_SUPPORTS
bool
default y if ...
default y if ...

etc. ?

OK, I'll send a v2.

Quoted 8 lines

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Best Regards,

Fabrice