net: ethernet: sun: Zero initialize class in default case in niu_add_ethtool_tcam_entry
Subsystems (2)
PATCH 1/1 net: ethernet: sun: Zero initialize class in default case in niu_add_ethtool_tcam_entry
When building with -Wsometimes-uninitialized, Clang warns:
drivers/net/ethernet/sun/niu.c:7466:5: warning: variable 'class' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
The default case can never happen because i can only be 0 to 3 (NIU_L3_PROG_CLS is defined as 4). To make this clear to Clang, just zero initialize class in the default case (use the macro CLASS_CODE_UNRECOG to make it clear this shouldn't happen).
--- drivers/net/ethernet/sun/niu.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/sun/niu.c +1 -0
@@ -7464,6 +7464,7 @@ static int niu_add_ethtool_tcam_entry(struct niu *np, class =CLASS_CODE_USER_PROG4 ;break ;default : + class =CLASS_CODE_UNRECOG ;break ; } ret = tcam_user_ip_class_set(np, class, 0,
Signature · 1 line
2.21.0
Quoted 11 lines · Nathan Chancellor
When building with -Wsometimes-uninitialized, Clang warns:
drivers/net/ethernet/sun/niu.c:7466:5: warning: variable 'class' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]The default case can never happen because i can only be 0 to 3 (
NIU_L3_PROG_CLSis defined as 4). To make this clear to Clang, just zero initialize class in the default case (use the macroCLASS_CODE_UNRECOGto make it clear this shouldn't happen).
Good choice. Thanks for the patch.
Quoted 22 lines
Signed-off-by Nathan Chancellor <[email protected]>--- drivers/net/ethernet/sun/niu.c | 1 + 1 file changed, 1 insertion(+)drivers/net/ethernet/sun/niu.c +1
-1@@ -7464,6 +7464,7 @@ static int niu_add_ethtool_tcam_entry(struct niu *np, class =CLASS_CODE_USER_PROG4 ;break ;default : + class =CLASS_CODE_UNRECOG ;break ; } ret = tcam_user_ip_class_set(np, class, 0, --2.21.0
Signature · 2 lines
Thanks, ~Nick Desaulniers
From: Nathan Chancellor <[email protected]>
Date: Thu, 7 Mar 2019 16:29:33 -0700
Quoted 6 lines
When building with -Wsometimes-uninitialized, Clang warns:
drivers/net/ethernet/sun/niu.c:7466:5: warning: variable 'class' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
Quoted 7 lines
The default case can never happen because i can only be 0 to 3 (
NIU_L3_PROG_CLSis defined as 4). To make this clear to Clang, just zero initialize class in the default case (use the macroCLASS_CODE_UNRECOGto make it clear this shouldn't happen).
Applied, thanks.