net/qede: support IOVA VA mode
PATCH 1/1 net/qede: support IOVA VA mode
Set RTE_PCI_DRV_IOVA_AS_VA in drv_flags. This allows initializing qede PMD as non-root also on Linux v4.x, where /proc/self/pagemap can't be acccessed without CAP_SYS_ADMIN privileges.
The flag was introduced generically but not in pmds in commit:815c7deaed2d ("pci: get IOMMU class on Linux")
---
drivers/net/qede/qede_ethdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/qede/qede_ethdev.c +4 -2
@@ -2736,5 +2736,6 @@ static int qedevf_eth_dev_pci_remove(struct rte_pci_device *pci_dev)static struct rte_pci_driver rte_qedevf_pmd = { .id_table = pci_id_qedevf_map, - .drv_flags =RTE_PCI_DRV_NEED_MAPPING |RTE_PCI_DRV_INTR_LSC , + .drv_flags =RTE_PCI_DRV_NEED_MAPPING |RTE_PCI_DRV_INTR_LSC | +RTE_PCI_DRV_IOVA_AS_VA , .probe = qedevf_eth_dev_pci_probe, .remove = qedevf_eth_dev_pci_remove,
@@ -2755,5 +2756,6 @@ static int qede_eth_dev_pci_remove(struct rte_pci_device *pci_dev)static struct rte_pci_driver rte_qede_pmd = { .id_table = pci_id_qede_map, - .drv_flags =RTE_PCI_DRV_NEED_MAPPING |RTE_PCI_DRV_INTR_LSC , + .drv_flags =RTE_PCI_DRV_NEED_MAPPING |RTE_PCI_DRV_INTR_LSC | +RTE_PCI_DRV_IOVA_AS_VA , .probe = qede_eth_dev_pci_probe, .remove = qede_eth_dev_pci_remove,
Signature · 1 line
2.20.1
Quoted 8 lines
From: Kevin Traynor <[email protected]>
Sent: Thursday, March 07, 2019 10:39 AM----------------------------------------------------------------------
SetRTE_PCI_DRV_IOVA_AS_VAindrv_flags. This allows initializing qede PMD as non-root also on Linux v4.x, where/proc/self/pagemapcan't be acccessed withoutCAP_SYS_ADMINprivileges.
Quoted 7 lines
The flag was introduced generically but not in pmds in commit:
815c7deaed2d("pci: get IOMMU class on Linux")Signed-off-by Kevin Traynor <[email protected]>---
Quoted 30 lines
drivers/net/qede/qede_ethdev.c| 6 ++++--1 file changed, 4 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/drivers/net/qede/qede_ethdev.cindex518673dce..6b330c2b2100644drivers/net/qede/qede_ethdev.c +1
-1@@ -2736,5 +2736,6 @@ static int qedevf_eth_dev_pci_remove(struct rte_pci_device *pci_dev) static struct rte_pci_driver rte_qedevf_pmd = { .id_table = pci_id_qedevf_map, - .drv_flags =RTE_PCI_DRV_NEED_MAPPING |RTE_PCI_DRV_INTR_LSC , + .drv_flags =RTE_PCI_DRV_NEED_MAPPING |RTE_PCI_DRV_INTR_LSC |
drivers/net/qede/qede_ethdev.c +1
-0+ RTE_PCI_DRV_IOVA_AS_VA,.probe =
qedevf_eth_dev_pci_probe,
.remove =qedevf_eth_dev_pci_remove,drivers/net/qede/qede_ethdev.c +1
-1@@ -2755,5 +2756,6 @@ static int qede_eth_dev_pci_remove(struct rte_pci_device *pci_dev) static struct rte_pci_driver rte_qede_pmd = { .id_table = pci_id_qede_map, - .drv_flags =RTE_PCI_DRV_NEED_MAPPING |RTE_PCI_DRV_INTR_LSC , + .drv_flags = RTE_PCI_DRV_NEED_MAPPING |
RTE_PCI_DRV_INTR_LSC|drivers/net/qede/qede_ethdev.c +1
-0+ RTE_PCI_DRV_IOVA_AS_VA,.probe =
qede_eth_dev_pci_probe,
.remove =qede_eth_dev_pci_remove,
--
2.20.1
Quoted 11 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Kevin Traynor
Sent: Friday, March 8, 2019 12:09 AM
To: Rasesh Mody <[email protected]>; [email protected]
Cc: Kevin Traynor <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH] net/qede: support IOVA VA modeSet
RTE_PCI_DRV_IOVA_AS_VAindrv_flags. This allows initializing qede PMD as non-root also on Linux v4.x, where/proc/self/pagemapcan't be acccessed withoutCAP_SYS_ADMINprivileges.
Quoted 6 lines
The flag was introduced generically but not in pmds in commit:
815c7deaed2d("pci: get IOMMU class on Linux")Signed-off-by Kevin Traynor <[email protected]>
Thanks,
Shahed
Quoted 28 lines
---
drivers/net/qede/qede_ethdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/net/qede/qede_ethdev.c +3
-2@@ -2736,5 +2736,6 @@ static int qedevf_eth_dev_pci_remove(struct rte_pci_device *pci_dev) static struct rte_pci_driver rte_qedevf_pmd = { .id_table = pci_id_qedevf_map, - .drv_flags =RTE_PCI_DRV_NEED_MAPPING |RTE_PCI_DRV_INTR_LSC , + .drv_flags =RTE_PCI_DRV_NEED_MAPPING |RTE_PCI_DRV_INTR_LSC | +RTE_PCI_DRV_IOVA_AS_VA , .probe = qedevf_eth_dev_pci_probe, .remove = qedevf_eth_dev_pci_remove,@@ -2755,5 +2756,6 @@ static int qede_eth_dev_pci_remove(struct rte_pci_device *pci_dev) static struct rte_pci_driver rte_qede_pmd = { .id_table = pci_id_qede_map, - .drv_flags =RTE_PCI_DRV_NEED_MAPPING |RTE_PCI_DRV_INTR_LSC , + .drv_flags =RTE_PCI_DRV_NEED_MAPPING |RTE_PCI_DRV_INTR_LSC |
drivers/net/qede/qede_ethdev.c +1
-1+ RTE_PCI_DRV_IOVA_AS_VA, .probe = qede_eth_dev_pci_probe, .remove = qede_eth_dev_pci_remove, --2.20.1
PATCH v2 1/1 net/qede: support IOVA VA mode
In reply to Kevin TraynorSet RTE_PCI_DRV_IOVA_AS_VA in drv_flags. This allows initializing qede PMD as non-root also on Linux v4.x, where /proc/self/pagemap can't be acccessed without CAP_SYS_ADMIN privileges.
The flag was introduced generically but not in pmds in commit:815c7deaed2d ("pci: get IOMMU class on Linux")
---
v2: fixed spacing error
drivers/net/qede/qede_ethdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/qede/qede_ethdev.c +4 -2
@@ -2736,5 +2736,6 @@ static int qedevf_eth_dev_pci_remove(struct rte_pci_device *pci_dev)static struct rte_pci_driver rte_qedevf_pmd = { .id_table = pci_id_qedevf_map, - .drv_flags =RTE_PCI_DRV_NEED_MAPPING |RTE_PCI_DRV_INTR_LSC , + .drv_flags =RTE_PCI_DRV_NEED_MAPPING |RTE_PCI_DRV_INTR_LSC | +RTE_PCI_DRV_IOVA_AS_VA , .probe = qedevf_eth_dev_pci_probe, .remove = qedevf_eth_dev_pci_remove,
@@ -2755,5 +2756,6 @@ static int qede_eth_dev_pci_remove(struct rte_pci_device *pci_dev)static struct rte_pci_driver rte_qede_pmd = { .id_table = pci_id_qede_map, - .drv_flags =RTE_PCI_DRV_NEED_MAPPING |RTE_PCI_DRV_INTR_LSC , + .drv_flags =RTE_PCI_DRV_NEED_MAPPING |RTE_PCI_DRV_INTR_LSC | +RTE_PCI_DRV_IOVA_AS_VA , .probe = qede_eth_dev_pci_probe, .remove = qede_eth_dev_pci_remove,
Signature · 1 line
2.20.1
Ferruh Yigit
AppliedQuoted 4 lines · Kevin Traynor
Set
RTE_PCI_DRV_IOVA_AS_VAindrv_flags. This allows initializing qede PMD as non-root also on Linux v4.x, where/proc/self/pagemapcan't be acccessed withoutCAP_SYS_ADMINprivileges.
Quoted 8 lines
The flag was introduced generically but not in pmds in commit:
815c7deaed2d("pci: get IOMMU class on Linux")Acked-by Shahed Shaikh <[email protected]>Acked-by Rasesh Mody <[email protected]>Signed-off-by Kevin Traynor <[email protected]>
Applied to dpdk-next-net/master, thanks.