Skip to contentSkip to conversation

Revert "glamor: Avoid glamor_create_pixmap for pixmaps backing windows"

PATCH In review Michel Dänzer 2 participants 2 messages Mar 8, 2019 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "glamor: Avoid glamor_create_pixmap for pixmaps backing windows"

From: Michel Dänzer <[email protected]>

This reverts commit 274703087f80342f51fa69c935bb9a1cb0c4ae47.

Reports of visual corruption were bisected to this, e.g.
https://bugs.archlinux.org/task/61941 . I can reproduce this with Turks, but not with Bonaire. I assume it's a Mesa/glamor bug, but let's revert for now.

---
 src/radeon_glamor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/radeon_glamor.c +1 -1
index 3e676f2dc..f1098381e 100644
@@ -238,7 +238,7 @@ radeon_glamor_create_pixmap(ScreenPtr screen, int w, int h, int depth,
 		if (info->shadow_primary) {
 			if (usage != CREATE_PIXMAP_USAGE_BACKING_PIXMAP)
 				return fbCreatePixmap(screen, w, h, depth, usage);
-		} else if (usage != CREATE_PIXMAP_USAGE_BACKING_PIXMAP) {
+		} else {
 			pixmap = glamor_create_pixmap(screen, w, h, depth, usage);
 			if (pixmap)
 			    return pixmap;
Signature · 6 lines
2.20.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20190308105121.2908-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org

#2 lore raw

________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Michel Dänzer <[email protected]>
Sent: Friday, March 8, 2019 5:51 AM
To: [email protected]
Subject: [PATCH xf86-video-ati] Revert "glamor: Avoid glamor_create_pixmap for pixmaps backing windows"

From: Michel Dänzer <[email protected]>

This reverts commit 274703087f80342f51fa69c935bb9a1cb0c4ae47.

Reports of visual corruption were bisected to this, e.g.
https://bugs.archlinux.org/task/61941 . I can reproduce this with Turks, but not with Bonaire. I assume it's a Mesa/glamor bug, but let's revert for now.

---
 src/radeon_glamor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/radeon_glamor.c +1 -1
index 3e676f2dc..f1098381e 100644
@@ -238,7 +238,7 @@ radeon_glamor_create_pixmap(ScreenPtr screen, int w, int h, int depth,
                 if (info->shadow_primary) {
                         if (usage != CREATE_PIXMAP_USAGE_BACKING_PIXMAP)
                                 return fbCreatePixmap(screen, w, h, depth, usage);
-               } else if (usage != CREATE_PIXMAP_USAGE_BACKING_PIXMAP) {
+               } else {
                         pixmap = glamor_create_pixmap(screen, w, h, depth, usage);
                         if (pixmap)
                             return pixmap;

--
2.20.1

_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx