Skip to contentSkip to conversation

Fix out-of-tree build.

PATCH New Cyril Hrubis 2 participants 3 messages Mar 8, 2019 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix out-of-tree build.

Ths fixes out of tree build by making the libs directory to be dependency of libs-all.

Not that the the lib and include directory are created as the side efect of the AC_CONFIG_FILES() and hence don't need to be created in the top-level Makefile.

CC Petr Vorel <[email protected]>
CC Jan Stancek <[email protected]>

---

This should be last fix for the numa build troubles.

I still have out-of-tree build failures in ffsb configure but I had enough autoconf and make for today...

 Makefile | 5 +++++
 1 file changed, 5 insertions(+)
Makefile +5 -0
index bc6e9a3e0..170c2da20 100644
@@ -110,6 +110,11 @@ $(sort $(addprefix $(abs_top_builddir)/,$(BOOTSTRAP_TARGETS)) $(INSTALL_DIR) $(D
 ## Pattern based subtarget rules.
 lib-install: lib-all
 
+$(abs_top_builddir)/libs:
+	mkdir -m 00755 -p "$@"
+
+libs-all: $(abs_top_builddir)/libs
+
 $(MAKE_TARGETS) include-all lib-all libs-all:
 	$(MAKE) -C "$(subst -all,,$@)" \
 		-f "$(abs_top_srcdir)/$(subst -all,,$@)/Makefile" all
Signature · 1 line
2.19.2
#1 lore raw

PATCH 1/1 Fix out-of-tree build.

Hi Cyril,

Quoted 9 lines

Ths fixes out of tree build by making the libs directory to be dependency of libs-all.

Not that the the lib and include directory are created as the side efect of the AC_CONFIG_FILES() and hence don't need to be created in the top-level Makefile.

This should be last fix for the numa build troubles.

Thanks for all todays fixes, nice to be green again!

Tested all 4, locally and via travis:
https://travis-ci.org/pevik/ltp/builds/503638096

Quoted 2 lines

I still have out-of-tree build failures in ffsb configure but I had enough autoconf and make for today...

:).

BTW That reminds me some problems with out-of-tree builds: missing files. It'd be nice to get back to it again.

Kind regards,
Petr

#2 lore raw

PATCH 1/1 Fix out-of-tree build.

Hi!

Quoted 4 lines
Quoted 1 line

This should be last fix for the numa build troubles.

Thanks for all todays fixes, nice to be green again!

Thanks for the testing, all four patches pushed now.

Signature · 2 lines
Cyril Hrubis
[email protected]