Skip to contentSkip to conversation

sunxi: Pine64-LTS: (Re-)enable USB 1.x support

PATCH New Andre Przywara 2 participants 3 messages Mar 9, 2019 – Mar 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sunxi: Pine64-LTS: (Re-)enable USB 1.x support

The Pine64-LTS defconfig is missing the CONFIG_USB_OHCI_HCD symbol, as this was added during the same time as this defconfig was merged. USB 1.x devices like USB keyboards don't work due to this.

Add the symbol to the defconfig as all the other boards do.

---
 configs/pine64-lts_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/pine64-lts_defconfig +1 -0
index fd3cdeec85..a833137787 100644
@@ -16,4 +16,5 @@ CONFIG_NR_DRAM_BANKS=1
 CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pine64-lts"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_OHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
Signature · 1 line
2.14.5
#1 lore raw

PATCH 1/1 sunxi: Pine64-LTS: (Re-)enable USB 1.x support

On 09/03/2019 01:03, Andre Przywara wrote:

Hi,

Quoted 5 lines

The Pine64-LTS defconfig is missing the CONFIG_USB_OHCI_HCD symbol, as this was added during the same time as this defconfig was merged. USB 1.x devices like USB keyboards don't work due to this.

Add the symbol to the defconfig as all the other boards do.

is there any chance we can get this for 2019.04, please?

All the other boards got this line added with commit 29d280c88a1f ("sunxi: usb: Switch to Generic host controllers"). It's just that the Pine64-LTS defconfig was authored before, but merged afterwards that it's missing this line.

Thanks!
Andre.

Quoted 16 lines
---
 configs/pine64-lts_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/pine64-lts_defconfig +1 -0
index fd3cdeec85..a833137787 100644
@@ -16,4 +16,5 @@ CONFIG_NR_DRAM_BANKS=1
 CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pine64-lts"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_OHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
#2 lore raw

PATCH 1/1 sunxi: Pine64-LTS: (Re-)enable USB 1.x support

Quoted 5 lines · André Przywara

On 09/03/2019 01:03, Andre Przywara wrote:

Hi,

Quoted 7 lines
Quoted 5 lines

The Pine64-LTS defconfig is missing the CONFIG_USB_OHCI_HCD symbol, as this was added during the same time as this defconfig was merged. USB 1.x devices like USB keyboards don't work due to this.

Add the symbol to the defconfig as all the other boards do.

is there any chance we can get this for 2019.04, please?

Merged for next, already.