gpu: amdkfd: fix a missing check of kmemdup
Subsystems (3)
PATCH 1/1 gpu: amdkfd: fix a missing check of kmemdup
kmemdup could fail and return NULL. To avoid null pointer dereference, the fix checkes its return value and returns ENOMEM upon failures.
Signed-off-by Kangjie Lu <[email protected]>
--- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/amdkfd/kfd_crat.c +3 -0
@@ -404,6 +404,9 @@ static int kfd_parse_subtype_iolink(struct crat_subtype_iolink *iolink,return -ENODEV ;/* same everything but the other direction */ props2 =kmemdup (props,sizeof (*props2),GFP_KERNEL ); +if (!props2) +return -ENOMEM ; + props2->node_from = id_to; props2->node_to = id_from; props2->kobj =NULL ;
Signature · 1 line
2.17.1
Quoted 7 lines · Kangjie Lu
kmemdup could fail and return NULL. To avoid null pointer dereference, the fix checkes its return value and returns ENOMEM upon failures.
This is a NULL-pointer dereference issue.
Can someone review this patch? Thanks.
Quoted 23 lines
Signed-off-by Kangjie Lu <[email protected]>---
drivers/gpu/drm/amd/amdkfd/kfd_crat.c| 3 +++1 file changed, 3 insertions(+)drivers/gpu/drm/amd/amdkfd/kfd_crat.c +3
-0@@ -404,6 +404,9 @@ static int kfd_parse_subtype_iolink(struct crat_subtype_iolink *iolink,return -ENODEV ;/* same everything but the other direction */ props2 =kmemdup (props,sizeof (*props2),GFP_KERNEL ); +if (!props2) +return -ENOMEM ; + props2->node_from = id_to; props2->node_to = id_from; props2->kobj =NULL ;Signature · 1 line
2.17.1