staging: aacraid: add SPDX GPL-2.0+ license identifier
Subsystems (2)
PATCH 1/2 staging: aacraid: add SPDX GPL-2.0+ license identifier
Add the SPDX GPL-2.0+ license identifier to fix checkpatch.pl warning Issue found by checkpatch.pl warning:
"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"
--- drivers/scsi/aacraid/aachba.c | 1 + 1 file changed, 1 insertion(+)
drivers/scsi/aacraid/aachba.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0+ /* * Adaptec AAC series RAID controller driver * (c) Copyright 2001 Red Hat Inc.
Signature · 1 line
2.20.1
PATCH 2/2 staging: aacraid: remove boilerplate license text
Remove boilerplate license text.
--- drivers/scsi/aacraid/aachba.c | 23 ----------------------- 1 file changed, 23 deletions(-)
drivers/scsi/aacraid/aachba.c +0 -23
@@ -1,33 +1,10 @@// SPDX-License-Identifier: GPL-2.0+ /* -* Adaptec AAC series RAID controller driver -* (c) Copyright 2001 Red Hat Inc. -* -* based on the old aacraid driver that is.. -* Adaptec aacraid device driver for Linux. * * Copyright (c) 2000-2010 Adaptec, Inc. * 2010-2015 PMC-Sierra, Inc. ([email protected]) * 2016-2017 Microsemi Corp. ([email protected]) * -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License as published by -* the Free Software Foundation; either version 2, or (at your option) -* any later version. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; see the file COPYING. If not, write to -* the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA. -* -* Module Name: -* aachba.c -* -* Abstract: Contains Interfaces to manage IOs. * */
Signature · 1 line
2.20.1
Re: [PATCH 2/2] staging: aacraid: remove boilerplate license text
Quoted 12 lines · Jules Irenge
Remove boilerplate license text.
Signed-off-by Jules Irenge <[email protected]>--- drivers/scsi/aacraid/aachba.c | 23 ----------------------- 1 file changed, 23 deletions(-)drivers/scsi/aacraid/aachba.c +0
-0
drivers/scsi/aacraid/aachba.c line 7
Quoted 7 lines
drivers/scsi/aacraid/aachba.c +0
-5@@ -1,33 +1,10 @@// SPDX-License-Identifier: GPL-2.0+ /* -* Adaptec AAC series RAID controller driver -* (c) Copyright 2001 Red Hat Inc. -* -* based on the old aacraid driver that is.. -* Adaptec aacraid device driver for Linux.
Those lines are not "boilerplate license text" :(
In fact, one of those lines is a copyright line, and lawyers get _VERY_ upset when you delete them (despite them not really meaning much, but that's a different discussion...)
Quoted 8 lines
drivers/scsi/aacraid/aachba.c +0
-3* * Copyright (c) 2000-2010 Adaptec, Inc. * 2010-2015 PMC-Sierra, Inc. ([email protected]) * 2016-2017 Microsemi Corp. ([email protected]) * -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License as published by -* the Free Software Foundation; either version 2, or (at your option)
drivers/scsi/aacraid/aachba.c line 25
Quoted 10 lines
drivers/scsi/aacraid/aachba.c +0
-10-* any later version. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; see the file COPYING. If not, write to -* the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.
These three paragraphs are what is "boilerplate license text", that is good to remove.
drivers/scsi/aacraid/aachba.c line 30
Quoted 5 lines
drivers/scsi/aacraid/aachba.c +0
-5-* -* Module Name: -* aachba.c -* -* Abstract: Contains Interfaces to manage IOs.
Those lines are not boilerplate.
thanks,
greg k-h
Re: [PATCH 2/2] staging: aacraid: remove boilerplate license text
Quoted 28 lines · Greg KH
Review
Quoted 8 lines · Jules Irenge
Remove boilerplate license text.
Signed-off-by Jules Irenge <[email protected]>--- drivers/scsi/aacraid/aachba.c | 23 ----------------------- 1 file changed, 23 deletions(-)(quoted diff) +0
-0
b/drivers/scsi/aacraid/aachba.cQuoted 17 lines
index
955ddb32aa40..e70b45a74d0a100644drivers/scsi/aacraid/aachba.c +0
-5@@ -1,33 +1,10 @@// SPDX-License-Identifier: GPL-2.0+ /* -* Adaptec AAC series RAID controller driver -* (c) Copyright 2001 Red Hat Inc. -* -* based on the old aacraid driver that is.. -* Adaptec aacraid device driver for Linux. Those lines are not "boilerplate license text" :(
In fact, one of those lines is a copyright line, and lawyers get _VERY_ upset when you delete them (despite them not really meaning much, but that's a different discussion...)
Thanks for letting me know. I take good note.
Quoted 30 lines
Quoted 29 lines
*
* Copyright (c) 2000-2010 Adaptec, Inc.
* 2010-2015 PMC-Sierra, Inc. ([email protected])
* 2016-2017 Microsemi Corp. ([email protected])
*
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2, or (at your option)
- * any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING. If not, write to
- * the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.These three paragraphs are what is "boilerplate license text", that is good to remove.
- *
- * Module Name:
- *aachba.c
- *
- * Abstract: Contains Interfaces to manage IOs.
Quoted 5 lines
Quoted 3 lines
Those lines are not boilerplate.
thanks,
Thanks for the above information. I will stick on staging
Kind regards,
Jules
Quoted 8 lines · Jules Irenge
Add the SPDX GPL-2.0+ license identifier to fix checkpatch.pl warning Issue found by checkpatch.pl warning:
"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"Signed-off-by Jules Irenge <[email protected]>--- drivers/scsi/aacraid/aachba.c | 1 + 1 file changed, 1 insertion(+)
Wait, why are you touching files outside of drivers/staging/? I can't do anything with a patch like this during the application process :(
Please stick to drivers/staging/ unless you are already working with a mentor.
thanks,
greg k-h