Skip to contentSkip to conversation

staging: speakup: remove unnecessary assignment statement before return

PATCH Superseded Himadri Pandya 3 participants 5 messages Mar 9, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: speakup: remove unnecessary assignment statement before return

Remove unnecessary assignment statement before return from function find_specifier_end. Issue found by Coccinelle.

---
 drivers/staging/speakup/i18n.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/speakup/i18n.c +1 -2
index ee240d36f947..a748eb8052d1 100644
@@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
 	input++;		/* Advance over %. */
 	input = skip_flags(input);
 	input = skip_width(input);
-	input = skip_conversion(input);
-	return input;
+	return skip_conversion(input);
 }
 
 /*
Signature · 1 line
2.17.1
#1 lore raw

Hello,

Please don't explicitly CC me and please don't put Coccinelle after PATCH. I see the patches. It is better to put in the commit log that Coccinelle was used to find or fix the problem than to overload the PATCh tag.

thanks,
julia

Quoted 32 lines · Himadri Pandya

Remove unnecessary assignment statement before return from function find_specifier_end. Issue found by Coccinelle.

---
 drivers/staging/speakup/i18n.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/speakup/i18n.c +1 -3
index ee240d36f947..a748eb8052d1 100644
@@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
 	input++;		/* Advance over %. */
 	input = skip_flags(input);
 	input = skip_width(input);
-	input = skip_conversion(input);
-	return input;
+	return skip_conversion(input);
 }
 
 /*
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190309080721.26121-1-himadri18.07%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

#2 lore raw

PATCH v2 1/1 staging: speakup: remove unnecessary assignment statement before return

In reply to Himadri Pandya

Remove unnecessary assignment statement before return from function find_specifier_end. Issue found by Coccinelle.

---
Changes in V2:
- Remove "Coccinelle" from patch tag

 drivers/staging/speakup/i18n.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/speakup/i18n.c +1 -2
index ee240d36f947..a748eb8052d1 100644
@@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
 	input++;		/* Advance over %. */
 	input = skip_flags(input);
 	input = skip_width(input);
-	input = skip_conversion(input);
-	return input;
+	return skip_conversion(input);
 }
 
 /*
Signature · 1 line
2.17.1
#3 lore raw

Himadri Pandya, le sam. 09 mars 2019 14:39:27 +0530, a ecrit:

Quoted 2 lines

Remove unnecessary assignment statement before return from function find_specifier_end. Issue found by Coccinelle.

Well, I have to say that for style I prefer the way it was: we apply several functions to the input variable, before returning it.

Quoted 25 lines

---
Changes in V2:
- Remove "Coccinelle" from patch tag

 drivers/staging/speakup/i18n.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/speakup/i18n.c +1 -2
index ee240d36f947..a748eb8052d1 100644
@@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
 	input++;		/* Advance over %. */
 	input = skip_flags(input);
 	input = skip_width(input);
-	input = skip_conversion(input);
-	return input;
+	return skip_conversion(input);
 }
 
 /*
Signature · 1 line
2.17.1
#4 lore raw
Quoted 7 lines · Samuel Thibault,

Himadri Pandya, le sam. 09 mars 2019 14:39:27 +0530, a ecrit:

Quoted 2 lines

Remove unnecessary assignment statement before return from function find_specifier_end. Issue found by Coccinelle.

Well, I have to say that for style I prefer the way it was: we apply several functions to the input variable, before returning it.

Okay. Thank you.

- Himadri

Quoted 38 lines

Review

Quoted 9 lines

---
Changes in V2:
- Remove "Coccinelle" from patch tag

 drivers/staging/speakup/i18n.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/speakup/i18n.c

Quoted 14 lines

index ee240d36f947..a748eb8052d1 100644

drivers/staging/speakup/i18n.c +1 -3
@@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
      input++;                /* Advance over %. */
      input = skip_flags(input);
      input = skip_width(input);
-     input = skip_conversion(input);
-     return input;
+     return skip_conversion(input);
 }
 
 /*
--
Quoted 2 lines

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected]. To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/20190309091133.uyhjrmiipm2rahnu%40function
.
For more options, visit https://groups.google.com/d/optout.