Skip to contentSkip to conversation

package/gnuradio: add optional log4cpp dependency

PATCH New Fabrice Fontaine 3 participants 3 messages Mar 8, 2019 – Mar 25, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/gnuradio: add optional log4cpp dependency

Currently, logger component is enabled if log4cpp is found

Moreover, it should be noted that log4cpp is now mandatory in latest upstream:
https://github.com/gnuradio/gnuradio/commit/d2428961205bf62e6b39966f040f98435e5cc2ed

---
 package/gnuradio/Config.in   | 6 ++++++
 package/gnuradio/gnuradio.mk | 7 +++++++
 2 files changed, 13 insertions(+)
package/gnuradio/Config.in +6 -0
index 3fdaea850e..6d0669779f 100644
@@ -56,6 +56,12 @@ config BR2_PACKAGE_GNURADIO_FEC
 	help
 	  FEC signal processing blocks
 
+config BR2_PACKAGE_GNURADIO_LOG
+	bool "gr-log support"
+	select BR2_PACKAGE_LOG4CPP
+	help
+	  Enable logger component
+
 config BR2_PACKAGE_GNURADIO_PYTHON
 	bool "python support"
 	depends on BR2_PACKAGE_PYTHON
package/gnuradio/gnuradio.mk +7 -0
index 202c2213a7..ef9723cb01 100644
@@ -115,6 +115,13 @@ else
 GNURADIO_CONF_OPTS += -DENABLE_GR_FILTER=OFF
 endif
 
+ifeq ($(BR2_PACKAGE_GNURADIO_LOG),y)
+GNURADIO_DEPENDENCIES += log4cpp
+GNURADIO_CONF_OPTS += -DENABLE_GR_LOG=ON
+else
+GNURADIO_CONF_OPTS += -DENABLE_GR_LOG=OFF
+endif
+
 ifeq ($(BR2_PACKAGE_GNURADIO_PYTHON),y)
 GNURADIO_DEPENDENCIES += python
 GNURADIO_CONF_OPTS += -DENABLE_PYTHON=ON
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 package/gnuradio: add optional log4cpp dependency

Quoted 11 lines · On Fri, 8 Mar 2019 22:39:56 +0100 Fabrice Fontaine…

Currently, logger component is enabled if log4cpp is found

Moreover, it should be noted that log4cpp is now mandatory in latest upstream:
https://github.com/gnuradio/gnuradio/commit/d2428961205bf62e6b39966f040f98435e5cc2ed

---
 package/gnuradio/Config.in   | 6 ++++++
 package/gnuradio/gnuradio.mk | 7 +++++++
 2 files changed, 13 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/gnuradio: add optional log4cpp dependency

In reply to Fabrice Fontaine
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Currently, logger component is enabled if log4cpp is found Moreover, it should be noted that log4cpp is now mandatory in latest upstream:
https://github.com/gnuradio/gnuradio/commit/d2428961205bf62e6b39966f040f98435e5cc2ed

Committed to 2019.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard