staging: media: zoran: remove unnecessary parentheses
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 staging: media: zoran: remove unnecessary parentheses
Remove unnecessary parentheses from right hand side of assignments.Suggested by Coccinelle.
--- drivers/staging/media/zoran/zoran_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/media/zoran/zoran_device.c +2 -2
@@ -496,7 +496,7 @@ zr36057_overlay (struct zoran *zr,KERN_ERR "%s: zr36057_overlay() - video_stride not aligned\n" , ZR_DEVNAME(zr)); - reg = (reg << ZR36057_VSSFGR_DispStride); + reg = reg << ZR36057_VSSFGR_DispStride; reg |= ZR36057_VSSFGR_VidOvf;/* clear overflow status */ btwrite (reg,ZR36057_VSSFGR );
@@ -1421,7 +1421,7 @@ zoran_irq (int irq, reg =0 ;if (zr->v4l_settings.height >BUZ_MAX_HEIGHT /2 ) reg += zr->v4l_settings.bytesperline; - reg = (reg << ZR36057_VSSFGR_DispStride); + reg = reg << ZR36057_VSSFGR_DispStride; reg |= ZR36057_VSSFGR_VidOvf; reg |= ZR36057_VSSFGR_SnapShot; reg |= ZR36057_VSSFGR_FrameGrab;
Signature · 1 line
2.17.1
Quoted 2 lines · Himadri Pandya
Remove unnecessary parentheses from right hand side of assignments.Suggested by Coccinelle.
Put a space after the period.
It seems that this driver is on the way out of the kernel, so it may not be worth working on it further.
git log --oneline drivers/staging/media/zoran/zoran_device.c
julia
Quoted 38 lines
Signed-off-by Himadri Pandya <[email protected]>--- drivers/staging/media/zoran/zoran_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/media/zoran/zoran_device.c +2
-3@@ -496,7 +496,7 @@ zr36057_overlay (struct zoran *zr,KERN_ERR "%s: zr36057_overlay() - video_stride not aligned\n" , ZR_DEVNAME(zr)); - reg = (reg << ZR36057_VSSFGR_DispStride); + reg = reg << ZR36057_VSSFGR_DispStride; reg |= ZR36057_VSSFGR_VidOvf;/* clear overflow status */ btwrite (reg,ZR36057_VSSFGR );@@ -1421,7 +1421,7 @@ zoran_irq (int irq, reg =0 ;if (zr->v4l_settings.height >BUZ_MAX_HEIGHT /2 ) reg += zr->v4l_settings.bytesperline; - reg = (reg << ZR36057_VSSFGR_DispStride); + reg = reg << ZR36057_VSSFGR_DispStride; reg |= ZR36057_VSSFGR_VidOvf; reg |= ZR36057_VSSFGR_SnapShot; reg |= ZR36057_VSSFGR_FrameGrab; --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190309173734.51405-1-himadri18.07%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
PATCH v2 1/1 staging: media: zoran: remove unnecessary parentheses
In reply to Himadri PandyaRemove unnecessary parentheses from right hand side of assignments. Suggested by Coccinelle.
---
Changes in V2:
- Add space after period in log message
--- drivers/staging/media/zoran/zoran_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/media/zoran/zoran_device.c +2 -2
@@ -496,7 +496,7 @@ zr36057_overlay (struct zoran *zr,KERN_ERR "%s: zr36057_overlay() - video_stride not aligned\n" , ZR_DEVNAME(zr)); - reg = (reg << ZR36057_VSSFGR_DispStride); + reg = reg << ZR36057_VSSFGR_DispStride; reg |= ZR36057_VSSFGR_VidOvf;/* clear overflow status */ btwrite (reg,ZR36057_VSSFGR );
@@ -1421,7 +1421,7 @@ zoran_irq (int irq, reg =0 ;if (zr->v4l_settings.height >BUZ_MAX_HEIGHT /2 ) reg += zr->v4l_settings.bytesperline; - reg = (reg << ZR36057_VSSFGR_DispStride); + reg = reg << ZR36057_VSSFGR_DispStride; reg |= ZR36057_VSSFGR_VidOvf; reg |= ZR36057_VSSFGR_SnapShot; reg |= ZR36057_VSSFGR_FrameGrab;
Signature · 1 line
2.17.1