Skip to contentSkip to conversation

iio: dac: mcp4725: add missing powerdown bits in store eeprom

PATCH Superseded Jean-Francois Dagenais 3 participants 4 messages Mar 6, 2019 – Mar 16, 2019 IIO

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: dac: mcp4725: add missing powerdown bits in store eeprom

When issuing the write DAC register and write eeprom command, the two powerdown bits (PD0 and PD1) are assumed by the chip to be present in the bytes sent. Leaving them at 0 implies "powerdown disabled" which is a different state that the current one. By adding the current state of the powerdown in the i2c write, the chip will correctly power-on exactly like as it is at the moment of store_eeprom call.

This is documented in MCP4725's datasheet, FIGURE 6-2: "Write Commands for DAC Input Register and EEPROM" and MCP4726's datasheet, FIGURE 6-3:
"Write All Memory Command".

---
 drivers/iio/dac/mcp4725.c | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/dac/mcp4725.c +1 -0
index 6ab1f23e5a79..97bb350d1e77 100644
@@ -98,6 +98,7 @@ static ssize_t mcp4725_store_eeprom(struct device *dev,
 
 	inoutbuf[0] = 0x60; /* write EEPROM */
 	inoutbuf[0] |= data->ref_mode << 3;
+	inoutbuf[0] |= data->powerdown ? ((data->powerdown_mode+1) << 1) : 0;
 	inoutbuf[1] = data->dac_value >> 4;
 	inoutbuf[2] = (data->dac_value & 0xf) << 4;
 
Signature · 1 line
2.11.0
maintainer
#1 lore raw

+Cc Peter.

Quoted 7 lines · On Wed, 6 Mar 2019 15:56:06 -0500 Jean-Francois Dagenais…

When issuing the write DAC register and write eeprom command, the two powerdown bits (PD0 and PD1) are assumed by the chip to be present in the bytes sent. Leaving them at 0 implies "powerdown disabled" which is a different state that the current one. By adding the current state of the powerdown in the i2c write, the chip will correctly power-on exactly like as it is at the moment of store_eeprom call.

Quoted 5 lines

This is documented in MCP4725's datasheet, FIGURE 6-2: "Write Commands for DAC Input Register and EEPROM" and MCP4726's datasheet, FIGURE 6-3:
"Write All Memory Command".

sounds fine to me, but I'd like to give Peter a chance to comment. Give me a poke if it turns out Peter is busy and doesn't get back to us in a week or two.

Thanks,

Jonathan

Quoted 16 lines
---
 drivers/iio/dac/mcp4725.c | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/dac/mcp4725.c +1 -0
index 6ab1f23e5a79..97bb350d1e77 100644
@@ -98,6 +98,7 @@ static ssize_t mcp4725_store_eeprom(struct device *dev,
 
 	inoutbuf[0] = 0x60; /* write EEPROM */
 	inoutbuf[0] |= data->ref_mode << 3;
+	inoutbuf[0] |= data->powerdown ? ((data->powerdown_mode+1) << 1) : 0;
 	inoutbuf[1] = data->dac_value >> 4;
 	inoutbuf[2] = (data->dac_value & 0xf) << 4;
 
#2 lore raw
Quoted 14 lines

+Cc Peter.

Quoted 11 lines

When issuing the write DAC register and write eeprom command, the two powerdown bits (PD0 and PD1) are assumed by the chip to be present in the bytes sent. Leaving them at 0 implies "powerdown disabled" which is a different state that the current one. By adding the current state of the powerdown in the i2c write, the chip will correctly power-on exactly like as it is at the moment of store_eeprom call.

This is documented in MCP4725's datasheet, FIGURE 6-2: "Write Commands for DAC Input Register and EEPROM" and MCP4726's datasheet, FIGURE 6-3:
"Write All Memory Command".

Quoted 5 lines
Quoted 1 line

sounds fine to me, but I'd like to give Peter a chance to comment. Give me a poke if it turns out Peter is busy and doesn't get back to us in a week or two.

I'd suggest whitespace around the + operator, otherwise

Quoted 17 lines
Quoted 16 lines
---
 drivers/iio/dac/mcp4725.c | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/dac/mcp4725.c +1 -0
index 6ab1f23e5a79..97bb350d1e77 100644
@@ -98,6 +98,7 @@ static ssize_t mcp4725_store_eeprom(struct device *dev,
 
 	inoutbuf[0] = 0x60; /* write EEPROM */
 	inoutbuf[0] |= data->ref_mode << 3;
+	inoutbuf[0] |= data->powerdown ? ((data->powerdown_mode+1) << 1) : 0;
 	inoutbuf[1] = data->dac_value >> 4;
 	inoutbuf[2] = (data->dac_value & 0xf) << 4;
 
Signature · 2 lines
Peter Meerwald-Stadler
Mobile: +43 664 24 44 418
maintainer
#3 lore raw
Quoted 13 lines · On Sun, 10 Mar 2019 12:31:16 +0100 (CET) Peter Meerwald-Stadler…
Quoted 13 lines

+Cc Peter.

Quoted 11 lines

When issuing the write DAC register and write eeprom command, the two powerdown bits (PD0 and PD1) are assumed by the chip to be present in the bytes sent. Leaving them at 0 implies "powerdown disabled" which is a different state that the current one. By adding the current state of the powerdown in the i2c write, the chip will correctly power-on exactly like as it is at the moment of store_eeprom call.

This is documented in MCP4725's datasheet, FIGURE 6-2: "Write Commands for DAC Input Register and EEPROM" and MCP4726's datasheet, FIGURE 6-3:
"Write All Memory Command".

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

sounds fine to me, but I'd like to give Peter a chance to comment. Give me a poke if it turns out Peter is busy and doesn't get back to us in a week or two.

I'd suggest whitespace around the + operator, otherwise

Good point, added...

Quoted 1 line

Applied to the fixes-togreg branch of iio.git and marked for stable. It's not super critical as fixes go but things are currently not quite doing what someone might expect.

Thanks,

Jonathan

Quoted 19 lines
Quoted 18 lines
Quoted 17 lines
---
 drivers/iio/dac/mcp4725.c | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/dac/mcp4725.c +1 -0
index 6ab1f23e5a79..97bb350d1e77 100644
@@ -98,6 +98,7 @@ static ssize_t mcp4725_store_eeprom(struct device *dev,
 
 	inoutbuf[0] = 0x60; /* write EEPROM */
 	inoutbuf[0] |= data->ref_mode << 3;
+	inoutbuf[0] |= data->powerdown ? ((data->powerdown_mode+1) << 1) : 0;
 	inoutbuf[1] = data->dac_value >> 4;
 	inoutbuf[2] = (data->dac_value & 0xf) << 4;