tty: fix read of tty->pgrp outside of ctrl_lock
PATCH 1/1 tty: fix read of tty->pgrp outside of ctrl_lock
The intention was clearly to use the tty_pgrp local variable rather than re-read tty->pgrp outside of ctrl_lock, so do that.
This bug was introduced by commit 2812d9e9fd94 ("tty: Combine SIGTTOU/SIGTTIN handling").
Signed-off-by David Emett <[email protected]>
--- drivers/tty/tty_jobctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/tty_jobctrl.c +1 -1
@@ -44,7 +44,7 @@ int __tty_check_change(struct tty_struct *tty, int sig) tty_pgrp = tty->pgrp;spin_unlock_irqrestore (&tty->ctrl_lock, flags); -if (tty_pgrp && pgrp != tty->pgrp) { +if (tty_pgrp && pgrp != tty_pgrp) {if (is_ignored (sig)) {if (sig ==SIGTTIN ) ret = -EIO ;
Signature · 1 line
2.17.1