Fix spinlock_t definition without comment warning
PATCH 1/1 Fix spinlock_t definition without comment warning
Fix checkpatch issue: "CHECK: spinlock_t definition without comment".
Signed-off-by Jules Irenge <[email protected]>
--- drivers/staging/gdm724x/gdm_mux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/gdm724x/gdm_mux.h +1 -1
@@ -60,7 +60,7 @@ struct rx_cxt {struct list_head to_host_list;struct list_head rx_submit_list;struct list_head rx_free_list; -spinlock_t to_host_lock; +spinlock_t to_host_lock;/* spinlock for to_host command handling */ spinlock_t submit_list_lock;spinlock_t free_list_lock; };
Signature · 1 line
2.20.1
Greg KH
maintainerQuoted 12 lines · Jules Irenge
Fix checkpatch issue: "CHECK:
spinlock_tdefinition without comment".Signed-off-by Jules Irenge <[email protected]>--- drivers/staging/gdm724x/gdm_mux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/gdm724x/gdm_mux.h +0
-0
drivers/staging/gdm724x/gdm_mux.h struct rx_cxt { · line 63
Quoted 5 lines
drivers/staging/gdm724x/gdm_mux.h +1
-1@@ -60,7 +60,7 @@ struct rx_cxt {struct list_head to_host_list;struct list_head rx_submit_list;struct list_head rx_free_list; -spinlock_t to_host_lock; +spinlock_t to_host_lock;/* spinlock for to_host command handling */
Are you sure about this? Please document why this is true somehow in the changelog text so we feel good about it :)
Also, the subject: needs to be fixed up to show the subsystem (staging), and the driver name. See the other patches on the mailing list for the proper format.
thanks,
greg k-h
Quoted 6 lines
drivers/staging/gdm724x/gdm_mux.h +0
-0spinlock_t submit_list_lock;spinlock_t free_list_lock; };Signature · 1 line
2.20.1