watchdog: fix compile time error of pretimeout governors
PATCH 1/1 watchdog: fix compile time error of pretimeout governors
CONFIG_WATCHDOG_PRETIMEOUT_GOV build symbol adds watchdog_pretimeout.o object to watchdog.o, the latter is compiled only if CONFIG_WATCHDOG_CORE is selected, so it rightfully makes sense to add it as a dependency.
The change fixes the next compilation errors, if CONFIG_WATCHDOG_CORE=n and CONFIG_WATCHDOG_PRETIMEOUT_GOV=y are selected:
drivers/watchdog/pretimeout_noop.o: In function `watchdog_gov_noop_register':
drivers/watchdog/pretimeout_noop.c:35: undefined reference to watchdog_register_governor' drivers/watchdog/pretimeout_noop.o: In function watchdog_gov_noop_unregister':
drivers/watchdog/pretimeout_noop.c:40: undefined reference to `watchdog_unregister_governor'
drivers/watchdog/pretimeout_panic.o: In function `watchdog_gov_panic_register':
drivers/watchdog/pretimeout_panic.c:35: undefined reference to watchdog_register_governor' drivers/watchdog/pretimeout_panic.o: In function watchdog_gov_panic_unregister':
drivers/watchdog/pretimeout_panic.c:40: undefined reference to `watchdog_unregister_governor'
--- drivers/watchdog/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/watchdog/Kconfig +1 -0
@@ -2028,6 +2028,7 @@ comment "Watchdog Pretimeout Governors" config WATCHDOG_PRETIMEOUT_GOV bool "Enable watchdog pretimeout governors" + depends on WATCHDOG_CORE help The option allows to select watchdog pretimeout governors.
Signature · 1 line
2.20.1
Quoted 12 lines · Vladimir Zapolskiy
CONFIG_WATCHDOG_PRETIMEOUT_GOVbuild symbol adds watchdog_pretimeout.o object to watchdog.o, the latter is compiled only ifCONFIG_WATCHDOG_COREis selected, so it rightfully makes sense to add it as a dependency.The change fixes the next compilation errors, if
CONFIG_WATCHDOG_CORE=nandCONFIG_WATCHDOG_PRETIMEOUT_GOV=yare selected:
drivers/watchdog/pretimeout_noop.o: In function `watchdog_gov_noop_register':
drivers/watchdog/pretimeout_noop.c:35: undefined reference towatchdog_register_governor' drivers/watchdog/pretimeout_noop.o: In functionwatchdog_gov_noop_unregister':
drivers/watchdog/pretimeout_noop.c:40: undefined reference to `watchdog_unregister_governor'
Quoted 8 lines
drivers/watchdog/pretimeout_panic.o: In function `watchdog_gov_panic_register':
drivers/watchdog/pretimeout_panic.c:35: undefined reference towatchdog_register_governor' drivers/watchdog/pretimeout_panic.o: In functionwatchdog_gov_panic_unregister':
drivers/watchdog/pretimeout_panic.c:40: undefined reference to `watchdog_unregister_governor'Reported-by Kuo, Hsuan-Chi <[email protected]>Fixes ff84136cb6a4 ("watchdog: add watchdog pretimeout governor framework")Signed-off-by Vladimir Zapolskiy <[email protected]>
Quoted 17 lines
--- drivers/watchdog/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/watchdog/Kconfig +1
-0@@ -2028,6 +2028,7 @@ comment "Watchdog Pretimeout Governors" config WATCHDOG_PRETIMEOUT_GOV bool "Enable watchdog pretimeout governors" + depends on WATCHDOG_CORE help The option allows to select watchdog pretimeout governors.