Skip to contentSkip to conversation

thunderbolt: property: fix a NULL pointer dereference

PATCH Applied Kangjie Lu 2 participants 2 messages Mar 12, 2019 – Mar 13, 2019 Thunderbolt driver

lore
Share & tools
lore

Kangjie Lu

author
#0 lore raw

PATCH 1/1 thunderbolt: property: fix a NULL pointer dereference

In case kzalloc fails, the fix releases resources and returns -ENOMEM to avoid the NULL pointer dereference.

---
 drivers/thunderbolt/property.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/thunderbolt/property.c +5 -0
index b2f0d6386cee..ee76449524a3 100644
@@ -548,6 +548,11 @@ int tb_property_add_data(struct tb_property_dir *parent, const char *key,
 
 	property->length = size / 4;
 	property->value.data = kzalloc(size, GFP_KERNEL);
+	if (!property->value.data) {
+		kfree(property);
+		return -ENOMEM;
+	}
+
 	memcpy(property->value.data, buf, buflen);
 
 	list_add_tail(&property->list, &parent->properties);
Signature · 1 line
2.17.1