Skip to contentSkip to conversation

pwm: tiehrpwm: Enable EHRPWM for AM654 SoCs

PATCH Applied Vignesh Raghavendra 3 participants 6 messages Mar 12, 2019 – Mar 20, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover pwm: tiehrpwm: Enable EHRPWM for AM654 SoCs

This series adds support for EHRPWM IP on TI AM654 SoC

Vignesh Raghavendra (2):
dt-bindings: pwm: tiehrpwm: Add TI AM654 SoC specific compatible
pwm: Kconfig: Enable ehrpwm driver to be compiled for ARCH_K3

 Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt | 1 +
 drivers/pwm/Kconfig                                    | 5 ++---
 2 files changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/2 dt-bindings: pwm: tiehrpwm: Add TI AM654 SoC specific compatible

Add a new compatible string "ti,am654-ehrpwm" to support EHRPWM IP on TI AM654 SoC.

---
 Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt +1 -0
index 944fe356bb45..31c4577157dd 100644
@@ -4,6 +4,7 @@ Required properties:
 - compatible: Must be "ti,<soc>-ehrpwm".
   for am33xx  - compatible = "ti,am3352-ehrpwm", "ti,am33xx-ehrpwm";
   for am4372  - compatible = "ti,am4372-ehrpwm", "ti-am3352-ehrpwm", "ti,am33xx-ehrpwm";
+  for am654   - compatible = "ti,am654-ehrpwm", "ti-am3352-ehrpwm";
   for da850   - compatible = "ti,da850-ehrpwm", "ti-am3352-ehrpwm", "ti,am33xx-ehrpwm";
   for dra746 - compatible = "ti,dra746-ehrpwm", "ti-am3352-ehrpwm";
 - #pwm-cells: should be 3. See pwm.txt in this directory for a description of
Signature · 1 line
2.21.0
#2 lore raw

PATCH 2/2 pwm: Kconfig: Enable ehrpwm driver to be compiled for ARCH_K3

In reply to Vignesh Raghavendra

K3 devices have the same EHRPWM IP as OMAP SoCs. Enable driver to be built for K3 devices. Also, drop reference to AM33xx in help text, as IP is found on multiple TI SoCs.

---
 drivers/pwm/Kconfig | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/pwm/Kconfig +2 -3
index 54f8238aac0d..c054bd1dba36 100644
@@ -467,10 +467,9 @@ config  PWM_TIECAP
 
 config  PWM_TIEHRPWM
 	tristate "EHRPWM PWM support"
-	depends on ARCH_OMAP2PLUS || ARCH_DAVINCI_DA8XX
+	depends on ARCH_OMAP2PLUS || ARCH_DAVINCI_DA8XX || ARCH_K3
 	help
-	  PWM driver support for the EHRPWM controller found on AM33XX
-	  TI SOC
+	  PWM driver support for the EHRPWM controller found on TI SOCs
 
 	  To compile this driver as a module, choose M here: the module
 	  will be called pwm-tiehrpwm.
Signature · 1 line
2.21.0
#3 lore raw

Re: [PATCH 2/2] pwm: Kconfig: Enable ehrpwm driver to be compiled for ARCH_K3

Quoted 14 lines · Vignesh Raghavendra

K3 devices have the same EHRPWM IP as OMAP SoCs. Enable driver to be built for K3 devices. Also, drop reference to AM33xx in help text, as IP is found on multiple TI SoCs.

---
 drivers/pwm/Kconfig | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/pwm/Kconfig +0 -0
index 54f8238aac0d..c054bd1dba36 100644

drivers/pwm/Kconfig config PWM_TIECAP · line 472

Quoted 9 lines
drivers/pwm/Kconfig +2 -3
@@ -467,10 +467,9 @@ config  PWM_TIECAP
 
 config  PWM_TIEHRPWM
 	tristate "EHRPWM PWM support"
-	depends on ARCH_OMAP2PLUS || ARCH_DAVINCI_DA8XX
+	depends on ARCH_OMAP2PLUS || ARCH_DAVINCI_DA8XX || ARCH_K3
 	help
-	  PWM driver support for the EHRPWM controller found on AM33XX
-	  TI SOC
+	  PWM driver support for the EHRPWM controller found on TI SOCs

It would be great to be able to compile this driver with COMPILE_TEST.

Quoted 1 line

From a quick look the following would be appropriate:

	depends on ARCH_OMAP2PLUS || ARCH_DAVINCI_DA8XX || ARCH_K3 || COMPILE_TEST
	depends on HAVE_CLK && HAS_IOMEM

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#4 lore raw

Re: [PATCH 2/2] pwm: Kconfig: Enable ehrpwm driver to be compiled for ARCH_K3

Hi,

Quoted 28 lines · Uwe Kleine-König
Quoted 14 lines · Vignesh Raghavendra

K3 devices have the same EHRPWM IP as OMAP SoCs. Enable driver to be built for K3 devices. Also, drop reference to AM33xx in help text, as IP is found on multiple TI SoCs.

---
 drivers/pwm/Kconfig | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/pwm/Kconfig +0 -0
index 54f8238aac0d..c054bd1dba36 100644

drivers/pwm/Kconfig config PWM_TIECAP · line 472

Quoted 9 lines
drivers/pwm/Kconfig +2 -3
@@ -467,10 +467,9 @@ config  PWM_TIECAP
 
 config  PWM_TIEHRPWM
 	tristate "EHRPWM PWM support"
-	depends on ARCH_OMAP2PLUS || ARCH_DAVINCI_DA8XX
+	depends on ARCH_OMAP2PLUS || ARCH_DAVINCI_DA8XX || ARCH_K3
 	help
-	  PWM driver support for the EHRPWM controller found on AM33XX
-	  TI SOC
+	  PWM driver support for the EHRPWM controller found on TI SOCs

It would be great to be able to compile this driver with COMPILE_TEST. From a quick look the following would be appropriate:

Quoted 3 lines
	depends on ARCH_OMAP2PLUS || ARCH_DAVINCI_DA8XX || ARCH_K3 || COMPILE_TEST
	depends on HAVE_CLK && HAS_IOMEM

Thanks for the suggestion! I will send a separate patch on top of this series to enable COMPILE TEST for this driver and other TI PWM drivers.

Quoted 3 lines

Best regards
Uwe

Signature · 7 lines
Regards
Vignesh

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#5 lore raw
In reply to Vignesh Raghavendra
Quoted 9 lines · Vignesh Raghavendra

This series adds support for EHRPWM IP on TI AM654 SoC

Vignesh Raghavendra (2):
dt-bindings: pwm: tiehrpwm: Add TI AM654 SoC specific compatible
pwm: Kconfig: Enable ehrpwm driver to be compiled for ARCH_K3

 Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt | 1 +
 drivers/pwm/Kconfig                                    | 5 ++---
 2 files changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

Thierry

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel