i40e: print PCI vendor and device ID during probe
Subsystems (3)
PATCH 1/1 i40e: print PCI vendor and device ID during probe
Printing each devices PCI vendor and device ID has the advantage of easily revealing what hardware we're dealing with exactly. It's no longer necessary to match the PCI bus information to the lspci output.
Helps with bug reports where no lspci output is available.
Output before
i40e 0000:08:00.0: fw 6.1.49420 api 1.7 nvm 6.80 0x80003c64 1.2007.0
and after
i40e 0000:08:00.0: fw 6.1.49420 api 1.7 nvm 6.80 0x80003c64 1.2007.0 [8086:1572] [8086:0004]
--- drivers/net/ethernet/intel/i40e/i40e_main.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_main.c +4 -3
@@ -14023,11 +14023,12 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent) }i40e_get_oem_version (hw); -/* provide nvm, fw, api versions */ -dev_info (&pdev->dev,"fw %d.%d.%05d api %d.%d nvm %s\n" , +/* provide nvm, fw, api versions, vendor:device id, subsys vendor:device id */ +dev_info (&pdev->dev,"fw %d.%d.%05d api %d.%d nvm %s [%04x:%04x] [%04x:%04x]\n" , hw->aq.fw_maj_ver, hw->aq.fw_min_ver, hw->aq.fw_build, hw->aq.api_maj_ver, hw->aq.api_min_ver, -i40e_nvm_version_str (hw)); +i40e_nvm_version_str (hw), hw->vendor_id, hw->device_id, + hw->subsystem_vendor_id, hw->subsystem_device_id);if (hw->aq.api_maj_ver ==I40E_FW_API_VERSION_MAJOR && hw->aq.api_min_ver >I40E_FW_MINOR_VERSION (hw))
Signature · 1 line
2.20.1
Quoted 20 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Stefan Assmann
Sent: Tuesday, March 12, 2019 4:18 AM
To: intel-wired-lan at lists.osuosl.org
Cc: netdev at vger.kernel.org; davem at davemloft.net; sassmann at kpanic.de
Subject: [Intel-wired-lan] [PATCH] i40e: print PCI vendor and device ID during probePrinting each device's PCI vendor and device ID has the advantage of easily revealing what hardware we're dealing with exactly. It's no longer necessary to match the PCI bus information to the lspci output.
Helps with bug reports where no lspci output is available.
Output before
i40e 0000:08:00.0: fw 6.1.49420 api 1.7 nvm 6.800x80003c641.2007.0 and after i40e 0000:08:00.0: fw 6.1.49420 api 1.7 nvm 6.800x80003c641.2007.0 [8086:1572] [8086:0004]
Quoted 4 lines
Signed-off-by Stefan Assmann <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e_main.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)