Skip to contentSkip to conversation

net/vdev_netvsc: fix erronous cast

PATCH Applied Stephen Hemminger 3 participants 5 messages Mar 13, 2019 – Mar 25, 2019 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/vdev_netvsc: fix erronous cast

The return value from bus->find_device is a rte_device which is not safe to cast to a rte_vdev_device structure. It doesn't really matter since only being checked for NULL but static checkers might find a bug here.

---
 drivers/net/vdev_netvsc/vdev_netvsc.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/net/vdev_netvsc/vdev_netvsc.c +4 -3
index ba63fac2a598..801f54c96e01 100644
@@ -808,7 +808,7 @@ vdev_netvsc_cmp_rte_device(const struct rte_device *dev1,
 static void
 vdev_netvsc_scan_callback(__rte_unused void *arg)
 {
-	struct rte_vdev_device *dev;
+	struct rte_device *dev;
 	struct rte_devargs *devargs;
 	struct rte_bus *vbus = rte_bus_find_by_name("vdev");
 
@@ -816,8 +816,9 @@ vdev_netvsc_scan_callback(__rte_unused void *arg)
 		if (!strncmp(devargs->name, VDEV_NETVSC_DRIVER_NAME,
 			     VDEV_NETVSC_DRIVER_NAME_LEN))
 			return;
-	dev = (struct rte_vdev_device *)vbus->find_device(NULL,
-		vdev_netvsc_cmp_rte_device, VDEV_NETVSC_DRIVER_NAME);
+
+	dev = vbus->find_device(NULL, vdev_netvsc_cmp_rte_device,
+				VDEV_NETVSC_DRIVER_NAME);
 	if (dev)
 		return;
 	if (rte_devargs_add(RTE_DEVTYPE_VIRTUAL, VDEV_NETVSC_DRIVER_NAME))
Signature · 1 line
2.17.1
#1 lore raw

Hi

From: Stephen Hemminger

Quoted 5 lines

The return value from bus->find_device is a rte_device which is not safe to cast to a rte_vdev_device structure.
It doesn't really matter since only being checked for NULL but static checkers might find a bug here.

Fix line is missing.

Quoted 19 lines
---
 drivers/net/vdev_netvsc/vdev_netvsc.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/net/vdev_netvsc/vdev_netvsc.c +0 -0
index ba63fac2a598..801f54c96e01 100644
@@ -808,7 +808,7 @@ vdev_netvsc_cmp_rte_device(const struct

rte_device *dev1, static void vdev_netvsc_scan_callback(__rte_unused void *arg) {

drivers/net/vdev_netvsc/vdev_netvsc.c +1 -1
-	struct rte_vdev_device *dev;
+	struct rte_device *dev;
 	struct rte_devargs *devargs;
 	struct rte_bus *vbus = rte_bus_find_by_name("vdev");

drivers/net/vdev_netvsc/vdev_netvsc.c vdev_netvsc_scan_callback(__rte_unused void *arg) · line 822

Quoted 9 lines
drivers/net/vdev_netvsc/vdev_netvsc.c +3 -2
@@ -816,8 +816,9 @@ vdev_netvsc_scan_callback(__rte_unused void *arg)
 		if (!strncmp(devargs->name, VDEV_NETVSC_DRIVER_NAME,
 			     VDEV_NETVSC_DRIVER_NAME_LEN))
 			return;
-	dev = (struct rte_vdev_device *)vbus->find_device(NULL,
-		vdev_netvsc_cmp_rte_device,
 VDEV_NETVSC_DRIVER_NAME);
+
+	dev = vbus->find_device(NULL, vdev_netvsc_cmp_rte_device,
+				VDEV_NETVSC_DRIVER_NAME);

Since the device must be vdev here,
It is better to use explicit cast to make the checker happy.

Quoted 6 lines
drivers/net/vdev_netvsc/vdev_netvsc.c +0 -0
 	if (dev)
 		return;

if (rte_devargs_add(RTE_DEVTYPE_VIRTUAL,
VDEV_NETVSC_DRIVER_NAME))
--
2.17.1

#2 lore raw
Quoted 29 lines · On Thu, 14 Mar 2019 11:13:10 +0000 Matan Azrad <[email protected]> wrote:

Hi

From: Stephen Hemminger

Quoted 5 lines

The return value from bus->find_device is a rte_device which is not safe to cast to a rte_vdev_device structure.
It doesn't really matter since only being checked for NULL but static checkers might find a bug here.

Fix line is missing.

Quoted 18 lines
---
 drivers/net/vdev_netvsc/vdev_netvsc.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/net/vdev_netvsc/vdev_netvsc.c +0 -0
index ba63fac2a598..801f54c96e01 100644
@@ -808,7 +808,7 @@ vdev_netvsc_cmp_rte_device(const struct

rte_device *dev1, static void vdev_netvsc_scan_callback(__rte_unused void *arg) {

drivers/net/vdev_netvsc/vdev_netvsc.c +1 -1
-	struct rte_vdev_device *dev;
+	struct rte_device *dev;
 	struct rte_devargs *devargs;
 	struct rte_bus *vbus = rte_bus_find_by_name("vdev");
Quoted 13 lines

drivers/net/vdev_netvsc/vdev_netvsc.c vdev_netvsc_scan_callback(__rte_unused void *arg) · line 822

Quoted 10 lines
drivers/net/vdev_netvsc/vdev_netvsc.c +3 -2
@@ -816,8 +816,9 @@ vdev_netvsc_scan_callback(__rte_unused void *arg)
 		if (!strncmp(devargs->name, VDEV_NETVSC_DRIVER_NAME,
 			     VDEV_NETVSC_DRIVER_NAME_LEN))
 			return;
-	dev = (struct rte_vdev_device *)vbus->find_device(NULL,
-		vdev_netvsc_cmp_rte_device,
 VDEV_NETVSC_DRIVER_NAME);
+
+	dev = vbus->find_device(NULL, vdev_netvsc_cmp_rte_device,
+				VDEV_NETVSC_DRIVER_NAME);  

Since the device must be vdev here,
It is better to use explicit cast to make the checker happy.

The cast is converting from rte_device to rte_vdev_device which incorrect.

The device returned by vbus->find_device is a rte_device not a rte_vdev_device:

vbus->find_device points to rte_vdev_find_device

struct rte_device *
rte_vdev_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,
const void *data)

but definition of rte_vdev_device is:

struct rte_vdev_device {
TAILQ_ENTRY(rte_vdev_device) next; /**< Next attached vdev */
struct rte_device device; /**< Inherit core device */
};

The only safe way to get rte_vdev_device would be to use container_of().

	dev = vbus->find_device(NULL, vdev_netvsc_cmp_rte_device,
				VDEV_NETVSC_DRIVER_NAME);
	vdev = dev ? container_of(dev, struct rte_vdev_device, device) : NULL;

But as the PATCH demonstrated, this is not necessary.

#3 lore raw

Hi

From: Stephen Hemminger

Quoted 63 lines
Quoted 30 lines

Hi

From: Stephen Hemminger

Quoted 5 lines

The return value from bus->find_device is a rte_device which is not safe to cast to a rte_vdev_device structure.
It doesn't really matter since only being checked for NULL but static checkers might find a bug here.

Fix line is missing.

Quoted 19 lines
---
 drivers/net/vdev_netvsc/vdev_netvsc.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/net/vdev_netvsc/vdev_netvsc.c +0 -0
index ba63fac2a598..801f54c96e01 100644
@@ -808,7 +808,7 @@ vdev_netvsc_cmp_rte_device(const struct

rte_device *dev1, static void
vdev_netvsc_scan_callback(__rte_unused
void *arg) {

drivers/net/vdev_netvsc/vdev_netvsc.c +1 -1
-	struct rte_vdev_device *dev;
+	struct rte_device *dev;
 	struct rte_devargs *devargs;
 	struct rte_bus *vbus = rte_bus_find_by_name("vdev");
Quoted 1 line

drivers/net/vdev_netvsc/vdev_netvsc.c vdev_netvsc_scan_callback(__rte_unused void

Quoted 1 line
drivers/net/vdev_netvsc/vdev_netvsc.c +0 -0
@@ -816,8 +816,9 @@ vdev_netvsc_scan_callback(__rte_unused void

*arg)

Quoted 4 lines
Quoted 4 lines
drivers/net/vdev_netvsc/vdev_netvsc.c +0 -1
 		if (!strncmp(devargs->name, VDEV_NETVSC_DRIVER_NAME,
 			     VDEV_NETVSC_DRIVER_NAME_LEN))
 			return;
-	dev = (struct rte_vdev_device *)vbus->find_device(NULL,
Quoted 8 lines

drivers/net/vdev_netvsc/vdev_netvsc.c vdev_netvsc_scan_callback(__rte_unused void *arg) · line 821

Quoted 5 lines
drivers/net/vdev_netvsc/vdev_netvsc.c +3 -1
-		vdev_netvsc_cmp_rte_device,
 VDEV_NETVSC_DRIVER_NAME);
+
+	dev = vbus->find_device(NULL, vdev_netvsc_cmp_rte_device,
+				VDEV_NETVSC_DRIVER_NAME);

Since the device must be vdev here,
It is better to use explicit cast to make the checker happy.

The cast is converting from rte_device to rte_vdev_device which incorrect.

The device returned by vbus->find_device is a rte_device not a rte_vdev_device:

vbus->find_device points to rte_vdev_find_device

struct rte_device *
rte_vdev_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,
const void *data)

but definition of rte_vdev_device is:

struct rte_vdev_device {
TAILQ_ENTRY(rte_vdev_device) next; /**< Next attached vdev */
struct rte_device device; /**< Inherit core device */
};

Quoted 8 lines

The only safe way to get rte_vdev_device would be to use container_of().

	dev = vbus->find_device(NULL, vdev_netvsc_cmp_rte_device,
				VDEV_NETVSC_DRIVER_NAME);
	vdev = dev ? container_of(dev, struct rte_vdev_device, device) :

NULL;

But as the PATCH demonstrated, this is not necessary.

Yes, you right.
Please add fix line to the patch + stable line.

Matan

Acked-by Matan Azrad Applied
#4 lore raw
Quoted 73 lines · Matan Azrad

Hi

From: Stephen Hemminger

Quoted 70 lines
Quoted 30 lines

Hi

From: Stephen Hemminger

Quoted 5 lines

The return value from bus->find_device is a rte_device which is not safe to cast to a rte_vdev_device structure.
It doesn't really matter since only being checked for NULL but static checkers might find a bug here.

Fix line is missing.

Quoted 19 lines
---
 drivers/net/vdev_netvsc/vdev_netvsc.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/net/vdev_netvsc/vdev_netvsc.c +0 -0
index ba63fac2a598..801f54c96e01 100644
@@ -808,7 +808,7 @@ vdev_netvsc_cmp_rte_device(const struct

rte_device *dev1, static void
vdev_netvsc_scan_callback(__rte_unused
void *arg) {

drivers/net/vdev_netvsc/vdev_netvsc.c +1 -1
-	struct rte_vdev_device *dev;
+	struct rte_device *dev;
 	struct rte_devargs *devargs;
 	struct rte_bus *vbus = rte_bus_find_by_name("vdev");
Quoted 1 line

drivers/net/vdev_netvsc/vdev_netvsc.c vdev_netvsc_scan_callback(__rte_unused void

Quoted 1 line
drivers/net/vdev_netvsc/vdev_netvsc.c +0 -0
@@ -816,8 +816,9 @@ vdev_netvsc_scan_callback(__rte_unused void

*arg)

Quoted 4 lines
Quoted 4 lines
drivers/net/vdev_netvsc/vdev_netvsc.c +0 -1
 		if (!strncmp(devargs->name, VDEV_NETVSC_DRIVER_NAME,
 			     VDEV_NETVSC_DRIVER_NAME_LEN))
 			return;
-	dev = (struct rte_vdev_device *)vbus->find_device(NULL,
Quoted 8 lines

drivers/net/vdev_netvsc/vdev_netvsc.c vdev_netvsc_scan_callback(__rte_unused void *arg) · line 821

Quoted 5 lines
drivers/net/vdev_netvsc/vdev_netvsc.c +3 -1
-		vdev_netvsc_cmp_rte_device,
 VDEV_NETVSC_DRIVER_NAME);
+
+	dev = vbus->find_device(NULL, vdev_netvsc_cmp_rte_device,
+				VDEV_NETVSC_DRIVER_NAME);

Since the device must be vdev here,
It is better to use explicit cast to make the checker happy.

The cast is converting from rte_device to rte_vdev_device which incorrect.

The device returned by vbus->find_device is a rte_device not a rte_vdev_device:

vbus->find_device points to rte_vdev_find_device

struct rte_device *
rte_vdev_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,
const void *data)

but definition of rte_vdev_device is:

struct rte_vdev_device {
TAILQ_ENTRY(rte_vdev_device) next; /**< Next attached vdev */
struct rte_device device; /**< Inherit core device */
};

The only safe way to get rte_vdev_device would be to use container_of().

	dev = vbus->find_device(NULL, vdev_netvsc_cmp_rte_device,
				VDEV_NETVSC_DRIVER_NAME);
	vdev = dev ? container_of(dev, struct rte_vdev_device, device) :

NULL;

Quoted 4 lines
Quoted 1 line

But as the PATCH demonstrated, this is not necessary.

Yes, you right.
Please add fix line to the patch + stable line.

Adding explicit cast from Matan:

    Fixes: 56252de779a6 ("net/vdev_netvsc: add automatic probing")
    Cc: [email protected]

Applied to dpdk-next-net/master, thanks.