Fix checking multiple modules error in _have_modules()
PATCH 1/1 Fix checking multiple modules error in _have_modules()
Signed-off-by Xiao Liang <[email protected]>
--- common/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
common/rc +1 -1
@@ -33,7 +33,7 @@ _have_modules() { local module for module in "$@"; do - if ! modprobe -n -q "$1"; then + if ! modprobe -n -q "$module"; then missing+=("$module") fi done
Signature · 1 line
2.17.2
Omar Sandoval
AppliedOn Wed, Mar 13, 2019 at 03:05:11PM +0800, Xiao Liang wrote:
Applied, thanks!
Quoted 21 lines
Signed-off-by Xiao Liang <[email protected]>--- common/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/rc +1
-1@@ -33,7 +33,7 @@ _have_modules() { local module for module in "$@"; do - if ! modprobe -n -q "$1"; then + if ! modprobe -n -q "$module"; then missing+=("$module") fi doneSignature · 1 line
2.17.2
Looks good.
Reviewed-by Chaitanya Kulkarni <[email protected]>
Quoted 19 lines · Xiao Liang
Signed-off-by Xiao Liang <[email protected]>--- common/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/rc +1
-1@@ -33,7 +33,7 @@ _have_modules() { local module for module in "$@"; do - if ! modprobe -n -q "$1"; then + if ! modprobe -n -q "$module"; then missing+=("$module") fi done