Skip to contentSkip to conversation

Fix checking multiple modules error in _have_modules()

PATCH Applied Xiao Liang 3 participants 3 messages Mar 13, 2019 Block layer

lore
Share & tools
lore

Xiao Liang

author
#0 lore raw

PATCH 1/1 Fix checking multiple modules error in _have_modules()

---
 common/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/rc +1 -1
index 0c354a2..71e27c3 100644
@@ -33,7 +33,7 @@ _have_modules() {
 	local module
 
 	for module in "$@"; do
-		if ! modprobe -n -q "$1"; then
+		if ! modprobe -n -q "$module"; then
 			missing+=("$module")
 		fi
 	done
Signature · 1 line
2.17.2
#1 lore raw

On Wed, Mar 13, 2019 at 03:05:11PM +0800, Xiao Liang wrote:

Applied, thanks!

Quoted 21 lines
---
 common/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/rc +1 -1
index 0c354a2..71e27c3 100644
@@ -33,7 +33,7 @@ _have_modules() {
 	local module
 
 	for module in "$@"; do
-		if ! modprobe -n -q "$1"; then
+		if ! modprobe -n -q "$module"; then
 			missing+=("$module")
 		fi
 	done
Signature · 1 line
2.17.2
Reviewed-by on v1 1/1
#2 lore raw
In reply to Xiao Liang

Looks good.

Quoted 19 lines · Xiao Liang
---
  common/rc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
common/rc +1 -1
index 0c354a2..71e27c3 100644
@@ -33,7 +33,7 @@ _have_modules() {
  	local module
 
  	for module in "$@"; do
-		if ! modprobe -n -q "$1"; then
+		if ! modprobe -n -q "$module"; then
  			missing+=("$module")
  		fi
  	done