Skip to contentSkip to conversation

drivers/net/fec: phy_init: remove redundant logic

PATCH New sbabic at denx.de 5 participants 9 messages Mar 13, 2019 – Mar 28, 2019 4 messages not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 34/34 drivers/net/fec: phy_init: remove redundant logic

Quoted 5 lines

The phy_connect_dev(...) function from phy.c does all the handling (inclusive catching fixed-link).
So we drop here the single steps and call just phy_connect_dev(...).

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#1 lore raw

PATCH 34/34 drivers/net/fec: phy_init: remove redundant logic

Hi Stefano

Quoted 6 lines · sbabic at denx.de
Quoted 6 lines

The phy_connect_dev(...) function from phy.c does all the handling (inclusive catching fixed-link).
So we drop here the single steps and call just phy_connect_dev(...).

Quoted 1 line
Quoted 6 lines
Quoted 1 line

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Unfortunately, this commit broke Ethernet on the Vybrid. When re-basing my Colibri VF50/VF61 clean-up patch set ("colibri vybrid fixes, device tree enablement and driver model conversion") I noticed that Ethernet no longer works giving the following error messages:

Net:   Could not get PHY for FEC0: addr -19
eth-1: fec at 400d1000

Colibri VFxx # dhcp
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
No ethernet found.
Could not get PHY for FEC0: addr -19
Colibri VFxx #

Bisecting points to this commit and reverting it indeed makes it work again.

Has anybody else seen a similar issue (e.g. @Lukasz on pcm052)?

Cheers

Marcel

#2 lore raw

PATCH 34/34 drivers/net/fec: phy_init: remove redundant logic

Hi Marcel,

Quoted 33 lines

Hi Stefano

Quoted 7 lines · sbabic at denx.de
Quoted 7 lines

The phy_connect_dev(...) function from phy.c does all the handling (inclusive catching fixed-link).
So we drop here the single steps and call just phy_connect_dev(...).
Signed-off-by: Hannes Schmelzer <[email protected]

Quoted 1 line
Quoted 6 lines
Quoted 1 line

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Unfortunately, this commit broke Ethernet on the Vybrid. When re-basing my Colibri VF50/VF61 clean-up patch set ("colibri vybrid fixes, device tree enablement and driver model conversion") I noticed that Ethernet no longer works giving the following error messages:

Net:   Could not get PHY for FEC0: addr -19
eth-1: fec at 400d1000

Colibri VFxx # dhcp
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
No ethernet found.
Could not get PHY for FEC0: addr -19
Colibri VFxx #

Quoted 4 lines

Bisecting points to this commit and reverting it indeed makes it work again.

Has anybody else seen a similar issue (e.g. @Lukasz on pcm052)?

I did not checked yet - as I was waiting for the code to settle down to mainline (after the v2019.04 u-boot release).

I will check it on bk4.

Quoted 4 lines

Cheers

Marcel

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190325/74ce3e98/attachment.sig>

#3 lore raw

PATCH 34/34 drivers/net/fec: phy_init: remove redundant logic

Dear Tom, Marcel, Stefano

Quoted 39 lines

Hi Marcel,

Quoted 37 lines

Hi Stefano

Quoted 7 lines · sbabic at denx.de
Quoted 7 lines

The phy_connect_dev(...) function from phy.c does all the handling (inclusive catching fixed-link).
So we drop here the single steps and call just phy_connect_dev(...).
Signed-off-by: Hannes Schmelzer <[email protected]

Quoted 1 line
Quoted 6 lines
Quoted 1 line

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Unfortunately, this commit broke Ethernet on the Vybrid. When re-basing my Colibri VF50/VF61 clean-up patch set ("colibri vybrid fixes, device tree enablement and driver model conversion") I noticed that Ethernet no longer works giving the following error messages:

Net:   Could not get PHY for FEC0: addr -19
eth-1: fec at 400d1000

Colibri VFxx # dhcp
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
No ethernet found.
Could not get PHY for FEC0: addr -19
Colibri VFxx #

Bisecting points to this commit and reverting it indeed makes it work again.

Quoted 6 lines
Quoted 1 line

Has anybody else seen a similar issue (e.g. @Lukasz on pcm052)?

I did not checked yet - as I was waiting for the code to settle down to mainline (after the v2019.04 u-boot release).

I will check it on bk4.

Maybe not on BK4, but surely on (HSC):
CPU: Freescale i.MX53 rev2.1 at 800 MHz

=> dhcp
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
No ethernet found.
Could not get PHY for FEC0: addr -19

I can confirm the error.

So I do expect that we have some more IMX boards broken (imx53, vybrid).

I think that it would be best to revert this patch before v2019.04 release and look for clean up opportunities afterwards.

Quoted 11 lines
Quoted 5 lines

Cheers

Marcel

Best regards,

Quoted 8 lines

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.de

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190328/38c557e0/attachment.sig>

#4 lore raw

[U-Boot] Antwort: Re: [REGRESSION: PATCH 34/34] drivers/net/fec: phy_init: remove redundant logic

HI Lukas,

please can you test with this patch:

But i agree, for 2019.04 it would be ok reverting this and then look if the provided patch can be applied.

Joe, what do you mean?

cheers,
Hannes

Lukasz Majewski <[email protected]> schrieb am 28.03.2019 11:47:34:

Quoted 4 lines

Von: Lukasz Majewski <[email protected]>
An: Marcel Ziswiler <[email protected]>, "sbabic at denx.de" <[email protected]>, Tom Rini <[email protected]>
Kopie: "u-boot at lists.denx.de" <[email protected]>,

"hannes.schmelzer at br-

Quoted 4 lines

automation.com" <[email protected]>, Joe Hershberger <[email protected]>
Datum: 28.03.2019 11:47
Betreff: Re: [REGRESSION: PATCH 34/34] drivers/net/fec: phy_init: remove

redundant logic

Quoted 94 lines

Dear Tom, Marcel, Stefano

Quoted 39 lines

Hi Marcel,

Quoted 37 lines

Hi Stefano

Quoted 7 lines · sbabic at denx.de
Quoted 7 lines

The phy_connect_dev(...) function from phy.c does all the handling (inclusive catching fixed-link).
So we drop here the single steps and call just phy_connect_dev(...).
Signed-off-by: Hannes Schmelzer <[email protected]

Quoted 1 line
Quoted 6 lines
Quoted 1 line

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Unfortunately, this commit broke Ethernet on the Vybrid. When re-basing my Colibri VF50/VF61 clean-up patch set ("colibri vybrid fixes, device tree enablement and driver model conversion") I noticed that Ethernet no longer works giving the following error messages:

Net:   Could not get PHY for FEC0: addr -19
eth-1: fec at 400d1000

Colibri VFxx # dhcp
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
No ethernet found.
Could not get PHY for FEC0: addr -19
Colibri VFxx #

Bisecting points to this commit and reverting it indeed makes it work again.

Quoted 6 lines
Quoted 1 line

Has anybody else seen a similar issue (e.g. @Lukasz on pcm052)?

I did not checked yet - as I was waiting for the code to settle down to mainline (after the v2019.04 u-boot release).

I will check it on bk4.

Maybe not on BK4, but surely on (HSC):
CPU: Freescale i.MX53 rev2.1 at 800 MHz

=> dhcp
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
No ethernet found.
Could not get PHY for FEC0: addr -19

I can confirm the error.

So I do expect that we have some more IMX boards broken (imx53, vybrid).

I think that it would be best to revert this patch before v2019.04 release and look for clean up opportunities afterwards.

Quoted 11 lines
Quoted 5 lines

Cheers

Marcel

Best regards,

Quoted 8 lines

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.de

Best regards,

Quoted 8 lines

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de [Anhang "att09yen.dat" gelöscht von Hannes Schmelzer/Gilgenberg/AT/B&R]

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drivers-net-phy-catch-negative-phy-adresses.patch
Type: application/octet-stream
Size: 1209 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190328/b36ebcfb/attachment.obj>

#5 lore raw

PATCH 34/34 drivers/net/fec: phy_init: remove redundant logic

In reply to Marcel Ziswiler
Quoted 29 lines · Marcel Ziswiler

Hi Stefano

Quoted 10 lines · sbabic at denx.de
Quoted 6 lines

The phy_connect_dev(...) function from phy.c does all the handling (inclusive catching fixed-link).
So we drop here the single steps and call just phy_connect_dev(...).

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Unfortunately, this commit broke Ethernet on the Vybrid. When re-basing my Colibri VF50/VF61 clean-up patch set ("colibri vybrid fixes, device tree enablement and driver model conversion") I noticed that Ethernet no longer works giving the following error messages:

Net:   Could not get PHY for FEC0: addr -19
eth-1: fec at 400d1000

Colibri VFxx # dhcp
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
No ethernet found.
Could not get PHY for FEC0: addr -19
Colibri VFxx #

Quoted 4 lines

Bisecting points to this commit and reverting it indeed makes it work again.

Has anybody else seen a similar issue (e.g. @Lukasz on pcm052)?

Hi, sorry for that issue.
I will look into tomorrow, to see what happens there.

cheers,
Hannes

#6 lore raw

PATCH 34/34 drivers/net/fec: phy_init: remove redundant logic

In reply to Marcel Ziswiler
Quoted 34 lines · Marcel Ziswiler

Hi Stefano

Quoted 10 lines · sbabic at denx.de
Quoted 6 lines

The phy_connect_dev(...) function from phy.c does all the handling (inclusive catching fixed-link).
So we drop here the single steps and call just phy_connect_dev(...).

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Unfortunately, this commit broke Ethernet on the Vybrid. When re-basing my Colibri VF50/VF61 clean-up patch set ("colibri vybrid fixes, device tree enablement and driver model conversion") I noticed that Ethernet no longer works giving the following error messages:

Net:   Could not get PHY for FEC0: addr -19
eth-1: fec at 400d1000

Colibri VFxx # dhcp
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
No ethernet found.
Could not get PHY for FEC0: addr -19
Colibri VFxx #

Bisecting points to this commit and reverting it indeed makes it work again.

Has anybody else seen a similar issue (e.g. @Lukasz on pcm052)?

Quoted 7 lines

Cheers

Marcel
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

Hi Marcel,
does this board use DM ? which defconfig uses the board?

cheers,
Hannes

#7 lore raw

PATCH 34/34 drivers/net/fec: phy_init: remove redundant logic

Hi Hannes

Quoted 43 lines · Hannes Schmelzer
Quoted 42 lines · Marcel Ziswiler

Hi Stefano

Quoted 8 lines · sbabic at denx.de
Quoted 8 lines

The phy_connect_dev(...) function from phy.c does all the handling
(inclusive catching fixed-link).
So we drop here the single steps and call just phy_connect_dev(...).
Signed-off-by: Hannes Schmelzer < hannes.schmelzer at br-automation.com

Quoted 4 lines

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Unfortunately, this commit broke Ethernet on the Vybrid. When re- basing
my Colibri VF50/VF61 clean-up patch set ("colibri vybrid fixes, device
tree enablement and driver model conversion") I noticed that Ethernet
no longer works giving the following error messages:

Net:   Could not get PHY for FEC0: addr -19
eth-1: fec at 400d1000

Colibri VFxx # dhcp
Could not get PHY for FEC0: addr -19 Could not get PHY for FEC0: addr -19 Could not get PHY for FEC0: addr -19 Could not get PHY for FEC0: addr -19 No ethernet found.
Could not get PHY for FEC0: addr -19 Colibri VFxx #

Bisecting points to this commit and reverting it indeed makes it work
again.

Has anybody else seen a similar issue (e.g. @Lukasz on pcm052)?

Cheers

Quoted 7 lines
Quoted 5 lines

Marcel
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

Hi Marcel,
does this board use DM ?

Yes, I moved it to DM. The latest patch set is the following:

https://patchwork.ozlabs.org/cover/1064570/

Also available on our git server here:

http://git.toradex.com/cgit/u-boot-toradex.git/log/?h=for-next

Quoted 1 line

which defconfig uses the board?

That would be colibri_vf_defconfig.

Quoted 2 lines

cheers,
Hannes

Cheers

Marcel

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#12 lore raw

PATCH 34/34 drivers/net/fec: phy_init: remove redundant logic

Quoted 1 line · Marcel Ziswiler

Hi Hannes

Hi Marcel,
thanks for helping me working on this.

Quoted 8 lines · Hannes Schmelzer
Quoted 4 lines

Hi marcel,

Okay. Behaviour is now clear to me.
You don't have a phy node within your dts

We never ever had any such anywhere but it still used to work just fine so far.

Before that you didn't operate the FEC with DM i think, so there was no description at all.

Quoted 4 lines
Quoted 2 lines

nor you have MXC_PHY_ADDR set in your board header.

I actually once even tried setting that without success but maybe I did it wrong.

Sorry, the correct name of the #define is 'CONFIG_FEC_MXC_PHYADDR'. Prior converting your board to DM you had here:
#define CONFIG_FEC_MXC_PHYADDR 0

Quoted 5 lines
Quoted 3 lines

The implicit fallback mechanism for searching the whole mdio bus for st least one phy has been gone with my patch.

OK, maybe I just missed noticing such behavioural change having been advertised anywhere.

There was no explicit notice, it did happen ;-)
I didn't expect that there is somebody who neither defines a phy-adress within dts nor board-header.

Quoted 4 lines
Quoted 3 lines

Could you try describing your phy within dts to get sure that iam right here.

Sure, let me try that.

Did you have success in this?

Quoted 4 lines
Quoted 3 lines

Later on we have to discuss if the 'fallback' should be re implemented.

Yeah, I assume such behavioural change breaks other boards as well.

Mhm,
you're right - i will provide a patch to the mailinglist for catching this. But in general, a precise description of the hardware would be the better way.

cheers,
Hannes