Skip to contentSkip to conversation

net/octeontx: fix vdev name

PATCH Applied Stephen Hemminger 3 participants 5 messages Mar 13, 2019 – Mar 20, 2019 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 net/octeontx: fix vdev name

The octeontx driver is creating vdev with name "OCTEONTX_PMD" which is an artifact from how RTE_PMD_REGISTER_VDEV arguments work.

Change to use the same convention as all the other network drivers ie "net_octeontx").

---
v2 - fix typo in commit message and name should be net_octeontx
not net_octeon

 drivers/net/octeontx/octeontx_ethdev.h | 1 +
 1 file changed, 1 insertion(+)
drivers/net/octeontx/octeontx_ethdev.h +1 -0
index 920f6f89b882..2a4a08afcc7f 100644
@@ -21,6 +21,7 @@
 #include "base/octeontx_pkovf.h"
 #include "base/octeontx_io.h"
 
+#define OCTEONTX_PMD				net_octeontx
 #define OCTEONTX_VDEV_DEFAULT_MAX_NR_PORT	12
 #define OCTEONTX_VDEV_NR_PORT_ARG		("nr_port")
 #define OCTEONTX_MAX_NAME_LEN			32
Signature · 1 line
2.17.1
#2 lore raw
Quoted 5 lines · Jerin Jacob Kollanukkaran
Quoted 4 lines · Stephen Hemminger

The octeontx driver is creating vdev with name "OCTEONTX_PMD" which is an artifact from how RTE_PMD_REGISTER_VDEV arguments work.

Quoted 9 lines
Quoted 6 lines

Change to use the same convention as all the other network drivers ie "net_octeontx").

---

Hi Jerin, Stephen,

Can you please provide fixes line, (which commit broke the pmd name)?

Thanks,
ferruh

#3 lore raw
Quoted 13 lines · On Tue, 19 Mar 2019 18:59:21 +0000 Ferruh Yigit <[email protected]> wrote:
Quoted 12 lines · Jerin Jacob Kollanukkaran
Quoted 10 lines · Stephen Hemminger

The octeontx driver is creating vdev with name "OCTEONTX_PMD" which is an artifact from how RTE_PMD_REGISTER_VDEV arguments work.

Change to use the same convention as all the other network drivers ie "net_octeontx").

---

Quoted 6 lines
Quoted 2 lines

Hi Jerin, Stephen,

Can you please provide fixes line, (which commit broke the pmd name)?

It goes all the way back to original submission:

Fixes f7be70e5130e ("net/octeontx: add net device probe and remove")
Applied
#4 lore raw
Quoted 19 lines · Stephen Hemminger
Quoted 16 lines · On Tue, 19 Mar 2019 18:59:21 +0000 Ferruh Yigit <[email protected]> wrote:
Quoted 14 lines · Jerin Jacob Kollanukkaran
Quoted 10 lines · Stephen Hemminger

The octeontx driver is creating vdev with name "OCTEONTX_PMD" which is an artifact from how RTE_PMD_REGISTER_VDEV arguments work.

Change to use the same convention as all the other network drivers ie "net_octeontx").

---

Quoted 8 lines
Quoted 3 lines

Hi Jerin, Stephen,

Can you please provide fixes line, (which commit broke the pmd name)?

It goes all the way back to original submission:

Fixes f7be70e5130e ("net/octeontx: add net device probe and remove")

Indeed, I was assuming it has been broken somewhere on the way, but is seems no.

Applied to dpdk-next-net/master, thanks.