Skip to contentSkip to conversation

arm64: dts: stratix10: add the sysmgr-syscon property from the gmac's

PATCH In review Dinh Nguyen 2 participants 4 messages Mar 14, 2019 – Apr 15, 2019

Subsystems (3)
lore
Share & tools
lore

Dinh Nguyen

author maintainer
#0 lore raw

PATCH 1/1 arm64: dts: stratix10: add the sysmgr-syscon property from the gmac's

The gmac ethernet driver uses the "altr,sysmgr-syscon" property to configure phy settings for the gmac controller.

Add the "altr,sysmgr-syscon" property to all gmac nodes.

This patch fixes:

[    0.917530] socfpga-dwmac ff800000.ethernet: No sysmgr-syscon node found
[    0.924209] socfpga-dwmac ff800000.ethernet: Unable to parse OF data
---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi +3 -0
index 7c649f6b14cb..cd7c76e58b09 100644
@@ -162,6 +162,7 @@
 			rx-fifo-depth = <16384>;
 			snps,multicast-filter-bins = <256>;
 			iommus = <&smmu 1>;
+			altr,sysmgr-syscon = <&sysmgr 0x44 0>;
 			status = "disabled";
 		};
 
@@ -179,6 +180,7 @@
 			rx-fifo-depth = <16384>;
 			snps,multicast-filter-bins = <256>;
 			iommus = <&smmu 2>;
+			altr,sysmgr-syscon = <&sysmgr 0x48 0>;
 			status = "disabled";
 		};
 
@@ -196,6 +198,7 @@
 			rx-fifo-depth = <16384>;
 			snps,multicast-filter-bins = <256>;
 			iommus = <&smmu 3>;
+			altr,sysmgr-syscon = <&sysmgr 0x4c 0>;
 			status = "disabled";
 		};
 
Signature · 1 line
2.20.0
#1 lore raw

Hi,

Quoted 5 lines · Dinh Nguyen

The gmac ethernet driver uses the "altr,sysmgr-syscon" property to configure phy settings for the gmac controller.

Add the "altr,sysmgr-syscon" property to all gmac nodes.

Quoted 8 lines

This patch fixes:

[    0.917530] socfpga-dwmac ff800000.ethernet: No sysmgr-syscon node found
[    0.924209] socfpga-dwmac ff800000.ethernet: Unable to parse OF data

This patch broke the boot on my board when upgrading from v5.1-rc3 to -rc4 (using a simple custom DTS including socfpga_stratix10.dtsi, basically enabling just ethernet and serial console). Previously, when the socfpga-dwmac probe failed with above messages, the generic dwmac driver was used instead to get working networking.

Now that the socfpga-dwmac probe succeeds, there's a sudden reset/crash due to exception. Apparently the reason is that the access to these registers is restricted from the kernel and the mainline socfpga-dwmac driver is missing the support for the SMC call access? Am I missing something, or was it too early to apply this patch to mainline?

A.

Quoted 40 lines
---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi +3 -0
index 7c649f6b14cb..cd7c76e58b09 100644
@@ -162,6 +162,7 @@
 			rx-fifo-depth = <16384>;
 			snps,multicast-filter-bins = <256>;
 			iommus = <&smmu 1>;
+			altr,sysmgr-syscon = <&sysmgr 0x44 0>;
 			status = "disabled";
 		};
 
@@ -179,6 +180,7 @@
 			rx-fifo-depth = <16384>;
 			snps,multicast-filter-bins = <256>;
 			iommus = <&smmu 2>;
+			altr,sysmgr-syscon = <&sysmgr 0x48 0>;
 			status = "disabled";
 		};
 
@@ -196,6 +198,7 @@
 			rx-fifo-depth = <16384>;
 			snps,multicast-filter-bins = <256>;
 			iommus = <&smmu 3>;
+			altr,sysmgr-syscon = <&sysmgr 0x4c 0>;
 			status = "disabled";
 		};
 
Signature · 7 lines
2.20.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#2 lore raw

Hi Aaro,

Quoted 23 lines · Aaro Koskinen

Hi,

Quoted 5 lines · Dinh Nguyen

The gmac ethernet driver uses the "altr,sysmgr-syscon" property to configure phy settings for the gmac controller.

Add the "altr,sysmgr-syscon" property to all gmac nodes.

Quoted 8 lines

This patch fixes:

[    0.917530] socfpga-dwmac ff800000.ethernet: No sysmgr-syscon node found
[    0.924209] socfpga-dwmac ff800000.ethernet: Unable to parse OF data

This patch broke the boot on my board when upgrading from v5.1-rc3 to -rc4 (using a simple custom DTS including socfpga_stratix10.dtsi, basically enabling just ethernet and serial console). Previously, when the socfpga-dwmac probe failed with above messages, the generic dwmac driver was used instead to get working networking.

Quoted 6 lines

Now that the socfpga-dwmac probe succeeds, there's a sudden reset/crash due to exception. Apparently the reason is that the access to these registers is restricted from the kernel and the mainline socfpga-dwmac driver is missing the support for the SMC call access? Am I missing something, or was it too early to apply this patch to mainline?

Argh, you're right! Apologies, but I think this patch is to early to apply to mainline. As there was a patch that we have downstream to support the SMC call access, I made a mistake and tested this patch with it. Let me try to clean up the downstream patch for submission to fix this.

Meanwhile, are you ok with just using the generic dwmac driver to get around this issue? Otherwise, I can ask the to revert the patch.

Dinh

#3 lore raw

Hi,

Quoted 28 lines · Dinh Nguyen
Quoted 21 lines · Aaro Koskinen
Quoted 5 lines · Dinh Nguyen

The gmac ethernet driver uses the "altr,sysmgr-syscon" property to configure phy settings for the gmac controller.

Add the "altr,sysmgr-syscon" property to all gmac nodes.

Quoted 8 lines

This patch fixes:

[    0.917530] socfpga-dwmac ff800000.ethernet: No sysmgr-syscon node found
[    0.924209] socfpga-dwmac ff800000.ethernet: Unable to parse OF data

This patch broke the boot on my board when upgrading from v5.1-rc3 to -rc4 (using a simple custom DTS including socfpga_stratix10.dtsi, basically enabling just ethernet and serial console). Previously, when the socfpga-dwmac probe failed with above messages, the generic dwmac driver was used instead to get working networking.

Quoted 5 lines

Now that the socfpga-dwmac probe succeeds, there's a sudden reset/crash due to exception. Apparently the reason is that the access to these registers is restricted from the kernel and the mainline socfpga-dwmac driver is missing the support for the SMC call access? Am I missing something, or was it too early to apply this patch to mainline?

Quoted 4 lines

Argh, you're right! Apologies, but I think this patch is to early to apply to mainline. As there was a patch that we have downstream to support the SMC call access, I made a mistake and tested this patch with it. Let me try to clean up the downstream patch for submission to fix this.

Ok, thanks for comforming.

Quoted 2 lines

Meanwhile, are you ok with just using the generic dwmac driver to get around this issue? Otherwise, I can ask the to revert the patch.

Personally I'm fine with the generic dwmac for time being.

A.